New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702033 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Deps for media mojom typemaps are wrong

Project Member Reported by alokp@chromium.org, Mar 16 2017

Issue description

Patch https://codereview.chromium.org/2754683004/

ninja -C out/Debug/ media/mojo/interfaces:foo

[13/14] CXX obj/media/mojo/interfaces/foo/foo.mojom.o
FAILED: obj/media/mojo/interfaces/foo/foo.mojom.o 
/usr/local/google/home/alokp/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/media/mojo/interfaces/foo/foo.mojom.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"296321-1\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -m64 -march=x86-64 -pthread -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -O0 -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fvisibility-inlines-hidden -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -fno-exceptions -c gen/media/mojo/interfaces/foo.mojom.cc -o obj/media/mojo/interfaces/foo/foo.mojom.o
In file included from gen/media/mojo/interfaces/foo.mojom.cc:15:
In file included from gen/media/mojo/interfaces/foo.mojom.h:34:
In file included from gen/media/mojo/interfaces/media_types.mojom.h:48:
In file included from ../../media/base/video_codecs.h:12:
In file included from ../../ui/gfx/color_space.h:14:
In file included from ../../third_party/skia/include/core/SkColorSpace.h:11:
In file included from ../../third_party/skia/include/core/SkMatrix44.h:11:
In file included from ../../third_party/skia/include/core/SkMatrix.h:13:
In file included from ../../third_party/skia/include/core/SkRect.h:11:
In file included from ../../third_party/skia/include/core/SkPoint.h:11:
In file included from ../../third_party/skia/include/core/SkMath.h:13:
../../third_party/skia/include/core/SkTypes.h:30:10: fatal error: 'SkUserConfig.h' file not found
#include "SkUserConfig.h"
         ^~~~~~~~~~~~~~~~
1 error generated.
ninja: build stopped: subcommand failed.

 

Comment 1 by alokp@chromium.org, Mar 16 2017

gn path out/Debug/ media/mojo/interfaces:foo skia --public

No public paths found between these two targets

Comment 2 by alokp@chromium.org, Mar 16 2017

I think the issue is media_types.typemap lists //media as private deps. In fact this is a problem with all media typemap files.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58e4a73d8f76c0683d60cca2a487e88090b05fce

commit 58e4a73d8f76c0683d60cca2a487e88090b05fce
Author: alokp <alokp@chromium.org>
Date: Thu Mar 16 18:43:05 2017

Makes //media public_deps of media_types.typemap.

This provides the transitive dependency on skia which is required by
media/base/video_codecs.h.

BUG= 702033 

Review-Url: https://codereview.chromium.org/2750283002
Cr-Commit-Position: refs/heads/master@{#457503}

[modify] https://crrev.com/58e4a73d8f76c0683d60cca2a487e88090b05fce/media/mojo/interfaces/media_types.typemap

Comment 4 by alokp@chromium.org, Mar 16 2017

Status: Fixed (was: Assigned)

Sign in to add a comment