New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702027 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Reopening Twitter refreshes the page on launch

Project Member Reported by sbirch@chromium.org, Mar 16 2017

Issue description

Version: 59.0.3041.0
 

Comment 1 by sbirch@chromium.org, Mar 16 2017

A little more info:
- You need to log in first. I can repro this looking at the timeline.
- This works in shortcut A2HS
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/763a6232141799360238b6f53b728525c171d7bf

commit 763a6232141799360238b6f53b728525c171d7bf
Author: pkotwicz <pkotwicz@chromium.org>
Date: Tue Mar 21 15:38:28 2017

Merge WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME and ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME

BUG= 702027 

Review-Url: https://codereview.chromium.org/2760103002
Cr-Commit-Position: refs/heads/master@{#458423}

[modify] https://crrev.com/763a6232141799360238b6f53b728525c171d7bf/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/763a6232141799360238b6f53b728525c171d7bf/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
[modify] https://crrev.com/763a6232141799360238b6f53b728525c171d7bf/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java
[modify] https://crrev.com/763a6232141799360238b6f53b728525c171d7bf/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
[modify] https://crrev.com/763a6232141799360238b6f53b728525c171d7bf/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
[modify] https://crrev.com/763a6232141799360238b6f53b728525c171d7bf/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java
[modify] https://crrev.com/763a6232141799360238b6f53b728525c171d7bf/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java
[modify] https://crrev.com/763a6232141799360238b6f53b728525c171d7bf/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
[modify] https://crrev.com/763a6232141799360238b6f53b728525c171d7bf/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e44ebc7dcf7c343d45694b97b2edc455f1a6256

commit 0e44ebc7dcf7c343d45694b97b2edc455f1a6256
Author: pkotwicz <pkotwicz@chromium.org>
Date: Mon Mar 27 16:25:49 2017

[Android WebAPKs] Don't navigate WebAPK when launching it from launcher

This CL navigates WebAPK's Web Contents:
- when WebAPK is opened for the first time
- when WebAPK is opened from a deep link and it is already running

In particular, this CL stops navigating an already open WebAPK if a user reopens the WebAPK from the launcher.

BUG= 702027 

Review-Url: https://codereview.chromium.org/2758193002
Cr-Commit-Position: refs/heads/master@{#459799}

[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcher.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/webapk/shell_apk/shell_apk_version.gni
[modify] https://crrev.com/0e44ebc7dcf7c343d45694b97b2edc455f1a6256/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java

Status: Fixed (was: Available)
Cc: sbirch@chromium.org owe...@chromium.org aska...@chromium.org
 Issue 706681  has been merged into this issue.

Sign in to add a comment