New issue
Advanced search Search tips

Issue 702025 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove duplicate tests for promise rejection events

Project Member Reported by domenic@chromium.org, Mar 16 2017

Issue description

Our tests for promise rejection events were upstreamed to web platform tests in https://github.com/w3c/web-platform-tests/pull/2388. They should be being imported into the tree automatically these days. Thus we can delete our copies at src/third_party/WebKit/LayoutTests/http/tests/dom/.

I'll work on this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1957a5e6746fa96d51bb057f3ba5584446bffb65

commit 1957a5e6746fa96d51bb057f3ba5584446bffb65
Author: domenic <domenic@chromium.org>
Date: Thu Apr 06 11:19:49 2017

Remove now-redundant promise rejection event tests

These tests were upstreamed to web-platform-tests in
https://github.com/w3c/web-platform-tests/pull/2388. Several
Chromium-specific tests remain but the ones deleted in this commit are
redundant with the versions now found in
third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/.

BUG= 702025 

Review-Url: https://codereview.chromium.org/2798273002
Cr-Commit-Position: refs/heads/master@{#462422}

[delete] https://crrev.com/8deebddfd6875aa12740eb2060a3e3f760116ea5/third_party/WebKit/LayoutTests/fast/dom/promise-rejection-events-attached-in-event-expected.txt
[delete] https://crrev.com/8deebddfd6875aa12740eb2060a3e3f760116ea5/third_party/WebKit/LayoutTests/fast/dom/promise-rejection-events-attached-in-event.html
[delete] https://crrev.com/8deebddfd6875aa12740eb2060a3e3f760116ea5/third_party/WebKit/LayoutTests/fast/dom/promise-rejection-events-onerror.html
[delete] https://crrev.com/8deebddfd6875aa12740eb2060a3e3f760116ea5/third_party/WebKit/LayoutTests/fast/events/constructors/promise-rejection-event-constructor.html
[delete] https://crrev.com/8deebddfd6875aa12740eb2060a3e3f760116ea5/third_party/WebKit/LayoutTests/http/tests/dom/promise-rejection-events-expected.txt
[delete] https://crrev.com/8deebddfd6875aa12740eb2060a3e3f760116ea5/third_party/WebKit/LayoutTests/http/tests/dom/promise-rejection-events.html
[delete] https://crrev.com/8deebddfd6875aa12740eb2060a3e3f760116ea5/third_party/WebKit/LayoutTests/http/tests/dom/resources/promise-rejection-events.js

Status: Fixed (was: Assigned)

Sign in to add a comment