New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702024 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add trace events in NavigationControllerImpl::back/forward(...).

Project Member Reported by sunjian@chromium.org, Mar 16 2017

Issue description

Add trace events in NavigationControllerImpl::back/forward(...).

Currently, there are a small set of user input events that will trigger
SPA (Single Page App) navigations. We just found out that pressing
back/forward buttons can also trigger SPA navigations. When that happens,
there is no input handling in the browser process, which is what we use
to capture as navigation start event when user-input-triggered SPA navigations
happened. Therefore, we need to add trace events in
NavigationControllerImpl::back/forward(...) function calls and capture them
as navigation start events when SPA navigations happen.

 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/666f71455a4f01ee74a1dee3bab82ed62813c255

commit 666f71455a4f01ee74a1dee3bab82ed62813c255
Author: sunjian <sunjian@chromium.org>
Date: Fri Mar 17 00:28:59 2017

Add trace events in NavigationControllerImpl::back/forward(...).

Currently, there is a small set of user input events that will trigger
SPA (Single Page App) navigations. We just found out that pressing
back/forward buttons can also trigger SPA navigations. When that happens,
there is no input handling in the browser process, which is what we use
to capture as navigation start event when user-input-triggered SPA navigations
happened. Therefore, we need to add trace events in
NavigationControllerImpl::back/forward(...) function calls and capture them
as navigation start events when SPA navigations happen.

BUG= 702024 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2748393003
Cr-Commit-Position: refs/heads/master@{#457624}

[modify] https://crrev.com/666f71455a4f01ee74a1dee3bab82ed62813c255/content/browser/frame_host/navigation_controller_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment