New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702023 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Make GrabWindowSnapshot and GrabViewSnapshot grab the on-screen contents on Win32

Project Member Reported by jbau...@chromium.org, Mar 16 2017

Issue description

Currently we use snapshot_aura.cc. This does a CopyOutputRequest in the compositor, which doesn't necessarily get the contents that are actually on-screen.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c2c9631a434330c2982f0062a159f167879e2e8

commit 0c2c9631a434330c2982f0062a159f167879e2e8
Author: jbauman <jbauman@chromium.org>
Date: Thu Apr 06 21:43:39 2017

Use PrintWindow() to implement snapshots on windows 8.1+

This allows us to capture what DirectComposition is actually displaying
and make GPU integration tests able to detect more possible problems.

The existing Aura capture path is used on Windows versions before 8.1,
because they don't support PW_RENDERFULLCONTENT and then PrintWindow may
not get the correct content.
NativeDesktopMediaList::CaptureAuraWindowThumbnail also will use the
aura path, because it's used in production for webrtc and needs to be
efficient.

BUG= 702023 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2752373002
Cr-Commit-Position: refs/heads/master@{#462631}

[modify] https://crrev.com/0c2c9631a434330c2982f0062a159f167879e2e8/chrome/browser/media/webrtc/native_desktop_media_list.cc
[modify] https://crrev.com/0c2c9631a434330c2982f0062a159f167879e2e8/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/0c2c9631a434330c2982f0062a159f167879e2e8/ui/gl/gl_surface_osmesa_win.cc
[modify] https://crrev.com/0c2c9631a434330c2982f0062a159f167879e2e8/ui/snapshot/BUILD.gn
[modify] https://crrev.com/0c2c9631a434330c2982f0062a159f167879e2e8/ui/snapshot/snapshot_aura.cc
[add] https://crrev.com/0c2c9631a434330c2982f0062a159f167879e2e8/ui/snapshot/snapshot_aura.h
[add] https://crrev.com/0c2c9631a434330c2982f0062a159f167879e2e8/ui/snapshot/snapshot_win.cc
[add] https://crrev.com/0c2c9631a434330c2982f0062a159f167879e2e8/ui/snapshot/snapshot_win.h

Status: Fixed (was: Started)

Sign in to add a comment