New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702010 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 594675



Sign in to add a comment

Calculate render surface's is_clipped value outside cc property tree building

Project Member Reported by jaydasika@chromium.org, Mar 15 2017

Issue description

This is currently computed while building the clip tree in cc.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1f7bf4dd89d99927cc99ae6f7ad92a567684110

commit c1f7bf4dd89d99927cc99ae6f7ad92a567684110
Author: jaydasika <jaydasika@chromium.org>
Date: Mon Mar 27 19:37:45 2017

cc : Make visible rect independant of render surface's is_clipped value

This is needed to move render surface's is_clipped value computation
later in the pipeline (during render surface layer list computation)

BUG= 702010 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2764343006
Cr-Commit-Position: refs/heads/master@{#459853}

[modify] https://crrev.com/c1f7bf4dd89d99927cc99ae6f7ad92a567684110/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/c1f7bf4dd89d99927cc99ae6f7ad92a567684110/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/c1f7bf4dd89d99927cc99ae6f7ad92a567684110/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1553a14bd799b2dd09bebeeeda934379318eaf7e

commit 1553a14bd799b2dd09bebeeeda934379318eaf7e
Author: jaydasika <jaydasika@chromium.org>
Date: Wed Apr 05 00:37:09 2017

cc : Compute render surface is_clipped outside property tree building

* Compute render surface is_clipped while computing draw properties.
This is computed by determining if there is any contributing layer that
escapes clip.

* Delete PreCalculateMetaInformation layer tree walk

* Delete has_unclipped_descendants and surface_is_clipped from effect
node

* Calculate NumDescendantsThatDrawContent dynamically for tests that
build layer tree on impl

* Delete num_descendants_that_draw_content and
num_unclipped_descendants from LayerImplTestProperties

BUG= 702010 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2781483006
Cr-Commit-Position: refs/heads/master@{#461917}

[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/layers/layer.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/layers/layer_impl_test_properties.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/layers/render_surface_impl.h
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/test/fake_layer_tree_host_impl.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/test/fake_layer_tree_host_impl.h
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/effect_node.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/effect_node.h
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/layer_tree_host.h
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/1553a14bd799b2dd09bebeeeda934379318eaf7e/cc/trees/property_tree_builder.h

Status: Fixed (was: Assigned)

Sign in to add a comment