New issue
Advanced search Search tips

Issue 702006 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Incorrect behavior of LayoutTests/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint.html

Project Member Reported by wangxianzhu@chromium.org, Mar 15 2017

Issue description

Open the file in a browser on a low-dpi machine. The contents of the scrolling area don't scroll.

Found this during working on https://codereview.chromium.org/2732573003/.

 
Labels: -Pri-3 BugSource-Team PaintTeamTriaged-20170315 Pri-2
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5db93ce184722588b24a21fc2f9c53b16cf9a45b

commit 5db93ce184722588b24a21fc2f9c53b16cf9a45b
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Mar 16 22:20:25 2017

Modify paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint-expected.html to show bug

Previously the test was written in a way to hide the bug. It only
checked paint invalidation of the scrollbar. We miss paint invalidation
of the contents.

Convert the test into a text-based-repaint test, and move it to
paint/invalidation/compositing.

BUG= 702006 

Review-Url: https://codereview.chromium.org/2747333006
Cr-Commit-Position: refs/heads/master@{#457583}

[modify] https://crrev.com/5db93ce184722588b24a21fc2f9c53b16cf9a45b/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/94875b3b4d4a1fc047b99214f30078f3780259f0/third_party/WebKit/LayoutTests/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt
[delete] https://crrev.com/94875b3b4d4a1fc047b99214f30078f3780259f0/third_party/WebKit/LayoutTests/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint.html
[add] https://crrev.com/5db93ce184722588b24a21fc2f9c53b16cf9a45b/third_party/WebKit/LayoutTests/paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint-expected.html
[add] https://crrev.com/5db93ce184722588b24a21fc2f9c53b16cf9a45b/third_party/WebKit/LayoutTests/paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt
[add] https://crrev.com/5db93ce184722588b24a21fc2f9c53b16cf9a45b/third_party/WebKit/LayoutTests/paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint.html
[delete] https://crrev.com/94875b3b4d4a1fc047b99214f30078f3780259f0/third_party/WebKit/LayoutTests/platform/android/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt
[delete] https://crrev.com/94875b3b4d4a1fc047b99214f30078f3780259f0/third_party/WebKit/LayoutTests/platform/android/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt
[delete] https://crrev.com/94875b3b4d4a1fc047b99214f30078f3780259f0/third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt

Cc: chrishtr@chromium.org wkorman@chromium.org
Status: Available (was: Assigned)
I'm not working on this for now. Feel free to take over it.
Cc: wangxianzhu@chromium.org
Owner: ----
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 20

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -wkorman@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Will first verify the test and update expectations if needed.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e544e0f5df8442c954ff7da1f2cbedec836f55

commit 70e544e0f5df8442c954ff7da1f2cbedec836f55
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Aug 21 03:21:38 2018

Update paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint.html

The bug no longer reproduces. Remove the failure expectation, rename it
to scrolling-neg-z-index-descendants.html because there is no repaint
needed for the composited neg-z-index layer, and update the baseline.

Bug:  702006 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I87f2f2d93b8024a21aed5929f1fe601065db9806
Reviewed-on: https://chromium-review.googlesource.com/1181522
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584628}
[modify] https://crrev.com/70e544e0f5df8442c954ff7da1f2cbedec836f55/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/70e544e0f5df8442c954ff7da1f2cbedec836f55/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/70e544e0f5df8442c954ff7da1f2cbedec836f55/third_party/WebKit/LayoutTests/paint/invalidation/compositing/scrolling-neg-z-index-descendants-expected.html
[add] https://crrev.com/70e544e0f5df8442c954ff7da1f2cbedec836f55/third_party/WebKit/LayoutTests/paint/invalidation/compositing/scrolling-neg-z-index-descendants-expected.txt
[delete] https://crrev.com/62067965541204a49faef0a92e9e2f6e2d50fe8a/third_party/WebKit/LayoutTests/paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt
[rename] https://crrev.com/70e544e0f5df8442c954ff7da1f2cbedec836f55/third_party/WebKit/LayoutTests/paint/invalidation/compositing/scrolling-neg-z-index-descendants.html

Status: Fixed (was: Assigned)

Sign in to add a comment