New issue
Advanced search Search tips

Issue 701999 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

SingleClientPrintersSyncTest.EditPrinter is flaky

Project Member Reported by jdufault@chromium.org, Mar 15 2017

Issue description

SingleClientPrintersSyncTest.EditPrinter is flaky. Original CL at [1].

An example failure is at [2]. Here is failing test output:

  SingleClientPrintersSyncTest.EditPrinter (run #1):
  [ RUN      ] SingleClientPrintersSyncTest.EditPrinter
  [17562:17562:0315/144654.094677:WARNING:chrome_browser_main_chromeos.cc(369)] Running as stub user with profile dir: test-user
  [17562:17562:0315/144654.291175:WARNING:audio_manager.cc(295)] Multiple instances of AudioManager detected
  [17562:17562:0315/144654.291199:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager detected
  [17562:17562:0315/144654.384443:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension  : ahfgeienlihckogmohjhadlkjgocpleb / Web Store because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app.
  [17562:17562:0315/144654.384492:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension  : eemcgdkfndhakfknompkggombfjjjeno / Bookmark Manager because of 'signin_screen' is only allowed for packaged apps, but this is a extension.
  [17562:17562:0315/144654.384522:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension  : mgndgikekgjfcpckkfioiadnlibdjbkf / Chromium because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app.
  [17562:17562:0315/144654.384543:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension  : nkoccljplnhpfnfiajclkommnmllphnl / crosh_builtin because of 'signin_screen' is only allowed for packaged apps, but this is a extension.
  [17562:17608:0315/144654.389860:WARNING:freezer_cgroup_process_manager.cc(61)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
  [17562:17562:0315/144654.510661:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension  : ahfgeienlihckogmohjhadlkjgocpleb / Web Store because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app.
  [17562:17562:0315/144654.510711:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension  : eemcgdkfndhakfknompkggombfjjjeno / Bookmark Manager because of 'signin_screen' is only allowed for packaged apps, but this is a extension.
  [17562:17562:0315/144654.510748:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension  : mgndgikekgjfcpckkfioiadnlibdjbkf / Chromium because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app.
  [17562:17562:0315/144654.510791:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension  : nkoccljplnhpfnfiajclkommnmllphnl / crosh_builtin because of 'signin_screen' is only allowed for packaged apps, but this is a extension.
  [17562:17777:0315/144654.959036:WARNING:syncer_proto_util.cc(338)] Error posting from syncer: Response Code (bogus on error): -1 Content-Length (bogus on error): -1 Server Status: SYNC_AUTH_ERROR
  [17562:17777:0315/144654.959814:WARNING:sync_encryption_handler_impl.cc(971)] Nigori had empty encryption keybag.
  [17562:17777:0315/144654.960184:WARNING:sync_encryption_handler_impl.cc(971)] Nigori had empty encryption keybag.
  [17562:17562:0315/144654.966081:ERROR:chrome_signin_client.cc(179)] Device ID is not set for user.
  [17562:17777:0315/144654.968188:WARNING:sync_encryption_handler_impl.cc(347)] Ignoring new implicit passphrase. Keystore migration already performed.
  [17562:17562:0315/144655.314252:FATAL:printers_sync_bridge.cc(89)] Check failed: store_.
  #0 0x000001e0dbc7 base::debug::StackTrace::StackTrace()
  #1 0x000001e205ca logging::LogMessage::~LogMessage()
  #2 0x0000019d397b chromeos::PrintersSyncBridge::AddPrinter()
  #3 0x0000019d1f2b chromeos::PrintersManager::RegisterPrinter()
  #4 0x000001cb1bc9 printers_helper::AddPrinter()
  #5 0x000000459f86 SingleClientPrintersSyncTest_EditPrinter_Test::RunTestOnMainThread()
  #6 0x000001ccc407 InProcessBrowserTest::RunTestOnMainThreadLoop()
  #7 0x000005394913 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
  #8 0x0000020956c6 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
  #9 0x0000020947f1 ChromeBrowserMainParts::PreMainMessageLoopRun()
  #10 0x00000184097f chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
  #11 0x0000009da695 content::BrowserMainLoop::PreMainMessageLoopRun()
  #12 0x000000ca8636 content::StartupTaskRunner::RunAllTasksNow()
  #13 0x0000009d884b content::BrowserMainLoop::CreateStartupTasks()
  #14 0x0000009dd7cc content::BrowserMainRunnerImpl::Initialize()
  #15 0x0000009d6038 content::BrowserMain()
  #16 0x000001c6dcec content::ContentMainRunnerImpl::Run()
  #17 0x000001c6c8d0 content::ContentMain()
  #18 0x00000539425a content::BrowserTestBase::SetUp()
  #19 0x000001ccb89e InProcessBrowserTest::SetUp()
  #20 0x000001cc06d8 SyncTest::SetUp()
  #21 0x000001d4e70e testing::Test::Run()
  #22 0x000001d4eff0 testing::TestInfo::Run()
  #23 0x000001d4f367 testing::TestCase::Run()
  #24 0x000001d563c7 testing::internal::UnitTestImpl::RunAllTests()
  #25 0x000001d56047 testing::UnitTest::Run()
  #26 0x000001df96d1 base::TestSuite::Run()
  #27 0x000001ccae4b ChromeTestSuiteRunner::RunTestSuite()
  #28 0x000005395b87 content::LaunchTests()
  #29 0x000001c9a0a1 main
  #30 0x7fadf3805f45 __libc_start_main
  #31 0x00000043a161 <unknown>
    
1: https://chromium.googlesource.com/chromium/src/+/5be8b586be828f6c54d153f74a5af39c96645377
2: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/44114
 

Comment 1 by skau@chromium.org, Mar 15 2017

Components: Internals>Printing>CUPS
Labels: OS-Chrome
Sorry about that.  Looks like I need to enforce a wait in SetupClient.  How urgent is this fix needed?
No need to drop everything, but it seems to flake maybe 1/10 runs recently [1].

1: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29?numbuilds=200
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b7d4734ef302c8b0a48da344663076956c54fa2

commit 0b7d4734ef302c8b0a48da344663076956c54fa2
Author: guidou <guidou@chromium.org>
Date: Thu Mar 16 14:28:08 2017

Disable flaky SingleClientPrintersSyncTest.EditPrinter on ChromeOS.

BUG= 701999 
TBR=skau@chromium.org

Review-Url: https://codereview.chromium.org/2755923002
Cr-Commit-Position: refs/heads/master@{#457430}

[modify] https://crrev.com/0b7d4734ef302c8b0a48da344663076956c54fa2/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc

Comment 4 by skau@chromium.org, Mar 16 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9985aa81ecc5c3fc065c6707ef5b67b141a6394c

commit 9985aa81ecc5c3fc065c6707ef5b67b141a6394c
Author: skau <skau@chromium.org>
Date: Mon Mar 20 20:09:52 2017

Flakiness in SingleClientPrintersSyncTest.EditPrinter.

The test needs to wait for sync to begin initializing before running.  This is the behavior of Chrome normally.

BUG= 701999 
TEST=Ran the SingleClientPrintersSyncTest on my workstation 100 times.  0 failures.

Review-Url: https://codereview.chromium.org/2758643002
Cr-Commit-Position: refs/heads/master@{#458158}

[modify] https://crrev.com/9985aa81ecc5c3fc065c6707ef5b67b141a6394c/chrome/browser/chromeos/printing/printers_sync_bridge.cc
[modify] https://crrev.com/9985aa81ecc5c3fc065c6707ef5b67b141a6394c/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc

Comment 6 by skau@chromium.org, Mar 20 2017

Status: Fixed (was: Started)

Comment 7 by thakis@chromium.org, Mar 23 2017

Status: Assigned (was: Fixed)
This test is still flaky and ruined my try job here: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/346545

If it takes a while to fix, please redisable the test in the meantime.

Comment 8 by thakis@chromium.org, Mar 23 2017

Looks like 10 of the last 200 tryjobs failed because of that: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng?numbuilds=200 (look for "sync_integration_tests")

Comment 9 by skau@chromium.org, Mar 23 2017

Sorry.  I thought I fixed it.  I'll disable it again.

Comment 10 by kolos@chromium.org, Mar 27 2017

 Issue 704995  has been merged into this issue.

Comment 11 by st...@chromium.org, Mar 28 2017

Labels: AnalyzedByFindit
Labels: -AnalyzedByFindit Test-Findit-Analyzed

Comment 13 by skau@chromium.org, Apr 6 2017

Cc: skau@chromium.org
Owner: gangwu@chromium.org
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/864d4cde3b40817cf6831a4a2e6711a4f94413b9

commit 864d4cde3b40817cf6831a4a2e6711a4f94413b9
Author: gangwu <gangwu@chromium.org>
Date: Fri Apr 07 00:47:21 2017

Enable printers sync_integration_tests on chromeos

Fix printer flaky bugs by adding another wait.
The bug is flaky because tests only wait for UI tasks to be completed,
but since PrintersManagerFactory uses
content::BrowserThread::GetBlockingPool() to schedule ModelTypeStore
initialization, and then reply result to UI thread, so we need to wait
on content::BrowserThread::GetBlockingPool() as well.

Remove unnecessary changes from
https://codereview.chromium.org/2758643002 since that did not really
fix this waiting issue.

BUG= 689662 ,  701999 

Review-Url: https://codereview.chromium.org/2799103002
Cr-Commit-Position: refs/heads/master@{#462716}

[modify] https://crrev.com/864d4cde3b40817cf6831a4a2e6711a4f94413b9/chrome/browser/sync/test/integration/printers_helper.cc
[modify] https://crrev.com/864d4cde3b40817cf6831a4a2e6711a4f94413b9/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc
[modify] https://crrev.com/864d4cde3b40817cf6831a4a2e6711a4f94413b9/chrome/browser/sync/test/integration/two_client_printers_sync_test.cc

Status: Fixed (was: Assigned)

Comment 16 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 18 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment