New issue
Advanced search Search tips

Issue 701997 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Upgrade libvorbis to 1.3.5

Project Member Reported by manojgupta@chromium.org, Mar 15 2017

Issue description

The latest libvorbis 1.3.5 builds fine with clang.
So it should be upgraded from version 1.3.3 which did not compile with clang ( https://crbug.com/534997 ).
 
Owner: manojgupta@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/3744a3ab69b9627cd65463037b2efcc55c12b6cf

commit 3744a3ab69b9627cd65463037b2efcc55c12b6cf
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Mar 16 18:25:48 2017

Upgrade libvorbis to 1.3.5.

libvorbis 1.3.5 can be built with clang.

BUG= chromium:701997 
TEST=cbuildbot {arm,amd64}-generic-full works
TEST=cbuildbot {caroline, daisy, elm, kevin, veyron_jaq}-release works

Change-Id: I9854c2dac3e3b76c2354d16c422a140296001c08
Reviewed-on: https://chromium-review.googlesource.com/455345
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/3744a3ab69b9627cd65463037b2efcc55c12b6cf/media-libs/libvorbis/libvorbis-1.3.5.ebuild
[modify] https://crrev.com/3744a3ab69b9627cd65463037b2efcc55c12b6cf/media-libs/libvorbis/Manifest
[delete] https://crrev.com/7780296aecf259eca246863d8badcb58e80fc9b4/media-libs/libvorbis/libvorbis-1.3.3.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2a6d1fd7f933513beb1e2e991c8b85973f8a4e67

commit 2a6d1fd7f933513beb1e2e991c8b85973f8a4e67
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Mar 16 18:25:49 2017

Remove libvorbis forced building by gcc.

Version 1.3.5 of libvorbis can be built by clang.
So remove forcing build by gcc.

CQ-DEPEND=CL:455345

BUG= chromium:701997 
TEST=cbuildbot {arm,amd64}-generic-full works
TEST=cbuildbot {caroline, daisy, elm, kevin, veyron_jaq}-release works

Change-Id: Ife11346e7e738c3a78d75b82a9744524af6e6b23
Reviewed-on: https://chromium-review.googlesource.com/455983
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/865bc1b534f235b139d279028f21bdcd119c78a3/chromeos/config/env/media-libs/libvorbis

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment