New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701993 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

iOS implementation of NetExport does not set useMobileUI=true

Project Member Reported by eroman@chromium.org, Mar 15 2017

Issue description

The Javascript code is only testing !useMobileUI to test for desktop-mode, so this shouldn't be causing problems.

However it will become a bug if code is added to net_export.js that relies on useMobileUI ==true for mobile-mode UI.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a3acd978daee61b3ea99b4cd705d4401203ee3

commit 62a3acd978daee61b3ea99b4cd705d4401203ee3
Author: eroman <eroman@chromium.org>
Date: Thu Mar 16 23:52:51 2017

Cosmetic changes to chrome://net-export, primarily for desktop mode.

 * On the desktop UI, remove reference to emailing from the instructions
   (as that is only available from the mobile version).

 * While logging is in progress, change the disabled button's text from:
     "Start Logging to Disk"  to "Logging to Disk..."
   This gives a bit more feedback that something is happening (even
   better would be to show the path to log file and its size)

 * Add a <title> for the page of "Network Log Export"

BUG= 701033 , 701993 

Review-Url: https://codereview.chromium.org/2757473002
Cr-Commit-Position: refs/heads/master@{#457612}

[modify] https://crrev.com/62a3acd978daee61b3ea99b4cd705d4401203ee3/chrome/browser/ui/webui/net_export_ui.cc
[modify] https://crrev.com/62a3acd978daee61b3ea99b4cd705d4401203ee3/components/net_log/resources/net_export.css
[modify] https://crrev.com/62a3acd978daee61b3ea99b4cd705d4401203ee3/components/net_log/resources/net_export.html
[modify] https://crrev.com/62a3acd978daee61b3ea99b4cd705d4401203ee3/components/net_log/resources/net_export.js

Comment 2 by eroman@chromium.org, Mar 17 2017

Status: Fixed (was: Assigned)

Sign in to add a comment