New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701992 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 649651



Sign in to add a comment

Stop supporting the re-connection mechanism for the devices not support pairing.

Project Member Reported by mcchou@chromium.org, Mar 15 2017

Issue description

This patch stops the support to the following devices which do not support Bluetooth pairing.

- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3
 

Comment 1 by mcchou@chromium.org, Mar 15 2017

Summary: Stop supporting the re-connection mechanism for the devices not support pairing. (was: Stop supporting devices which do not support pairing.)
To be more accurate, stop supporting the re-connection mechanism to the device mentioned in the issue summary.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/206866029e5e2fddc1cff642fbfc5318007a6574

commit 206866029e5e2fddc1cff642fbfc5318007a6574
Author: mcchou <mcchou@google.com>
Date: Thu Mar 16 02:35:46 2017

bluetooth: Stop support of reconnecting devices not supporting pairing

This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3

BUG= 701992 
TBR=ortuno@chromium.org

Review-Url: https://codereview.chromium.org/2751223002
Cr-Commit-Position: refs/heads/master@{#457325}

[modify] https://crrev.com/206866029e5e2fddc1cff642fbfc5318007a6574/device/bluetooth/bluetooth_adapter.h
[modify] https://crrev.com/206866029e5e2fddc1cff642fbfc5318007a6574/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/206866029e5e2fddc1cff642fbfc5318007a6574/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/206866029e5e2fddc1cff642fbfc5318007a6574/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
[modify] https://crrev.com/206866029e5e2fddc1cff642fbfc5318007a6574/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
[modify] https://crrev.com/206866029e5e2fddc1cff642fbfc5318007a6574/device/bluetooth/bluez/bluetooth_device_bluez.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7ce88cf850d704d57e51be67f3f9daabb7490ca

commit b7ce88cf850d704d57e51be67f3f9daabb7490ca
Author: Miao-chen Chou <mcchou@chromium.org>
Date: Thu Mar 16 03:14:02 2017

bluetooth: Stop support of reconnecting devices not supporting pairing

This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3

BUG= 701992 
TBR=ortuno@chromium.org

Review-Url: https://codereview.chromium.org/2751223002
Cr-Commit-Position: refs/heads/master@{#457325}
(cherry picked from commit 206866029e5e2fddc1cff642fbfc5318007a6574)

Review-Url: https://codereview.chromium.org/2751303002 .
Cr-Commit-Position: refs/branch-heads/2987@{#835}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/b7ce88cf850d704d57e51be67f3f9daabb7490ca/device/bluetooth/bluetooth_adapter.h
[modify] https://crrev.com/b7ce88cf850d704d57e51be67f3f9daabb7490ca/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/b7ce88cf850d704d57e51be67f3f9daabb7490ca/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/b7ce88cf850d704d57e51be67f3f9daabb7490ca/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
[modify] https://crrev.com/b7ce88cf850d704d57e51be67f3f9daabb7490ca/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
[modify] https://crrev.com/b7ce88cf850d704d57e51be67f3f9daabb7490ca/device/bluetooth/bluez/bluetooth_device_bluez.cc

Comment 4 by mcchou@chromium.org, Mar 16 2017

Labels: Merge-Request-57
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 16 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by mcchou@chromium.org, Mar 16 2017

Labels: Merge-Review-58

Comment 7 by mcchou@chromium.org, Mar 16 2017

Cc: ortuno@chromium.org hansberry@chromium.org
Status: Fixed (was: Started)

Comment 8 by mcchou@chromium.org, Mar 16 2017

Blocking: 649651

Comment 9 by ketakid@google.com, Mar 16 2017

Labels: Merge-Approved-57

Comment 10 by ketakid@google.com, Mar 16 2017

Labels: Merge-Approved-58
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 16 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b384e2ec2251427c0c0601898b647b3678f91a5

commit 9b384e2ec2251427c0c0601898b647b3678f91a5
Author: Miao-chen Chou <mcchou@chromium.org>
Date: Thu Mar 16 06:03:18 2017

bluetooth: Stop support of reconnecting devices not supporting pairing

This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3

BUG= 701992 
TBR=ortuno@chromium.org

Review-Url: https://codereview.chromium.org/2751223002
Cr-Commit-Position: refs/heads/master@{#457325}
(cherry picked from commit 206866029e5e2fddc1cff642fbfc5318007a6574)

Review-Url: https://codereview.chromium.org/2752593005 .
Cr-Commit-Position: refs/branch-heads/3029@{#226}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/9b384e2ec2251427c0c0601898b647b3678f91a5/device/bluetooth/bluetooth_adapter.h
[modify] https://crrev.com/9b384e2ec2251427c0c0601898b647b3678f91a5/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/9b384e2ec2251427c0c0601898b647b3678f91a5/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/9b384e2ec2251427c0c0601898b647b3678f91a5/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
[modify] https://crrev.com/9b384e2ec2251427c0c0601898b647b3678f91a5/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
[modify] https://crrev.com/9b384e2ec2251427c0c0601898b647b3678f91a5/device/bluetooth/bluez/bluetooth_device_bluez.cc

Labels: -M-56

Comment 13 by ketakid@google.com, Mar 16 2017

Labels: Merge-Approved-58
Please add applicable OSs.  Thanks.
Labels: OS-Chrome
Looks like CrOS

Comment 16 by ketakid@google.com, Mar 17 2017

Labels: -Merge-Review-57
Project Member

Comment 17 by sheriffbot@chromium.org, Mar 20 2017

Cc: ketakid@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Fixed)
As i check on 58.0.3029.19 build on elm ,the Sony PlayStation Dualshock3 connects to Chromebook , but on 58.0.3029.31 build the Sony PlayStation Dualshock3 doesn't connect to the Chromebook.

Attached logs from the machine
ui (1).LATEST
14.9 KB Download
hcidump (2).log
123 KB View Download
not connecting is the expected behaviour, except unless user initiated right at the moment of connection
#19 , The Sony PlayStation Dualshock3 doesn't even connect the 1st time when the user tries to connect to it.
Project Member

Comment 21 by sheriffbot@chromium.org, Mar 24 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I checked with the Verbatim BT mouse on 59.0.3051.3 build , the BT mouse fails to connect to the Chromebook. PFA the logs for the same
Screenshot 2017-03-28 at 11.38.40 AM.png
226 KB View Download
ui.LATEST
2.7 KB Download
hcidump.log
10.0 KB View Download
Labels: -Hotlist-Merge-Review -Merge-Review-58
Project Member

Comment 24 by sheriffbot@chromium.org, May 19 2017

Labels: -Merge-Approved-58 -Merge-Approved-57
This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: pbath...@chromium.org rjahagir@chromium.org mcchou@chromium.org
Issue 733148 has been merged into this issue.
@rjahagir@chromium.org
You're sure it's duplicate of 701992? - Which mention DualShock 3 (Default Controller of Playstation 3) which got a different pairing mechanism, because you need to initialise BT connections with a pairing via USB first for knowing the MAC-Adress. Maybe someone can confirm if this is still true with current *NIX Systems?
DualShock 4 has added a "simple pairing with non Sony Devices" Mode which makes it more similar to a 'normal' BT Controller.
Status: Fixed (was: Assigned)

Sign in to add a comment