New issue
Advanced search Search tips

Issue 701979 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Apps show default icon after icon file corruption.

Project Member Reported by lgcheng@google.com, Mar 15 2017

Issue description

Internal link http://b/35947207
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f24408d3df3bf74f497111dd551d26a7509a07f4

commit f24408d3df3bf74f497111dd551d26a7509a07f4
Author: lgcheng <lgcheng@google.com>
Date: Thu Mar 16 01:09:43 2017

Fix Default icon issue when cached icon file is corrupted.

Some crahes lead to app cached icon file corruption. Re send icon
request to ARC if bad icon is observed. Limit icon request to once per
app per scale per user session.

Bug= 701979 
Test=Unit test added.
Test=Manual test. Manual corrupted cached icon. See icon restored.

Review-Url: https://codereview.chromium.org/2749973002
Cr-Commit-Position: refs/heads/master@{#457294}

[modify] https://crrev.com/f24408d3df3bf74f497111dd551d26a7509a07f4/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/f24408d3df3bf74f497111dd551d26a7509a07f4/chrome/browser/ui/app_list/arc/arc_app_icon.h
[modify] https://crrev.com/f24408d3df3bf74f497111dd551d26a7509a07f4/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/f24408d3df3bf74f497111dd551d26a7509a07f4/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/f24408d3df3bf74f497111dd551d26a7509a07f4/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/f24408d3df3bf74f497111dd551d26a7509a07f4/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/f24408d3df3bf74f497111dd551d26a7509a07f4/components/arc/test/fake_app_instance.h

Comment 2 by lgcheng@google.com, Mar 16 2017

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 17 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 20 2017

Cc: ketakid@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by cda...@chromium.org, Mar 20 2017

Cc: -ketakid@google.com
Clearing randomly added cc list by sheriffbot. sorry for the spam. thanks.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 20 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61676170d0826acfb754e8f434ef79fe909e271a

commit 61676170d0826acfb754e8f434ef79fe909e271a
Author: Long Cheng <lgcheng@google.com>
Date: Mon Mar 20 23:30:28 2017

[Merge To M58]Fix Default icon issue when cached icon file is corrupted.

Some crahes lead to app cached icon file corruption. Re send icon
request to ARC if bad icon is observed. Limit icon request to once per
app per scale per user session.

Bug= 701979 
Test=Unit test added.
Test=Manual test. Manual corrupted cached icon. See icon restored.

TBR=lhchavez@chromium.org, xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2749973002
Cr-Commit-Position: refs/heads/master@{#457294}
(cherry picked from commit f24408d3df3bf74f497111dd551d26a7509a07f4)

Review-Url: https://codereview.chromium.org/2763753003 .
Cr-Commit-Position: refs/branch-heads/3029@{#316}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/61676170d0826acfb754e8f434ef79fe909e271a/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/61676170d0826acfb754e8f434ef79fe909e271a/chrome/browser/ui/app_list/arc/arc_app_icon.h
[modify] https://crrev.com/61676170d0826acfb754e8f434ef79fe909e271a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/61676170d0826acfb754e8f434ef79fe909e271a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/61676170d0826acfb754e8f434ef79fe909e271a/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/61676170d0826acfb754e8f434ef79fe909e271a/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/61676170d0826acfb754e8f434ef79fe909e271a/components/arc/test/fake_app_instance.h

Comment 7 by lgcheng@google.com, May 23 2017

Status: Fixed (was: Untriaged)

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment