Marking P0 since this probably blocks M57 on those devices and it's pushing very soon.

I believe that this has been there at least as of 57.0.2987.85.
I believe that R56 has no problems.

OK, dschuff@ did a big bisect.  Here's the summary (ordered by version number)

9100.0: passes (white screen first try, but tried again and no problems)
9150.0: connects, but weird graphics (video codec?)
9176.0: connects, but weird graphics (video codec?)
9197.0: connects, but weird graphics (video codec?)
9201.0: connects, but weird graphics (video codec?)
9202.0: connects, but weird graphics (video codec?)
9202.1: fails
9202.2: fails
9202.7: fails
9202.43: fails
9202.51: fails

Chrome OS diffs:

  https://crosland.corp.google.com/log/9202.0.0..9202.1.0

Chrome diffs:

  https://chromium.googlesource.com/chromium/src/+log/57.0.2984.0..57.0.2987.6?pretty=fuller&n=10000

Interestingly, R58 passes, so I guess something fixed it.

+Bhthompson, M-58.Looks like we don't need this on R58....

Pawel / Tomasz: any chance you guys have some cycles here to look?  Seems plausible it could be related to video codec ?

---

Note that we believe that M-58 is OK here, so presumably whatever the problem was got fixed, people just forgot to backport?  Can double-confirm that M-58 is OK and probably do a bisect there, too...

I had a few extra minutes so I bisected the graphics artifacts, just in case that's related (maybe a long shot, but just in case e.g. there was some corruption that later became the crash):
9125.0 works, no graphics artifacts
9131.0 works
9132.0 works
9133.0 has graphics artifacts
9134.0 has graphics artifacts
9137.0 has graphics artifacts
9150.0 has graphics artifacts

dianders@ this P0 has no owner. Who could look at this next? posciak@/tfiga@ can either of you take a look?

How do I test Chromoting? Generally I'd like to avoid logging with my corp credentials on a test device or accessing my corp machines from it. Is there some Chromoting server I could connect to?

Okay, looks like I can click "Share" on one of my Chromebooks and then "Access" on Kevin and use that for testing.

Looking from different perspective, though, it seems like builds <= 9132.0 used software decoder for VP8 due to a bug in udev rules. We fixed that in 9133.0, so after that VP8 is being decoded by hardware decoder.

Hmm, I can't see any artifacts when sharing from Cyan R58-9282.0 to Kevin R57-9202.0. Verified at the same time that hardware decoder is used on Kevin.

dschuff@, could you describe your testing method you used for getting results listed in comments #5 and #9?

Okay, I managed to reproduce the corruption with Samus as the sender and the problem was that RK3399 VP8 decoder does not support resolutions higher than 1920x1088, while Samus was streaming with 2560x1712 (native resolution rounded up to macroblock size). I confirmed that this problem is already fixed in R57 branch kernel by https://chromium-review.googlesource.com/c/435867 which landed in 9202.13.0.

I'd risk a statement that the problem that showed up in 9202.1 is completely unrelated and I'm reasonably convinced that it's something in Chrome. Will try to confirm this and re-assign to someone that knows that area better, if I find my guess to be true.

After testing with R57-9202.51 I'm pretty much convinced that the problem lies outside of video area. It looks like it might be actually a problem with graphics in Chrome, as there are some GL errors coming from PPAPI context. See the two captures logs below.

Connecting from Kevin to Samus: (note that the v42l_slice_video_decode_accelerator errors are expected, as the decoder does not support requested resolution)

[1,4036591616:08:24:03.534529] Native Client module will be loaded at base address 0x0000000000000000
[0316/082403.753690:INFO:chromoting_instance.cc(612)] Connecting to asanokitesting@gmail.com/chromotingF5974DCF. Local jid: tfiga.test3@gmail.com/chromoting0CF381C3.
[0316/082409.671300:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082409.672410:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082409.673410:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082409.674310:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082409.686370:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082409.686740:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082409.687040:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082409.687510:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082409.702590:WARNING:stunport.cc(385)] Jingle:Port[0x3e5d8528::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.703400:WARNING:stunport.cc(385)] Jingle:Port[0x3e5c6cd8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.704490:WARNING:stunport.cc(385)] Jingle:Port[0x3eebfaa8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.705380:WARNING:stunport.cc(385)] Jingle:Port[0x3e5c0010::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.706420:WARNING:stunport.cc(385)] Jingle:Port[0x3e5d8528::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.707920:WARNING:stunport.cc(385)] Jingle:Port[0x3e5c6cd8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.710050:WARNING:stunport.cc(385)] Jingle:Port[0x3eebfaa8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.711200:WARNING:stunport.cc(385)] Jingle:Port[0x3e5c0010::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.713110:WARNING:stunport.cc(385)] Jingle:Port[0x3e5d8528::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.714280:WARNING:stunport.cc(385)] Jingle:Port[0x3e5c6cd8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.715870:WARNING:stunport.cc(385)] Jingle:Port[0x3eebfaa8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.717000:WARNING:stunport.cc(385)] Jingle:Port[0x3e5c0010::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.718330:WARNING:stunport.cc(385)] Jingle:Port[0x3e5d8528::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.719440:WARNING:stunport.cc(385)] Jingle:Port[0x3e5c6cd8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.720960:WARNING:stunport.cc(385)] Jingle:Port[0x3eebfaa8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.722490:WARNING:stunport.cc(385)] Jingle:Port[0x3e5c0010::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.722930:WARNING:stunport.cc(385)] Jingle:Port[0x3e5d8528::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.723120:WARNING:stunport.cc(385)] Jingle:Port[0x3e5c6cd8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.723380:WARNING:stunport.cc(385)] Jingle:Port[0x3eebfaa8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082409.723540:WARNING:stunport.cc(385)] Jingle:Port[0x3e5c0010::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082410.960900:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082410.963800:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082410.969710:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082410.971120:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082411.894350:INFO:chromoting_client.cc(216)] Using relay connection for mux channel
[0316/082411.907010:INFO:chromoting_client.cc(216)] Using relay connection for video channel
[0316/082414.161220:WARNING:relayport.cc(473)] No more relay addresses left to try
[0316/082414.162040:WARNING:relayport.cc(473)] No more relay addresses left to try
[0316/082414.163150:WARNING:relayport.cc(473)] No more relay addresses left to try
[0316/082414.167190:WARNING:relayport.cc(473)] No more relay addresses left to try
[0316/082414.168950:WARNING:relayport.cc(473)] No more relay addresses left to try
[0316/082414.172090:WARNING:relayport.cc(473)] No more relay addresses left to try
[0316/082419.233640:ERROR:stunport.cc(89)] Binding request timed out from 192.168.254.x:46120 (eth0)
[0316/082419.234710:ERROR:stunport.cc(89)] Binding request timed out from 192.168.254.x:46120 (eth0)
[0316/082419.252970:ERROR:stunport.cc(89)] Binding request timed out from 192.168.254.x:46120 (eth0)
[0316/082419.254440:ERROR:stunport.cc(89)] Binding request timed out from 192.168.254.x:46120 (eth0)
[0316/082419.255440:ERROR:stunport.cc(89)] Binding request timed out from 192.168.254.x:46120 (eth0)
[0316/082419.258100:ERROR:stunport.cc(89)] Binding request timed out from 192.168.254.x:57857 (eth0)
[0316/082419.258600:ERROR:stunport.cc(89)] Binding request timed out from 192.168.254.x:57857 (eth0)
[0316/082419.259060:ERROR:stunport.cc(89)] Binding request timed out from 192.168.254.x:57857 (eth0)
[0316/082419.259450:ERROR:stunport.cc(89)] Binding request timed out from 192.168.254.x:57857 (eth0)
[0316/082419.260790:ERROR:stunport.cc(89)] Binding request timed out from 192.168.254.x:57857 (eth0)
[2036:4623:0316/172420.233311:ERROR:v4l2_slice_video_decode_accelerator.cc(829)] CreateOutputBuffers(): Got invalid adjusted coded size: 1920x1088
[2036:4623:0316/172420.233311:ERROR:v4l2_slice_video_decode_accelerator.cc(829)] CreateOutputBuffers(): Got invalid adjusted coded size: 1920x1088
[2036:4623:0316/172420.234249:ERROR:v4l2_slice_video_decode_accelerator.cc(1494)] FinishSurfaceSetChange(): Setting error state:4
[2036:4623:0316/172420.234249:ERROR:v4l2_slice_video_decode_accelerator.cc(1494)] FinishSurfaceSetChange(): Setting error state:4
[2036:2036:0316/172420.480680:ERROR:gles2_cmd_decoder.cc(2459)] [.PPAPIContext]GL ERROR :GL_INVALID_ENUM : ScopedTextureBinder::dtor: <- error from previous GL command
[2036:2036:0316/172420.480680:ERROR:gles2_cmd_decoder.cc(2459)] [.PPAPIContext]GL ERROR :GL_INVALID_ENUM : ScopedTextureBinder::dtor: <- error from previous GL command

** Signal 4 from untrusted code: pc=106a9c
[1690:2021:0316/172420.535627:ERROR:nacl_process_host.cc(261)] NaCl process exited with status 64512 (0xfc00)

Connecting from Kevin to Cyan: (note no v4l2_slice_video_decode_accelerator errors)

[1,4036591616:08:26:41.819972] Native Client module will be loaded at base address 0x0000000000000000
[0316/082641.999950:INFO:chromoting_instance.cc(612)] Connecting to tfiga.test3@gmail.com/chromotingEF037D88. Local jid: tfiga.test3@gmail.com/chromoting4035DA0C.
[0316/082646.221310:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082646.221640:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082646.222240:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b89d8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.222880:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b89d8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.223620:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b89d8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.224120:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b89d8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.224570:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b89d8::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.224920:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082646.225180:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082646.225550:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b8480::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.226020:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b8480::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.226460:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b8480::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.226950:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b8480::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.227420:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b8480::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.242820:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082646.243670:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082646.249090:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b0268::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.249320:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b0268::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.249850:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b0268::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.250550:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b0268::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.251500:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b0268::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.252590:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082646.252930:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082646.254950:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b0990::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.256480:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b0990::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.257000:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b0990::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.257430:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b0990::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082646.257850:WARNING:stunport.cc(385)] Jingle:Port[0x3e5b0990::0:0:stun:Net[eth0:fe80:0:0:x:x:x:x:x/0:Unknown]]: StunPort: stun host lookup received error 0
[0316/082647.270510:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082647.273230:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082647.275820:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::a4c0:feff:fe7e:3cd3]:0, error: -108
[0316/082647.279630:ERROR:pepper_packet_socket_factory.cc(243)] Failed to bind UDP socket to [fe80::669:f8ff:feec:efbe]:0, error: -108
[0316/082647.363780:INFO:chromoting_client.cc(216)] Using direct connection for mux channel
[0316/082647.368960:INFO:chromoting_client.cc(216)] Using direct connection for video channel
[0316/082647.511330:WARNING:basicportallocator.cc(730)] Discarding candidate because port is already done gathering.
[0316/082647.515940:WARNING:basicportallocator.cc(730)] Discarding candidate because port is already done gathering.
[0316/082647.618870:WARNING:pepper_video_renderer_3d.cc(368)] PPB_VideoDecoder doesn't set visible_rect.
[2036:2036:0316/172647.723199:ERROR:gles2_cmd_decoder.cc(2459)] [.PPAPIContext]GL ERROR :GL_INVALID_ENUM : ScopedTextureBinder::dtor: <- error from previous GL command
[2036:2036:0316/172647.723199:ERROR:gles2_cmd_decoder.cc(2459)] [.PPAPIContext]GL ERROR :GL_INVALID_ENUM : ScopedTextureBinder::dtor: <- error from previous GL command

** Signal 4 from untrusted code: pc=106a9c
[1690:2021:0316/172647.753136:ERROR:nacl_process_host.cc(261)] NaCl process exited with status 64512 (0xfc00)

I'm going to do the M58 bisect to see if I can figure out where it got fixed.  Maybe that will help us...

Thanks tfiga@/dianders@ - +marcheu@ and ihf@.

OK, so it appears that we're actually "Fixed", amazingly enough.  I did the bisect on what Fixed this on R58 and found:

9274 - bad
9310 - bad
9328 - bad
9334.5 - bad
9334.8.0 - bad
9334.9.0 - bad
9334.11.0 - good!

Digging into the differences between 9334.9.0 and 9334.11.0 <https://crosland.corp.google.com/log/9334.9.0..9334.11.0>, I found

	554ec0df	455396	699802	Mon Mar 13 18:22:44 2017	reveman@chromium.org	Revert "login: Enable GLImage output for Pepper3D on kevin."

AKA: <https://chromium.googlesource.com/chromiumos/platform2/+/554ec0df8efd584711629edcc4fae1e3ac35e2dd>

---

I then found that the revert has been posted to R57 too, so I tried last night's R57 build (9202.53.0) and it worked (!).

---

I remember looking at that original change and somehow our bisect of R57 didn't blame it.  We must have made some dumb mistake in our bisect.  I'll try to double-confirm.

---

In any case, marking this as Fixed.

[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.

Oddly, I would have expected that our first failing build on R57 should have been:

- 9199.0.0

Yes, this looked like it would have come from Chrome and I was going to add reveman, but lots of update collisions later...

9199.0.0 - just a green screen, but I can control the mouse.  Probably the same as "connects, but weird graphics (video codec?)"

---

That would make me believe that the "broken" commit was combined with a change in Chrome that actually did land in "9202.1".  Let's see...

Ah, from the other bug, I see that a related change is <https://codereview.chromium.org/2632903002> AKA "gpu: Pepper3DImageChromium support on ChromeOS.".  ...and that _did_ show up first in the Chrome from 9202.1.

...so whew, our bisect was right.

Issue 698053 has been merged into this issue.