New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701965 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression

Blocked on:
issue 618460



Sign in to add a comment

Canary 59.0.3042.0 - The mouse scroll foward or backward give a negative value when the cursor is locked

Reported by r2r...@hotmail.com, Mar 15 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
1 : go on the WebGL test link : http://www.asr-games.net/WebGLProblem/
2 : See the instruction for the  bug 2 
3 : Press TAB to lock the cursor and use your mouse scroll and see the Scroll Val below.
- Also a video : https://www.youtube.com/watch?v=1f700hhwWTU

What is the expected behavior?
The mouse scroll should give positive and negative value when the cursor is locked.

What went wrong?
In google Canary 59.0.3042.0 ,if you use the mouse scroll foward or backward when the cursor is locked, you only get negative value. Work well when the cursor is not locked.

Did this work before? Yes Work on the current google chrome version

Does this work in other browsers? Yes

Chrome version: 56.0.2924.87  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 
Labels: Needs-Bisect
Components: IO>PointerLock
I don't think this has anything to do with WebGL. Adding component IO>PointerLock.
Labels: -OS-Windows OS-All
Reproducible on Linux. One time I saw it only go positive, one time I saw it only go negative.

The range that needs bisecting is: -g 57.0.2987.98 -b 58.0.3029.19

Comment 4 by r2r...@hotmail.com, Mar 15 2017

It happen on a WebGL game , it work perfecly on the current Google Chrome version and on Firefox
Status: Untriaged (was: Unconfirmed)
I agree that there is a bug.

"WebGL" only refers to the 3D rendering - we (the WebGL team) don't work on Pointer Lock, so I'll let them handle it.

Comment 6 by r2r...@hotmail.com, Mar 15 2017

Ho ok thank you for the info.
Cc: jmukthavaram@chromium.org
Labels: -Pri-2 -OS-All -Needs-Bisect hasbisect-per-revision M-59 OS-Linux OS-Mac OS-Windows Pri-1
Owner: lfg@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce this issue on windows 7, Mac 10.12.3,Linux Ubuntu 14.04 with Chrome stable version-57.0.2987.98 and Canary-59.0.3042.4
Manual Bisect:
Good Build—58.0.3014.0 -Revision-450840
Bad Build—58.0.3015.0 -Revision-451180

Per revision Bisect Tool Info:
------------------------------
You are probably looking for a change made after 451030 (known good), but no later than 451031 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/306a6a5a991467ce0cc34b56e05af420ecd90919..84763c90521d17f4b30d3abaa8af472b579a63ff

Review-Url: https://codereview.chromium.org/2592243002

lfg@Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.
Thanks.!

Comment 8 by kbr@chromium.org, Mar 16 2017

Blockedon: 618460

Comment 9 by lfg@chromium.org, Mar 21 2017

Status: Started (was: Assigned)

Comment 11 by lfg@chromium.org, Mar 24 2017

Status: Fixed (was: Started)
Fixed. Verified in 59.0.3050.0.

Comment 12 by r2r...@hotmail.com, Apr 22 2017

Fixed in the canary version but not on the new chrome release 58.0.3029.81.
Chrome was the first to remove the unity web player plugin and now, 2 year after that, we still can't have something "stable" for our webgl game....
Labels: M-58 Needs-TestConfirmation
I see this landed after the 59 branch, but I don't see that it was merged from TOT==60 at that time to 59. I'd like to know which versions this regression affects from 58 to 60.

Comment 14 by lfg@chromium.org, Apr 24 2017

Labels: -Needs-TestConfirmation
No need to test -- I've fixed this in M59, but didn't request a merge to M58 as this isn't marked as release blocker, and I didn't consider it important enough to merge.

Comment 15 by r2r...@hotmail.com, Apr 25 2017

Not important? All FPS game using webgl are broken because of this issue.
Mostly all players use the mouse scroll to switch weapon and they can only do it in one direction because of this. And i'm sure that a lot of game using the mouse scroll for the game play are broken also now. Anyway, if a patch can be done, it will be usefull for us instead of losing players because they think that the game is badly coded.... thank you

Comment 16 by lfg@chromium.org, Apr 25 2017

Cc: gov...@chromium.org
Labels: -M-59 Merge-Request-58
govind@, are we releasing another M58? If so, I'd like to merge this fix It has baked for a month on canary/dev and should be low risk.

Project Member

Comment 17 by sheriffbot@chromium.org, Apr 25 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 18 by kbr@chromium.org, Apr 26 2017

I'd advocate for merging this back to M58. The fix seems tiny and it's a pretty bad regression for any web sites using pointer lock.

Labels: OS-Chrome
per lfg@ this bug is applicable to Desktop and Chrome OS.
Cc: bhthompson@chromium.org
+ bhthompson@ as this bug is also applicable to Chrome OS.
Labels: -Merge-Review-58 Merge-Approved-58
Approving merge to M58 branch 3029 based on internal group chat and comment #16 & #18. 
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 28 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c3e5bb200dfdf8c275de7b6d4a6dfc80cdb1ec3

commit 4c3e5bb200dfdf8c275de7b6d4a6dfc80cdb1ec3
Author: lfg <lfg@chromium.org>
Date: Fri Apr 28 19:56:45 2017

Fix routing of mouse wheel events while pointer is locked.

BUG= 701965 

Review-Url: https://codereview.chromium.org/2765903002
Cr-Commit-Position: refs/heads/master@{#459220}
(cherry picked from commit 9a467e187757c5bdfd35488ebab382c7d59ee50b)

TBR=kenrb@chromium.org,nick@chromium.org,scheib@chromium.org,kbr@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2846323002
Cr-Commit-Position: refs/branch-heads/3029@{#783}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/4c3e5bb200dfdf8c275de7b6d4a6dfc80cdb1ec3/content/browser/pointer_lock_browsertest.cc
[modify] https://crrev.com/4c3e5bb200dfdf8c275de7b6d4a6dfc80cdb1ec3/content/browser/renderer_host/render_widget_host_input_event_router.cc

Cc: ligim...@chromium.org
 Issue 716443  has been merged into this issue.
Cc: hdodda@chromium.org
Labels: TE-Verified-M58 TE-Verified-58.0.3029.96
Verified the issue on Mac os 10.12.3, Windows 7 and ubuntu 14.04 using chrome M58 #58.0.3029.96 and followed the steps below:

!. Launched chrome and navigated to "http://www.asr-games.net/WebGLProblem/".
2. Pressed tab and locked the cursor and used  mouse scroll and observed that the Scroll Val values are positive and negative when the cursor is locked.

Attached screencast for reference.

Adding TE-Verified labels.

Thanks!


701965.mp4
1.9 MB View Download
Requesting a postmortem for this. Please see go/chrome-postmortems for the process to follow.
Components: -IO>PointerLock Blink>Input>PointerLock
Deprecate IO>PointerLock

Sign in to add a comment