New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701945 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

[Network] Polish Network settings

Project Member Reported by bettes@chromium.org, Mar 15 2017

Issue description

Comment 1 by bettes@chromium.org, Mar 15 2017

The P1s and P2s described in the audit are accounted for below and in the mocks above.

Network 01 - top level
- Rename section from "Internet Connection" to "Network"
- Ensure there's 20px between wifi icon and "Wi-Fi" ---> [Edge of card > 20px > icon > 20px > Wi-Fi]
- Ensure you're using the new settings_box row heights: single-line: 48px // double-line: 64px
- Remove "+" icon from "Add connection"

Network 02 - Wi-Fi subpage
- Known networks: Swap arrow and 3-dot menu 
- Known networks: remove divider between Preferred/Known networks
- Known networks: add dividers between networks
- Known networks: use iron-icon.trash instead of "X" for removing preferred network
- Material spinner looks too big. TBA
- Lock badge on network icon should be darker/smaller (same as system menu)
- Ensure you're using the new settings_box row heights: single-line: 48px // double-line: 64px
- Connected network name should not be bold in network list
- "On" should be font-weight: 500 (medium)

Network 03 - Network subpage
- Add a line above "Known networks"
- "Connected" on network detail page is too large
- After our discussion, we talked about organizing "Advanced" in a better way, so now they are 3 separate drawers. LMK if that makes sense

Network 04 - Join network dialogs

Cc: khorimoto@chromium.org elizabethchiu@chromium.org
+elizabethchiu@, +khorimoto@ FYI

We should talk about how the list of visible networks will work with instant tether, specifically in the 'Wi-Fi' network list page:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Network_02.png%3Fz=width

Specifically, we currently want to show the Instant Tether networks above other WiFi networks. However, disabling WiFi will make all networks disappear (since they will no longer be visible), so I think that toggle needs to be at the top of the section.

Cc: jlklein@chromium.org hansberry@chromium.org
Cc: steve...@chromium.org bettes@chromium.org zalcorn@chromium.org
 Issue 700645  has been merged into this issue.
In https://screenshot.googleplex.com/aetqpE0XEiQ.png :
1) There shouldn't be a divider between "Preferred networks" and "All networks" sections
2) The divider between the subpage arrow and 3-dot menu shouldn't be the full height of the row.
Labels: Hotlist-MD-Settings-UIReview
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 24 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4

commit fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4
Author: stevenjb <stevenjb@chromium.org>
Date: Wed Mar 29 23:14:23 2017

MD Settings: Fix Network section styling

This CL makes Settings specific changes to the 'Network' (was 'Internet
conneciton') section.

See issue for specs and screenshots.

BUG= 701945 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2752223003
Cr-Commit-Position: refs/heads/master@{#460569}

[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_subpage.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/network_nameservers.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/network_proxy.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4

commit fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4
Author: stevenjb <stevenjb@chromium.org>
Date: Wed Mar 29 23:14:23 2017

MD Settings: Fix Network section styling

This CL makes Settings specific changes to the 'Network' (was 'Internet
conneciton') section.

See issue for specs and screenshots.

BUG= 701945 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2752223003
Cr-Commit-Position: refs/heads/master@{#460569}

[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_subpage.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/network_nameservers.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/network_proxy.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/fe08f3e8ddd0da65fe91e2537fc29d0acbcc20a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment