Strictly prefer LoadLibraryExW over LoadLibraryW if LoadLibraryW statistically shows no benefits. |
||
Issue descriptionChrome Version: All OS: Windows As pointed in crbug.com/700503 and crbug.com/700208, LoadLibraryW Windows API caused some dll loading failure. To fix this, LoadLibraryExW should be used. The current implementation of LoadNativeLibraryHelper (will be landed very soon) in native_lirary_win.cc is that if LoadLibraryExW API call fails, LoadLibraryW is still tried. We should strictly prefer the LoadLibraryExW over the LoadLibraryW if LoadLibraryW is statistically showing no benefits. The current implementation logs the results of these two API calls to UMA. If UMA metric shows that FAIL_AND_FAIL is the primary failure mode and/or FAIL_AND_SUCCESS is close to zero, we should remove this fallback.
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2740c2cdff6bffe9917f36717f2e0c4cf226dd49 commit 2740c2cdff6bffe9917f36717f2e0c4cf226dd49 Author: Xi Cheng <chengx@chromium.org> Date: Tue Nov 20 22:25:22 2018 Address TODO for native_library_win Bug: 701944 Change-Id: Idf06f127aba7d4a50fa23d631ff78604b3a57258 Reviewed-on: https://chromium-review.googlesource.com/c/1342672 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#609826} [modify] https://crrev.com/2740c2cdff6bffe9917f36717f2e0c4cf226dd49/base/native_library_win.cc
,
Nov 20
|
||
►
Sign in to add a comment |
||
Comment 1 by chengx@chromium.org
, Mar 16 2017