New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701942 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 703363
issue 706613
issue 709695
issue skia:6516

Blocking:
issue 667431



Sign in to add a comment

Color correct rasterization using SkCreateColorSpaceXformCanvas

Project Member Reported by ccameron@chromium.org, Mar 15 2017

Issue description

Use the SkCreateColorSpaceXformCanvas API to convert colors at raster time into the desired color space.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f9a36662a7b695f5d9d3023ad2be013901ebba3

commit 1f9a36662a7b695f5d9d3023ad2be013901ebba3
Author: ccameron <ccameron@chromium.org>
Date: Fri Mar 17 00:43:06 2017

cc: Use SkCreateColorSpaceXformCanvas for color transforms

Add SkCreateColorSpaceXformCanvas, commented out, in RasterSource.

Remove accessors for SkColorSpace and mechanisms for using
kNonLinearBlending_ColorSpaceFlag.

BUG= 701942 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2752523006
Cr-Commit-Position: refs/heads/master@{#457630}

[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/debug/rasterize_and_record_benchmark_impl.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/output/software_renderer.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/playback/raster_source.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/playback/raster_source.h
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/playback/raster_source_unittest.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/raster/one_copy_raster_buffer_provider.h
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/raster/raster_buffer_provider.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/raster/raster_buffer_provider.h
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/raster/zero_copy_raster_buffer_provider.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/resources/resource_provider.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/resources/resource_provider.h
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/test/fake_raster_source.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/cc/test/fake_raster_source.h
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/ui/gfx/color_space.cc
[modify] https://crrev.com/1f9a36662a7b695f5d9d3023ad2be013901ebba3/ui/gfx/color_space.h

Blockedon: 703363
Blockedon: 706613
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77f3b241fc87c2a925ba8d0da94cc97667abc32c

commit 77f3b241fc87c2a925ba8d0da94cc97667abc32c
Author: ccameron <ccameron@chromium.org>
Date: Tue Apr 04 18:16:15 2017

color: Clean up dependencies to allow including in cc/paint

Move color_space.cc and some related functionality into gfx:color_space,
so that they can be included in cc/paint without creating a dependency
cycle.

Also shrink some of the struct sizes and add a hash function, as these
will be helpful in future patches.

BUG= 701942 

Review-Url: https://codereview.chromium.org/2795093002
Cr-Commit-Position: refs/heads/master@{#461770}

[modify] https://crrev.com/77f3b241fc87c2a925ba8d0da94cc97667abc32c/ui/gfx/BUILD.gn
[modify] https://crrev.com/77f3b241fc87c2a925ba8d0da94cc97667abc32c/ui/gfx/color_space.cc
[modify] https://crrev.com/77f3b241fc87c2a925ba8d0da94cc97667abc32c/ui/gfx/color_space.h
[modify] https://crrev.com/77f3b241fc87c2a925ba8d0da94cc97667abc32c/ui/gfx/icc_profile.cc

Blockedon: 709695
Blocking: 667431
Blockedon: skia:6516
Status: Fixed (was: Assigned)
Cc: ccameron@chromium.org chrishtr@chromium.org
 Issue 672295  has been merged into this issue.

Sign in to add a comment