New issue
Advanced search Search tips

Issue 701921 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"TranslateManagerBrowserTest.TranslateSessionRestore" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 15 2017

Issue description

"TranslateManagerBrowserTest.TranslateSessionRestore" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNUcmFuc2xhdGVNYW5hZ2VyQnJvd3NlclRlc3QuVHJhbnNsYXRlU2Vzc2lvblJlc3RvcmUM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 583261 .
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Mar 16 2017

Detected 3 new flakes for test/step "TranslateManagerBrowserTest.TranslateSessionRestore". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNUcmFuc2xhdGVNYW5hZ2VyQnJvd3NlclRlc3QuVHJhbnNsYXRlU2Vzc2lvblJlc3RvcmUM. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
Owner: thomasanderson@chromium.org
https://codereview.chromium.org/2630773002 is a clear cause for the DCHECK.

[ RUN      ] TranslateManagerBrowserTest.TranslateSessionRestore
Xlib:  extension "RANDR" missing on display ":99".
[9443:9443:0310/181222.107433:WARNING:audio_manager.cc(295)] Multiple instances of AudioManager detected
[9443:9443:0310/181222.107487:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager detected
[9443:9443:0310/181222.186170:WARNING:password_store_factory.cc(247)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[9443:9443:0310/181222.316354:FATAL:desktop_window_tree_host_x11.cc(836)] Check failed: !is_active || window_mapped_in_server_.
#0 0x000002e1c1d7 base::debug::StackTrace::StackTrace()
#1 0x000002e34bfb logging::LogMessage::~LogMessage()
#2 0x000003d9ee35 views::DesktopWindowTreeHostX11::IsActive()
#3 0x000003d9bfef views::DesktopWindowTreeHostX11::AfterActivationStateChanged()
#4 0x000003d9ecd1 views::DesktopWindowTreeHostX11::Activate()
#5 0x00000314a9f1 (anonymous namespace)::SessionRestoreImpl::ProcessSessionWindowsAndNotify()
#6 0x00000314933e SessionRestore::RestoreSession()
#7 0x00000535f03a StartupBrowserCreatorImpl::RestoreOrCreateBrowser()
#8 0x00000535dd34 StartupBrowserCreatorImpl::ProcessLaunchUrlsUsingConsolidatedFlow()
#9 0x00000535d5f1 StartupBrowserCreatorImpl::Launch()
#10 0x00000535aef5 StartupBrowserCreator::LaunchBrowser()
#11 0x00000535a7ff StartupBrowserCreator::ProcessCmdLineImpl()
#12 0x000005359d37 StartupBrowserCreator::Start()
#13 0x00000333223c ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#14 0x0000033311c1 ChromeBrowserMainParts::PreMainMessageLoopRun()
#15 0x000001a9eaf5 content::BrowserMainLoop::PreMainMessageLoopRun()
#16 0x000001e8c626 content::StartupTaskRunner::RunAllTasksNow()
#17 0x000001a9c98b content::BrowserMainLoop::CreateStartupTasks()
#18 0x000001aa27ae content::BrowserMainRunnerImpl::Initialize()
#19 0x000001a99e08 content::BrowserMain()
#20 0x000002df9123 content::RunNamedProcessTypeMain()
#21 0x000002df9e36 content::ContentMainRunnerImpl::Run()
#22 0x000002df84c0 content::ContentMain()
#23 0x000003509df0 content::BrowserTestBase::SetUp()
#24 0x000002ef2a51 InProcessBrowserTest::SetUp()
#25 0x000003cdee2e testing::Test::Run()
#26 0x000003cdf9f0 testing::TestInfo::Run()
#27 0x000003cdfd67 testing::TestCase::Run()
#28 0x000003ce6fb7 testing::internal::UnitTestImpl::RunAllTests()
#29 0x000003ce6c37 testing::UnitTest::Run()
#30 0x000002f05b91 base::TestSuite::Run()
#31 0x000002e0e4e8 ChromeTestSuiteRunner::RunTestSuite()
#32 0x0000035393cc content::LaunchTests()
#33 0x000002e0e467 main
#34 0x7f0581143f45 __libc_start_main
#35 0x000000601f61 <unknown>

[1:1:0100/000000.508829:ERROR:broker_posix.cc(41)] Invalid node channel message
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150

commit 9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150
Author: thomasanderson <thomasanderson@google.com>
Date: Fri Mar 17 19:45:27 2017

X11: Fix test flakes related to window focus

This CL removes code intended to fix "some tests depending on a window
being IsActive() immediately after an Activate()".  After
https://codereview.chromium.org/2630773002, all of these cases should
be using WidgetActivationWaiter, so this is unnecessary.  This was
causing DCHECK(!is_active || window_mapped_in_server_) to fail.

In addition, XSetInputFocus on an unmapped window will fail, so
supress the error in this case.  This is the same thing GTK does
https://github.com/GNOME/gtk/blob/7ade6e3f4668220f0fa1382944a87e63691ad9ad/gdk/x11/gdkwindow-x11.c#L1904

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
BUG= 701722 , 701921 , 701706 , 701485 , 701484 , 700692 , 700683 , 700661 , 701886 
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2756183003
Cr-Commit-Position: refs/heads/master@{#457859}

[modify] https://crrev.com/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Status: Fixed (was: Started)

Sign in to add a comment