WebView KeySystem tests looks like they are testing device/OS specific details |
||
Issue descriptionWhile I was working on enabling plznavigate for WebView, I encountered two keysystem tests that were failing. However the failures were device specific: Passing on Android N nexus 5x sometimes failing on Android M Hammerhead failing on the bots which are Hammerhead, Kitkat. I am not entirely sure what to make of it, but either the tests are racy, or they are testing some device specific details or (more likely) both. After discussion with Xiaohan, we decided to disable the tests. However we need to better understand these tests and decide whether to keep them or modify them.
,
Mar 17 2017
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09702159bbbe183dee5baa93f14b2b0c53ac9efe commit 09702159bbbe183dee5baa93f14b2b0c53ac9efe Author: jrummell <jrummell@chromium.org> Date: Mon Mar 20 20:04:54 2017 Reenable WebView KeySystem tests Tests were failing due to copies of //media/base/android code included in multiple libraries. BUG=701916 TEST=tests pass with component builds on both K and M devices Review-Url: https://codereview.chromium.org/2760643003 Cr-Commit-Position: refs/heads/master@{#458155} [modify] https://crrev.com/09702159bbbe183dee5baa93f14b2b0c53ac9efe/android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e1f74d1661ceca17c91e32d1a0b2f27b6747fee commit 5e1f74d1661ceca17c91e32d1a0b2f27b6747fee Author: jam <jam@chromium.org> Date: Tue Mar 21 00:17:05 2017 Revert of Reenable WebView KeySystem tests (patchset #1 id:1 of https://codereview.chromium.org/2760643003/ ) Reason for revert: This is still failing, see https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/10394 Original issue's description: > Reenable WebView KeySystem tests > > Tests were failing due to copies of //media/base/android code included in > multiple libraries. > > BUG=701916 > TEST=tests pass with component builds on both K and M devices > > Review-Url: https://codereview.chromium.org/2760643003 > Cr-Commit-Position: refs/heads/master@{#458155} > Committed: https://chromium.googlesource.com/chromium/src/+/09702159bbbe183dee5baa93f14b2b0c53ac9efe TBR=sgurun@chromium.org,xhwang@chromium.org,jrummell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=701916 Review-Url: https://codereview.chromium.org/2766483002 Cr-Commit-Position: refs/heads/master@{#458249} [modify] https://crrev.com/5e1f74d1661ceca17c91e32d1a0b2f27b6747fee/android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java
,
Aug 23
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 15 2017