Chrome icon in notification title looks not so good |
||
Issue descriptionChrome Version: 59.0.3042.0 OS: macOS 10.12 The problem is that by placing the Chrome app icon at the start of the first line of text in the notification, that line of text no longer aligns with the rest of the text in the message. That ragged-left presentation makes the text difficult to read overall, and looks weird. My first question is why is there a Chrome icon at all? I believe it's to show that this notification is from within Chrome and the web app's icon occupies the normal icon space, but the old system does not display a Chrome icon. Why do we need one now?
,
Mar 16 2017
I read the doc previously and it's not clear what was deliberated. By "application icon" in c#1 are you referring to the Chrome application icon or the web page's icon? You also say that it "needs to be shown" - are you talking as a UX decision or something the macOS notification system requires. What does the private API do, exactly? There are a lot of pieces I'm missing as far as understanding the whys behind these decisions (and options for alternatives).
,
Mar 16 2017
> By "application icon" in c#1 are you referring to the Chrome application icon Chrome icon >You also say that it "needs to be shown" - are you talking as a UX decision or >something the macOS notification system requires. What does the private API do, >exactly? Sorry, I meant that I have not found a way to not show the chrome icon. > What does the private API do, exactly? The api is the _identityImage property in NSUSerNotification. It uses the image you pass as the large icon on the left and at the same time draws the application icon as part of the title. This is what iTunes does for example. https://github.com/indragiek/NSUserNotificationPrivate has some more details. > There are a lot of pieces I'm missing as far as understanding the whys behind these decisions (and options for alternatives) Fair enough, and to be clear, it is totally possible that we are settling for a solution thinking that's the only possible way when in fact it's not. Would reviewing the decisions made in that doc in a meeting help?
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2f2fb7132fc8c110f22390b15e764f68dd6359a commit a2f2fb7132fc8c110f22390b15e764f68dd6359a Author: miguelg <miguelg@chromium.org> Date: Thu Mar 23 12:19:04 2017 [Mac] Revert to using the public API to display notification icons BUG= 701913 Review-Url: https://codereview.chromium.org/2764113004 Cr-Commit-Position: refs/heads/master@{#459054} [modify] https://crrev.com/a2f2fb7132fc8c110f22390b15e764f68dd6359a/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm
,
Apr 19 2017
So in the end we decided to go with the https://bugs.chromium.org/p/chromium/issues/detail?id=701913#c1 for the following reasons 1) In the original version the tiny icon version forces the notification text to be ragged left which does not look very good. 2) There are very few apps using the original version (iMessage that we know of), other like iTunes used to use it and have since moved away 3) The original version uses a private api that is unclear how long is going to be supported. |
||
►
Sign in to add a comment |
||
Comment 1 by miguelg@chromium.org
, Mar 16 201745.4 KB
45.4 KB View Download
34.8 KB
34.8 KB View Download