New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701894 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 701426
issue 701478
issue 701585
issue 705870
issue 706966

Blocking:
issue 255186
issue 706006



Sign in to add a comment

Update linux sysroot from Wheezy to Jessie

Project Member Reported by sbc@chromium.org, Mar 15 2017

Issue description

We dropped support for Wheezy and Precise back in April 2016.

Updated the sysroot to Jessie should have been done a while ago but
we ran into several issues.


 

Comment 1 by sbc@chromium.org, Mar 15 2017

Blockedon: 701478

Comment 2 by sbc@chromium.org, Mar 15 2017

Summary: Update linux sysroot from Wheezy to Jessie (was: Update linux sysroot image from Wheezy to Jessie)

Comment 3 by sbc@chromium.org, Mar 15 2017

Last time I tried to land this change it broken the official builder: b/701585

Comment 4 by sbc@chromium.org, Mar 15 2017

Blockedon: 701585
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94c4fa81c45284d0fe1e5616f52fcad56745077b

commit 94c4fa81c45284d0fe1e5616f52fcad56745077b
Author: sbc <sbc@chromium.org>
Date: Thu Mar 23 13:01:18 2017

Update linux sysroot from Wheezy to Jessie

This is an attempt to reland a change that was attempted
several times already.  It now includes changes to the
linux packaging expectations which previously caused
failed on the official bots.

TESTED=ninja linux_packages_all
BUG= 701894 

Review-Url: https://codereview.chromium.org/2748183005
Cr-Commit-Position: refs/heads/master@{#459062}

[modify] https://crrev.com/94c4fa81c45284d0fe1e5616f52fcad56745077b/build/config/sysroot.gni
[modify] https://crrev.com/94c4fa81c45284d0fe1e5616f52fcad56745077b/build/linux/sysroot_scripts/install-sysroot.py
[modify] https://crrev.com/94c4fa81c45284d0fe1e5616f52fcad56745077b/chrome/installer/linux/debian/expected_deps_ia32_jessie
[modify] https://crrev.com/94c4fa81c45284d0fe1e5616f52fcad56745077b/chrome/installer/linux/debian/expected_deps_x64_jessie
[modify] https://crrev.com/94c4fa81c45284d0fe1e5616f52fcad56745077b/chrome/installer/linux/rpm/expected_deps_i386
[modify] https://crrev.com/94c4fa81c45284d0fe1e5616f52fcad56745077b/chrome/installer/linux/rpm/expected_deps_x86_64
[modify] https://crrev.com/94c4fa81c45284d0fe1e5616f52fcad56745077b/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/94c4fa81c45284d0fe1e5616f52fcad56745077b/tools/copyright_scanner/copyright_scanner.py
[modify] https://crrev.com/94c4fa81c45284d0fe1e5616f52fcad56745077b/tools/mb/mb_config.pyl
[modify] https://crrev.com/94c4fa81c45284d0fe1e5616f52fcad56745077b/ui/ozone/platform/drm/gpu/drm_device.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2365c833788230fc4e09d563fd2fcd4a80f06a31

commit 2365c833788230fc4e09d563fd2fcd4a80f06a31
Author: wittman <wittman@chromium.org>
Date: Thu Mar 23 17:24:33 2017

Revert of Update linux sysroot from Wheezy to Jessie (patchset #3 id:40001 of https://codereview.chromium.org/2748183005/ )

Reason for revert:
Breaks the Official Linux build. Expected deps aren't matching up:

[30924/30936] ACTION //chrome/installer/linux:stable_rpm(//build/toolchain/linux:clang_x64)
FAILED: google-chrome-stable_59.0.3050.0-1.x86_64.rpm
python ../../chrome/installer/linux/flock_make_package.py linux_package.lock installer/rpm/build.sh -o . -b . -a x64 -c stable -d google_chrome
Staging common install files in '/tmp/rpm.build.PQ88Wk'...
Staging RPM install files in '/tmp/rpm.build.PQ88Wk'...
Packaging x86_64...
--- /b/c/b/Google_Chrome_Linux_x64/src/out/Release/installer/rpm/expected_deps_x86_64	2017-03-23 06:48:22.885425473 -0700
+++ /dev/fd/63	2017-03-23 08:04:33.320136041 -0700
@@ -15,7 +15,9 @@
 libasound.so.2()(64bit)
 libatk-1.0.so.0()(64bit)
 libc.so.6()(64bit)
+libc.so.6(GLIBC_2.11)(64bit)
 libc.so.6(GLIBC_2.14)(64bit)
+libc.so.6(GLIBC_2.15)(64bit)
 libc.so.6(GLIBC_2.2.5)(64bit)
 libc.so.6(GLIBC_2.3)(64bit)
 libc.so.6(GLIBC_2.3.2)(64bit)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/rpm/expected_deps_i386
chrome/installer/linux/rpm/expected_deps_x86_64

[30925/30936] ACTION //chrome/installer/linux:unstable_deb(//build/toolchain/linux:clang_x64)
FAILED: google-chrome-unstable_59.0.3050.0-1_amd64.deb
python ../../chrome/installer/linux/flock_make_package.py linux_package.lock installer/debian/build.sh -o . -b . -a x64 -c unstable -d google_chrome -s /b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot
dpkg-shlibdeps: warning: binaries to analyze should already be installed in their package's directory
--- /b/c/b/Google_Chrome_Linux_x64/src/out/Release/installer/debian/expected_deps_x64_jessie	2017-03-23 06:48:22.885425473 -0700
+++ actual	2017-03-23 08:04:37.504250895 -0700
@@ -1,17 +1,17 @@
 gconf-service
 libasound2 (>= 1.0.16)
 libatk1.0-0 (>= 1.12.4)
-libc6 (>= 2.14)
+libc6 (>= 2.15)
 libcairo2 (>= 1.6.0)
 libcups2 (>= 1.4.0)
-libdbus-1-3 (>= 1.2.14)
+libdbus-1-3 (>= 1.1.4)
 libexpat1 (>= 2.0.1)
 libfontconfig1 (>= 2.11)
-libfreetype6 (>= 2.4.2)
+libfreetype6 (>= 2.3.9)
 libgcc1 (>= 1:4.1.1)
 libgconf-2-4 (>= 3.2.5)
 libgdk-pixbuf2.0-0 (>= 2.22.0)
-libglib2.0-0 (>= 2.31.8)
+libglib2.0-0 (>= 2.28.0)
 libgtk-3-0 (>= 3.3.16)
 libnspr4 (>= 2:4.9-2~)
 libnss3 (>= 2:3.13.4-2~)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps_ia32_jessie
chrome/installer/linux/debian/expected_deps_ia32_wheezy
chrome/installer/linux/debian/expected_deps_x64_jessie
chrome/installer/linux/debian/expected_deps_x64_wheezy

Original issue's description:
> Update linux sysroot from Wheezy to Jessie
>
> This is an attempt to reland a change that was attempted
> several times already.  It now includes changes to the
> linux packaging expectations which previously caused
> failed on the official bots.
>
> TESTED=ninja linux_packages_all
> BUG= 701894 
>
> Review-Url: https://codereview.chromium.org/2748183005
> Cr-Commit-Position: refs/heads/master@{#459062}
> Committed: https://chromium.googlesource.com/chromium/src/+/94c4fa81c45284d0fe1e5616f52fcad56745077b

TBR=thestig@chromium.org,thomasanderson@chromium.org,dpranke@chromium.org,thakis@chromium.org,sbc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 701894 

Review-Url: https://codereview.chromium.org/2776503002
Cr-Commit-Position: refs/heads/master@{#459128}

[modify] https://crrev.com/2365c833788230fc4e09d563fd2fcd4a80f06a31/build/config/sysroot.gni
[modify] https://crrev.com/2365c833788230fc4e09d563fd2fcd4a80f06a31/build/linux/sysroot_scripts/install-sysroot.py
[modify] https://crrev.com/2365c833788230fc4e09d563fd2fcd4a80f06a31/chrome/installer/linux/debian/expected_deps_ia32_jessie
[modify] https://crrev.com/2365c833788230fc4e09d563fd2fcd4a80f06a31/chrome/installer/linux/debian/expected_deps_x64_jessie
[modify] https://crrev.com/2365c833788230fc4e09d563fd2fcd4a80f06a31/chrome/installer/linux/rpm/expected_deps_i386
[modify] https://crrev.com/2365c833788230fc4e09d563fd2fcd4a80f06a31/chrome/installer/linux/rpm/expected_deps_x86_64
[modify] https://crrev.com/2365c833788230fc4e09d563fd2fcd4a80f06a31/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/2365c833788230fc4e09d563fd2fcd4a80f06a31/tools/copyright_scanner/copyright_scanner.py
[modify] https://crrev.com/2365c833788230fc4e09d563fd2fcd4a80f06a31/tools/mb/mb_config.pyl
[modify] https://crrev.com/2365c833788230fc4e09d563fd2fcd4a80f06a31/ui/ozone/platform/drm/gpu/drm_device.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47

commit 7f43e46a7830cb92c08b8245f7f48f0d3a2fab47
Author: sbc <sbc@chromium.org>
Date: Fri Mar 24 18:45:44 2017

Reland of "Update linux sysroot from Wheezy to Jessie"

The last version of this change was:
https://codereview.chromium.org/2748183005

Which was reverted in:
https://codereview.chromium.org/2776503002

I've updated the expected package deps again, this
time being sure to use is_chrome_branded=true when
testing (which oddly seems to effect the deps).

TBR=thestig (since this is effectively a reland)
BUG= 701894 

Review-Url: https://codereview.chromium.org/2772503005
Cr-Commit-Position: refs/heads/master@{#459492}

[modify] https://crrev.com/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47/build/config/sysroot.gni
[modify] https://crrev.com/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47/build/linux/sysroot_scripts/install-sysroot.py
[modify] https://crrev.com/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47/chrome/installer/linux/debian/expected_deps_ia32_jessie
[modify] https://crrev.com/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47/chrome/installer/linux/debian/expected_deps_x64_jessie
[modify] https://crrev.com/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47/chrome/installer/linux/rpm/expected_deps_i386
[modify] https://crrev.com/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47/chrome/installer/linux/rpm/expected_deps_x86_64
[modify] https://crrev.com/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47/tools/copyright_scanner/copyright_scanner.py
[modify] https://crrev.com/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47/tools/mb/mb_config.pyl
[modify] https://crrev.com/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47/ui/ozone/platform/drm/gpu/drm_device.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd

commit f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd
Author: thomasanderson <thomasanderson@chromium.org>
Date: Fri Mar 24 21:16:03 2017

Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772503005/ )

Reason for revert:
expected_deps_x64_jessie changes are causing a failure on the official builder

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F16997%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Original issue's description:
> Reland of "Update linux sysroot from Wheezy to Jessie"
>
> The last version of this change was:
> https://codereview.chromium.org/2748183005
>
> Which was reverted in:
> https://codereview.chromium.org/2776503002
>
> I've updated the expected package deps again, this
> time being sure to use is_chrome_branded=true when
> testing (which oddly seems to effect the deps).
>
> TBR=thestig (since this is effectively a reland)
> BUG= 701894 
>
> Review-Url: https://codereview.chromium.org/2772503005
> Cr-Commit-Position: refs/heads/master@{#459492}
> Committed: https://chromium.googlesource.com/chromium/src/+/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47

TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,sbc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 701894 

Review-Url: https://codereview.chromium.org/2772113002
Cr-Commit-Position: refs/heads/master@{#459553}

[modify] https://crrev.com/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd/build/config/sysroot.gni
[modify] https://crrev.com/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd/build/linux/sysroot_scripts/install-sysroot.py
[modify] https://crrev.com/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd/chrome/installer/linux/debian/expected_deps_ia32_jessie
[modify] https://crrev.com/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd/chrome/installer/linux/debian/expected_deps_x64_jessie
[modify] https://crrev.com/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd/chrome/installer/linux/rpm/expected_deps_i386
[modify] https://crrev.com/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd/chrome/installer/linux/rpm/expected_deps_x86_64
[modify] https://crrev.com/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd/tools/copyright_scanner/copyright_scanner.py
[modify] https://crrev.com/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd/tools/mb/mb_config.pyl
[modify] https://crrev.com/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd/ui/ozone/platform/drm/gpu/drm_device.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed

commit b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed
Author: sbc <sbc@chromium.org>
Date: Fri Mar 24 22:50:06 2017

Reland of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772113002/ )

Reason for revert:
Relanding with fixed deps

Original issue's description:
> Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772503005/ )
>
> Reason for revert:
> expected_deps_x64_jessie changes are causing a failure on the official builder
>
> https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F16997%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
>
> Original issue's description:
> > Reland of "Update linux sysroot from Wheezy to Jessie"
> >
> > The last version of this change was:
> > https://codereview.chromium.org/2748183005
> >
> > Which was reverted in:
> > https://codereview.chromium.org/2776503002
> >
> > I've updated the expected package deps again, this
> > time being sure to use is_chrome_branded=true when
> > testing (which oddly seems to effect the deps).
> >
> > TBR=thestig (since this is effectively a reland)
> > BUG= 701894 
> >
> > Review-Url: https://codereview.chromium.org/2772503005
> > Cr-Commit-Position: refs/heads/master@{#459492}
> > Committed: https://chromium.googlesource.com/chromium/src/+/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47
>
> TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,sbc@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 701894 
>
> Review-Url: https://codereview.chromium.org/2772113002
> Cr-Commit-Position: refs/heads/master@{#459553}
> Committed: https://chromium.googlesource.com/chromium/src/+/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd

TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 701894 

Review-Url: https://codereview.chromium.org/2776773002
Cr-Commit-Position: refs/heads/master@{#459584}

[modify] https://crrev.com/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed/build/config/sysroot.gni
[modify] https://crrev.com/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed/build/linux/sysroot_scripts/install-sysroot.py
[modify] https://crrev.com/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed/chrome/installer/linux/debian/expected_deps_ia32_jessie
[modify] https://crrev.com/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed/chrome/installer/linux/rpm/expected_deps_i386
[modify] https://crrev.com/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed/chrome/installer/linux/rpm/expected_deps_x86_64
[modify] https://crrev.com/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed/tools/copyright_scanner/copyright_scanner.py
[modify] https://crrev.com/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed/tools/mb/mb_config.pyl
[modify] https://crrev.com/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed/ui/ozone/platform/drm/gpu/drm_device.cc

Blockedon: 705870
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75a1434be05f2ef09c307f7b70713385232a5b84

commit 75a1434be05f2ef09c307f7b70713385232a5b84
Author: machenbach <machenbach@chromium.org>
Date: Tue Mar 28 12:43:32 2017

Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #2 id:240001 of https://codereview.chromium.org/2776773002/ )

Reason for revert:
Breaks V8 perf testing:
http://crbug.com/705870

Original issue's description:
> Reland of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772113002/ )
>
> Reason for revert:
> Relanding with fixed deps
>
> Original issue's description:
> > Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772503005/ )
> >
> > Reason for revert:
> > expected_deps_x64_jessie changes are causing a failure on the official builder
> >
> > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F16997%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
> >
> > Original issue's description:
> > > Reland of "Update linux sysroot from Wheezy to Jessie"
> > >
> > > The last version of this change was:
> > > https://codereview.chromium.org/2748183005
> > >
> > > Which was reverted in:
> > > https://codereview.chromium.org/2776503002
> > >
> > > I've updated the expected package deps again, this
> > > time being sure to use is_chrome_branded=true when
> > > testing (which oddly seems to effect the deps).
> > >
> > > TBR=thestig (since this is effectively a reland)
> > > BUG= 701894 
> > >
> > > Review-Url: https://codereview.chromium.org/2772503005
> > > Cr-Commit-Position: refs/heads/master@{#459492}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47
> >
> > TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,sbc@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG= 701894 
> >
> > Review-Url: https://codereview.chromium.org/2772113002
> > Cr-Commit-Position: refs/heads/master@{#459553}
> > Committed: https://chromium.googlesource.com/chromium/src/+/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd
>
> TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 701894 
>
> Review-Url: https://codereview.chromium.org/2776773002
> Cr-Commit-Position: refs/heads/master@{#459584}
> Committed: https://chromium.googlesource.com/chromium/src/+/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed

TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,thomasanderson@google.com,sbc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 701894 

Review-Url: https://codereview.chromium.org/2780763002
Cr-Commit-Position: refs/heads/master@{#460070}

[modify] https://crrev.com/75a1434be05f2ef09c307f7b70713385232a5b84/build/config/sysroot.gni
[modify] https://crrev.com/75a1434be05f2ef09c307f7b70713385232a5b84/build/linux/sysroot_scripts/install-sysroot.py
[modify] https://crrev.com/75a1434be05f2ef09c307f7b70713385232a5b84/chrome/installer/linux/debian/expected_deps_ia32_jessie
[modify] https://crrev.com/75a1434be05f2ef09c307f7b70713385232a5b84/chrome/installer/linux/rpm/expected_deps_i386
[modify] https://crrev.com/75a1434be05f2ef09c307f7b70713385232a5b84/chrome/installer/linux/rpm/expected_deps_x86_64
[modify] https://crrev.com/75a1434be05f2ef09c307f7b70713385232a5b84/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/75a1434be05f2ef09c307f7b70713385232a5b84/tools/copyright_scanner/copyright_scanner.py
[modify] https://crrev.com/75a1434be05f2ef09c307f7b70713385232a5b84/tools/mb/mb_config.pyl
[modify] https://crrev.com/75a1434be05f2ef09c307f7b70713385232a5b84/ui/ozone/platform/drm/gpu/drm_device.cc

Blocking: 706006
Blockedon: 701426
(explicitly adding bot dep)
Blocking: 255186
Green light from V8, all remaining bots on trusty now. Sorry for the inconvenience!
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2183884b24334db9eb57f544388c963dd2694f8e

commit 2183884b24334db9eb57f544388c963dd2694f8e
Author: thakis <thakis@chromium.org>
Date: Thu Mar 30 16:50:47 2017

Reland of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2780763002/ )

Reason for revert:
V8 bots are upgraded.

Original issue's description:
> Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #2 id:240001 of https://codereview.chromium.org/2776773002/ )
>
> Reason for revert:
> Breaks V8 perf testing:
> http://crbug.com/705870
>
> Original issue's description:
> > Reland of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772113002/ )
> >
> > Reason for revert:
> > Relanding with fixed deps
> >
> > Original issue's description:
> > > Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772503005/ )
> > >
> > > Reason for revert:
> > > expected_deps_x64_jessie changes are causing a failure on the official builder
> > >
> > > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F16997%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
> > >
> > > Original issue's description:
> > > > Reland of "Update linux sysroot from Wheezy to Jessie"
> > > >
> > > > The last version of this change was:
> > > > https://codereview.chromium.org/2748183005
> > > >
> > > > Which was reverted in:
> > > > https://codereview.chromium.org/2776503002
> > > >
> > > > I've updated the expected package deps again, this
> > > > time being sure to use is_chrome_branded=true when
> > > > testing (which oddly seems to effect the deps).
> > > >
> > > > TBR=thestig (since this is effectively a reland)
> > > > BUG= 701894 
> > > >
> > > > Review-Url: https://codereview.chromium.org/2772503005
> > > > Cr-Commit-Position: refs/heads/master@{#459492}
> > > > Committed: https://chromium.googlesource.com/chromium/src/+/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47
> > >
> > > TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,sbc@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG= 701894 
> > >
> > > Review-Url: https://codereview.chromium.org/2772113002
> > > Cr-Commit-Position: refs/heads/master@{#459553}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd
> >
> > TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG= 701894 
> >
> > Review-Url: https://codereview.chromium.org/2776773002
> > Cr-Commit-Position: refs/heads/master@{#459584}
> > Committed: https://chromium.googlesource.com/chromium/src/+/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed
>
> TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,thomasanderson@google.com,sbc@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 701894 
>
> Review-Url: https://codereview.chromium.org/2780763002
> Cr-Commit-Position: refs/heads/master@{#460070}
> Committed: https://chromium.googlesource.com/chromium/src/+/75a1434be05f2ef09c307f7b70713385232a5b84

TBR=dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,thomasanderson@google.com,sbc@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 701894 

Review-Url: https://codereview.chromium.org/2783193002
Cr-Commit-Position: refs/heads/master@{#460795}

[modify] https://crrev.com/2183884b24334db9eb57f544388c963dd2694f8e/build/config/sysroot.gni
[modify] https://crrev.com/2183884b24334db9eb57f544388c963dd2694f8e/build/linux/sysroot_scripts/install-sysroot.py
[modify] https://crrev.com/2183884b24334db9eb57f544388c963dd2694f8e/chrome/installer/linux/debian/expected_deps_ia32_jessie
[modify] https://crrev.com/2183884b24334db9eb57f544388c963dd2694f8e/chrome/installer/linux/rpm/expected_deps_i386
[modify] https://crrev.com/2183884b24334db9eb57f544388c963dd2694f8e/chrome/installer/linux/rpm/expected_deps_x86_64
[modify] https://crrev.com/2183884b24334db9eb57f544388c963dd2694f8e/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/2183884b24334db9eb57f544388c963dd2694f8e/tools/copyright_scanner/copyright_scanner.py
[modify] https://crrev.com/2183884b24334db9eb57f544388c963dd2694f8e/tools/mb/mb_config.pyl
[modify] https://crrev.com/2183884b24334db9eb57f544388c963dd2694f8e/ui/ozone/platform/drm/gpu/drm_device.cc

Comment 17 by sbc@chromium.org, Mar 30 2017

5th time lucky.  Lets hope it sticks this time!
Blockedon: 706966
Cc: kwiberg@chromium.org
Status: Fixed (was: Assigned)
This time it'll work for sure, let's close this out :-)

Sign in to add a comment