ImageButton/etc should not show ripple on Mac when clicked |
||
Issue descriptionChrome Version: 59.0.3042.0 OS: macOS 10.12 What steps will reproduce the problem? (1) Go to https://www.apple.com/ (2) Click the security decoration to get the site settings dialog (3) Click the site settings dialog's close button What is the expected result? Should not see a ripple effect when clicked. What happens instead? The button shows a ripple. This happens on other dialogs, so I assume it's a characteristic of this close button control. We don't show ripples on the Mac, so this behavior needs to be disabled on macOS.
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d32b67b86c16add90f6ac864d9741a959435ca1 commit 5d32b67b86c16add90f6ac864d9741a959435ca1 Author: ellyjones <ellyjones@chromium.org> Date: Mon Apr 24 16:20:37 2017 views: disable ink drops altogether on Mac These were previously disabled piecemeal using SetInkDropMode(), but that was not the right abstraction layer to disable them, because many other controls individually call SetInkDropMode() to customize their own behavior. Instead, disable it inside InkDropHostView. BUG= 701888 Review-Url: https://codereview.chromium.org/2833133003 Cr-Commit-Position: refs/heads/master@{#466642} [modify] https://crrev.com/5d32b67b86c16add90f6ac864d9741a959435ca1/ui/views/animation/ink_drop_host_view.cc [modify] https://crrev.com/5d32b67b86c16add90f6ac864d9741a959435ca1/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/5d32b67b86c16add90f6ac864d9741a959435ca1/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/5d32b67b86c16add90f6ac864d9741a959435ca1/ui/views/controls/combobox/combobox.cc
,
Apr 24 2017
Should be for-real gone now. |
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, Apr 12 2017Summary: ImageButton/etc should not show ripple on Mac when clicked (was: Close buttons show ripple on Mac when clicked (they should not))