New issue
Advanced search Search tips

Issue 701886 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"WebViewTests/WebViewTest.PRE_StoragePersistence/0" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 15 2017

Issue description

"WebViewTests/WebViewTest.PRE_StoragePersistence/0" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFXZWJWaWV3VGVzdHMvV2ViVmlld1Rlc3QuUFJFX1N0b3JhZ2VQZXJzaXN0ZW5jZS8wDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: thomasanderson@chromium.org
https://codereview.chromium.org/2630773002 is a culprit here as for many other tests

[16789:16789:0316/091947.998163:FATAL:desktop_window_tree_host_x11.cc(836)] Check failed: !is_active || window_mapped_in_server_.
#0 0x000002e42107 base::debug::StackTrace::StackTrace()
#1 0x000002e5ab2b logging::LogMessage::~LogMessage()
#2 0x000003dca255 views::DesktopWindowTreeHostX11::IsActive()
#3 0x000003dc740f views::DesktopWindowTreeHostX11::AfterActivationStateChanged()
#4 0x000003dca0f1 views::DesktopWindowTreeHostX11::Activate()
#5 0x000003da53f2 views::FocusManager::SetFocusedViewWithReason()
#6 0x000003db9ef9 views::Widget::SetInitialFocus()
#7 0x000003e0309b views::DesktopNativeWidgetAura::ShowWithWindowState()
#8 0x000003db82e1 views::Widget::Show()
#9 0x000002a406c3 extensions::AppWindow::Init()
#10 0x000002a9464c extensions::AppWindowCreateFunction::RunAsync()
#11 0x0000029fa021 AsyncExtensionFunction::Run()
#12 0x0000029f8f71 ExtensionFunction::RunWithValidation()
#13 0x0000029fba43 extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal()
#14 0x0000029fb367 extensions::ExtensionFunctionDispatcher::Dispatch()
#15 0x000002a1bbf5 _ZN3IPC8MessageTI29ExtensionHostMsg_Request_MetaSt5tupleIJ31ExtensionHostMsg_Request_ParamsEEvE8DispatchIN10extensions28ExtensionWebContentsObserverES8_N7content15RenderFrameHostEMS8_FvPSA_RKS3_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#16 0x000002a1bace extensions::ExtensionWebContentsObserver::OnMessageReceived()
#17 0x000004f30590 extensions::ChromeExtensionWebContentsObserver::OnMessageReceived()
#18 0x000001ec9cda content::WebContentsImpl::OnMessageReceived()
#19 0x000001bcfe29 content::RenderFrameHostImpl::OnMessageReceived()
#20 0x000001dad898 content::RenderProcessHostImpl::OnMessageReceived()
#21 0x000004104a35 IPC::ChannelProxy::Context::OnDispatchMessage()
#22 0x0000019d5d5a _ZN4base8internal7InvokerINS0_9BindStateINS0_18IgnoreResultHelperIMN7content20BrowserMessageFilter8InternalEFbRKN3IPC7MessageEEEEJ13scoped_refptrIS6_ES8_EEEFvvEE3RunEPNS0_13BindStateBaseE
#23 0x000002ef11c9 base::debug::TaskAnnotator::RunTask()
#24 0x000002e620bd base::MessageLoop::RunTask()
#25 0x000002e62766 base::MessageLoop::DoWork()
#26 0x000002e6494a base::(anonymous namespace)::WorkSourceDispatch()
#27 0x7f274dd60e04 g_main_context_dispatch
#28 0x7f274dd61048 <unknown>
#29 0x7f274dd610ec g_main_context_iteration
#30 0x000002e64726 base::MessagePumpGlib::Run()
#31 0x000002e61e0e base::MessageLoop::RunHandler()
#32 0x000002e8ab4c base::RunLoop::Run()
#33 0x0000035667ae content::RunThisRunLoop()
#34 0x0000072344bb extensions::ResultCatcher::GetNextResult()
#35 0x0000012e5b80 ExtensionApiTest::RunExtensionTestImpl()
#36 0x0000012e634b ExtensionApiTest::RunPlatformAppTestWithFlags()
#37 0x00000064c1a1 WebViewTest_PRE_StoragePersistence_Test::RunTestOnMainThread()
#38 0x000002f1b79f InProcessBrowserTest::RunTestOnMainThreadLoop()
#39 0x000003534316 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#40 0x00000335b729 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#41 0x00000335a5e1 ChromeBrowserMainParts::PreMainMessageLoopRun()
#42 0x000001ab0295 content::BrowserMainLoop::PreMainMessageLoopRun()
#43 0x000001e9f176 content::StartupTaskRunner::RunAllTasksNow()
#44 0x000001aae12b content::BrowserMainLoop::CreateStartupTasks()
#45 0x000001ab3e7e content::BrowserMainRunnerImpl::Initialize()
#46 0x000001aab5a8 content::BrowserMain()
#47 0x000002e1f6d3 content::RunNamedProcessTypeMain()
#48 0x000002e203e6 content::ContentMainRunnerImpl::Run()
#49 0x000002e1ea70 content::ContentMain()
#50 0x000003533c20 content::BrowserTestBase::SetUp()
#51 0x000002f19de1 InProcessBrowserTest::SetUp()
#52 0x000003d0a00e testing::Test::Run()
#53 0x000003d0abd0 testing::TestInfo::Run()
#54 0x000003d0af47 testing::TestCase::Run()
#55 0x000003d12197 testing::internal::UnitTestImpl::RunAllTests()
#56 0x000003d11e17 testing::UnitTest::Run()
#57 0x000002f2cf41 base::TestSuite::Run()
#58 0x000002e34428 ChromeTestSuiteRunner::RunTestSuite()
#59 0x00000356328c content::LaunchTests()
#60 0x000002e343a7 main
#61 0x7f2748223f45 __libc_start_main

Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, Mar 17 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "WebViewTests/WebViewTest.PRE_StoragePersistence/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFXZWJWaWV3VGVzdHMvV2ViVmlld1Rlc3QuUFJFX1N0b3JhZ2VQZXJzaXN0ZW5jZS8wDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150

commit 9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150
Author: thomasanderson <thomasanderson@google.com>
Date: Fri Mar 17 19:45:27 2017

X11: Fix test flakes related to window focus

This CL removes code intended to fix "some tests depending on a window
being IsActive() immediately after an Activate()".  After
https://codereview.chromium.org/2630773002, all of these cases should
be using WidgetActivationWaiter, so this is unnecessary.  This was
causing DCHECK(!is_active || window_mapped_in_server_) to fail.

In addition, XSetInputFocus on an unmapped window will fail, so
supress the error in this case.  This is the same thing GTK does
https://github.com/GNOME/gtk/blob/7ade6e3f4668220f0fa1382944a87e63691ad9ad/gdk/x11/gdkwindow-x11.c#L1904

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
BUG= 701722 , 701921 , 701706 , 701485 , 701484 , 700692 , 700683 , 700661 , 701886 
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2756183003
Cr-Commit-Position: refs/heads/master@{#457859}

[modify] https://crrev.com/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Status: Fixed (was: Started)

Sign in to add a comment