New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701868 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

input: Turn off KB backlight in tablet mode

Project Member Reported by sha...@chromium.org, Mar 15 2017

Issue description

For cros-ec convertible devices that have a keyboard backlight (EC_FEATURE_PWM_KEYB), the host needs to turn off the KB backlight (in addition to ignoring KB input, etc) when it is in tablet mode. This can be done through EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT (obsolete) or EC_CMD_PWM_SET_DUTY (new preferred host command).

I'm not sure how / where this should be implemented on the host side, some guidance is needed.
 

Comment 1 by derat@chromium.org, Mar 15 2017

Components: OS>Kernel>Power
Is this exposed to userspace yet? If so, I'm happy to make powerd do it when necessary -- just give me the commands to run or sysfs files to write to or whatever.

Comment 3 by derat@chromium.org, Mar 15 2017

#2: The existing powerd code writes "0" to the brightness file in sysfs. Does that get translated to EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT or EC_CMD_PWM_SET_DUTY further down the stack?

Comment 4 by dlaurie@google.com, Mar 15 2017

The kernel driver the ACPI interface for keyboard backlight, not the EC commands, but it should be the same in the end.

Comment 5 by derat@chromium.org, Mar 15 2017

Okay. I'm assuming that this already works then, but let me know if you see cases where it doesn't.

Comment 6 by sha...@chromium.org, Mar 15 2017

Status: WontFix (was: Untriaged)
Sorry for the false bug, this should already be working.

Comment 7 by gwendal@google.com, Mar 15 2017

If we want to bikeshed, I would argue we need to disable keyboard backlight in tent mode as well. 
The short term solution would be to have chrome issue ApplyBrightnessPercent(0), 
a longer term would be to wait for the inclinometer sensor and have powerd listening to lid angle changes. 

Comment 8 by derat@chromium.org, Mar 15 2017

ApplyBrightnessPercent() is a function in powerd, not in Chrome. Chrome doesn't do anything backlight-related.

Sign in to add a comment