input: Turn off KB backlight in tablet mode |
||
Issue descriptionFor cros-ec convertible devices that have a keyboard backlight (EC_FEATURE_PWM_KEYB), the host needs to turn off the KB backlight (in addition to ignoring KB input, etc) when it is in tablet mode. This can be done through EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT (obsolete) or EC_CMD_PWM_SET_DUTY (new preferred host command). I'm not sure how / where this should be implemented on the host side, some guidance is needed.
,
Mar 15 2017
I think powerd already does this: https://chromium.googlesource.com/chromiumos/platform2/+/master/power_manager/powerd/policy/keyboard_backlight_controller.cc#445
,
Mar 15 2017
#2: The existing powerd code writes "0" to the brightness file in sysfs. Does that get translated to EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT or EC_CMD_PWM_SET_DUTY further down the stack?
,
Mar 15 2017
The kernel driver the ACPI interface for keyboard backlight, not the EC commands, but it should be the same in the end.
,
Mar 15 2017
Okay. I'm assuming that this already works then, but let me know if you see cases where it doesn't.
,
Mar 15 2017
Sorry for the false bug, this should already be working.
,
Mar 15 2017
If we want to bikeshed, I would argue we need to disable keyboard backlight in tent mode as well. The short term solution would be to have chrome issue ApplyBrightnessPercent(0), a longer term would be to wait for the inclinometer sensor and have powerd listening to lid angle changes.
,
Mar 15 2017
ApplyBrightnessPercent() is a function in powerd, not in Chrome. Chrome doesn't do anything backlight-related. |
||
►
Sign in to add a comment |
||
Comment 1 by derat@chromium.org
, Mar 15 2017