New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701866 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Refresh token is not available when Chrome is restarted after crash

Project Member Reported by khmel@chromium.org, Mar 15 2017

Issue description

In case Chrome is restarted after crash refresh token is not available for sign-in profile. This case several problems:

Known:
  Profile image is random
  ARC cannot be started with 'SERVER_COMMUNICATION_ERROR'
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0e2fb482636b0c1aed01f2d672ec5619bff9eb9

commit f0e2fb482636b0c1aed01f2d672ec5619bff9eb9
Author: khmel <khmel@chromium.org>
Date: Fri Mar 17 00:15:26 2017

Fix refresh token is not available after Chrome restart on crash.

In case Chrome crashed and restarted, refresh token was not reloaded.
This caused several problems, including random user image profile
and impossibility to opt in ARC.

TEST=Manually simulated crash. On Chrome restart profile image is
     correct and ARC can be opted in. Also logs show that token
     is loaded correctly.
BUG= 701866 

Review-Url: https://codereview.chromium.org/2752873002
Cr-Commit-Position: refs/heads/master@{#457619}

[modify] https://crrev.com/f0e2fb482636b0c1aed01f2d672ec5619bff9eb9/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/f0e2fb482636b0c1aed01f2d672ec5619bff9eb9/components/signin/core/browser/signin_manager_base.cc
[modify] https://crrev.com/f0e2fb482636b0c1aed01f2d672ec5619bff9eb9/tools/metrics/histograms/histograms.xml

Comment 2 by khmel@chromium.org, Mar 17 2017

Cc: bhthompson@chromium.org
Labels: Merge-Request-58
Labels: -Merge-Request-58 Merge-Approved-58
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 17 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9756a1c5e5aa3819bcec390961a8af429b8ad66

commit e9756a1c5e5aa3819bcec390961a8af429b8ad66
Author: khmel <khmel@chromium.org>
Date: Fri Mar 17 17:52:48 2017

[Merge M58] Fix refresh token is not available after Chrome restart on crash.

In case Chrome crashed and restarted, refresh token was not reloaded.
This caused several problems, including random user image profile
and impossibility to opt in ARC.

TEST=Manually simulated crash. On Chrome restart profile image is
     correct and ARC can be opted in. Also logs show that token
     is loaded correctly.
BUG= 701866 

TBR=xiyuan@chromium.org,isherman@chromium.org,msarda@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2752873002
Cr-Commit-Position: refs/heads/master@{#457619}
(cherry picked from commit f0e2fb482636b0c1aed01f2d672ec5619bff9eb9)

Review-Url: https://codereview.chromium.org/2756733005
Cr-Commit-Position: refs/branch-heads/3029@{#269}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/e9756a1c5e5aa3819bcec390961a8af429b8ad66/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/e9756a1c5e5aa3819bcec390961a8af429b8ad66/components/signin/core/browser/signin_manager_base.cc
[modify] https://crrev.com/e9756a1c5e5aa3819bcec390961a8af429b8ad66/tools/metrics/histograms/histograms.xml

Comment 5 by khmel@chromium.org, Mar 17 2017

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment