New issue
Advanced search Search tips

Issue 701865 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Developer Tools Console Port Number Ignored In URL Link

Reported by gavin.pa...@gmail.com, Mar 15 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
1. In the Developer Tools Console, output a URL with a port number
2. Click on the link

What is the expected behavior?
The link for the URL should include the port number

What went wrong?
The port number isn't included in the link

Did this work before? N/A 

Chrome version: 56.0.2924.87  Channel: stable
OS Version: 10.0
Flash Version:
 
Chrome Debugger Console URL Port Bug.png
13.4 KB View Download
Labels: Needs-Triage-M56
Labels: -Needs-Triage-M56 M-59 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on Mac 10.12.3, Win-10 and Ubuntu 14.04 using chrome reported version #56.0.2924.87 and latest canary #59.0.3042.4.

This is a non-regression issue as it is observed from M30 old builds. 

Hence, marking it as untriaged to get more inputs from dev team.

Thanks...!!
Owner: l...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/201eaf7de7e46e23f5955dc8b57db0d76add14c2

commit 201eaf7de7e46e23f5955dc8b57db0d76add14c2
Author: luoe <luoe@chromium.org>
Date: Fri Apr 28 03:20:55 2017

DevTools: linkifier incorrectly matches port numbers in urls as line numbers

When logging a URL with a port number in the console, 'http://localhost:8000',
our linkifier incorrectly treats the '8000' port number as a line number.

Using our existing granular URL regexes, this patch makes the linkifier ignore
the URL part before the 'path' when looking for a line/column number.

BUG= 701865 

Review-Url: https://codereview.chromium.org/2843073003
Cr-Commit-Position: refs/heads/master@{#467868}

[modify] https://crrev.com/201eaf7de7e46e23f5955dc8b57db0d76add14c2/third_party/WebKit/LayoutTests/inspector/components/parsed-url-expected.txt
[modify] https://crrev.com/201eaf7de7e46e23f5955dc8b57db0d76add14c2/third_party/WebKit/LayoutTests/inspector/components/parsed-url.html
[modify] https://crrev.com/201eaf7de7e46e23f5955dc8b57db0d76add14c2/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js

Comment 5 by l...@chromium.org, May 4 2017

Status: Fixed (was: Assigned)
In Chrome Version 59.0.3071.86 (Official Build) (64-bit) I'm still seeing this problem.

Comment 7 by l...@chromium.org, Jun 7 2017

It looks like the commit with the fix missed the Beta branch, which has up to commit #464641.

The fix is currently in Dev channel version 60.0.3112.20, which should reach Beta sometime next week and Stable later.  Thanks for checking in, it's on it's way.
Oh, I see. Thanks!

Sign in to add a comment