New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701850 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Innocent CLs didn't get submitted in CQ

Project Member Reported by nxia@chromium.org, Mar 15 2017

Issue description

When looking into master-paladin/13954, found some CLs didn't get submitted although all failures should be ignorable to them. 

For example, CL:439068 is configured with "ignored-stages: HWTest VMTest", and all failure slaves failed at HWTest stage. Needs more investigation here.

https://chromium-review.googlesource.com/c/439068/


https://luci-milo.appspot.com/buildbot/chromeos/master-paladin/13954
 

Comment 1 by nxia@chromium.org, Mar 15 2017

Looked into veyron_minnie-paladin BuilderStatus, it recorded wrong failed_stage_prefix 'HWTest [arc-bvt-cq]' instead of the right prefix 'HWTest'.

Comment 2 Deleted

Comment 3 by nxia@chromium.org, Mar 16 2017

Turns out the HWTest run in parallel with other stages, timed out and got canceled. Results.Record should specify out the stage_name_prefix.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/30240e0ab69af6ec4f4016bbf72c4f4c75f3bc64

commit 30240e0ab69af6ec4f4016bbf72c4f4c75f3bc64
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Mar 16 23:15:07 2017

Results.Record should specify out stage_name_prefix.

Projects can be configured with ignored-stages which only specify the
prefix names of ignored stages. BuilderStatus.message should provide
the stage prefix names (instead of full names) of the failed stages so
they can be ignored correctly.

BUG= chromium:701850 
TEST=unit_tests

Change-Id: If4a60e8ea2850c56b0bce8dee95eee9d7a19cc38
Reviewed-on: https://chromium-review.googlesource.com/456078
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/30240e0ab69af6ec4f4016bbf72c4f4c75f3bc64/cbuildbot/builders/generic_builders.py
[modify] https://crrev.com/30240e0ab69af6ec4f4016bbf72c4f4c75f3bc64/cbuildbot/builders/generic_builders_unittest.py

Comment 5 by nxia@chromium.org, Mar 22 2017

Status: Fixed (was: Untriaged)

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment