New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701849 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

RuntimeEnabled=MediaConstraints is superfluous, consider removing

Project Member Reported by mcasas@chromium.org, Mar 15 2017

Issue description

Comment 1 by mcasas@chromium.org, Mar 15 2017

Cc: hta@chromium.org
After https://crrev.com/2752633002, the same applies to
MediaGetSettings, which is Stable now.  Consider just
removing its use.

Comment 2 by guidou@chromium.org, Mar 16 2017

Owner: guidou@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6093997931808df404b0350cfa4630a3a8bc6143

commit 6093997931808df404b0350cfa4630a3a8bc6143
Author: mcasas <mcasas@chromium.org>
Date: Thu Mar 23 02:57:02 2017

Cleanup: remove some of MediaTrack's stable flags and correct ImageCapture ones

This CL removes MediaConstraints and MediaGetSettings since
they are stable and they make reading idl's etc verbose when
interacting with other, non-stable, flags.

Also correction of the use of ImageCapture flag:

s/RuntimeEnabled=ImageCapture/OriginTrialEnabled=ImageCapture/

No code changes per se.

BUG= 701849 

Review-Url: https://codereview.chromium.org/2768653002
Cr-Commit-Position: refs/heads/master@{#458990}

[modify] https://crrev.com/6093997931808df404b0350cfa4630a3a8bc6143/third_party/WebKit/Source/modules/mediastream/MediaDevices.idl
[modify] https://crrev.com/6093997931808df404b0350cfa4630a3a8bc6143/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl
[modify] https://crrev.com/6093997931808df404b0350cfa4630a3a8bc6143/third_party/WebKit/Source/modules/mediastream/MediaTrackCapabilities.idl
[modify] https://crrev.com/6093997931808df404b0350cfa4630a3a8bc6143/third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl
[modify] https://crrev.com/6093997931808df404b0350cfa4630a3a8bc6143/third_party/WebKit/Source/modules/mediastream/MediaTrackSettings.idl
[modify] https://crrev.com/6093997931808df404b0350cfa4630a3a8bc6143/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Comment 4 by mcasas@chromium.org, Mar 23 2017

Owner: mcasas@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment