further differentiate build failures from test failures |
||
Issue descriptionSoM's analyzer currently lumps build failures in with test failures, all under the alert type of messages.AlertBuildFailure. Given that the tasks to remedy the two different scenarios are different, we should split these alerts out further in the UI. Build failures are also more severe than test failures in terms of how much work they block. To start out we should add a messages.AlertTestFailure alert type and modify the analyzer code to set it properly based on whether or not infra/monitoring/analyzer/step/test_step.go was the step analyzer that identified the failure. (consider modifying the StepAnalyzer interface's Kind() function to return an actual messagess.AlertType value).
,
Dec 15 2017
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/f8ee7621db022e08467e057b274713b037340059 commit f8ee7621db022e08467e057b274713b037340059 Author: Sean McCullough <seanmccullough@chromium.org> Date: Tue Jan 09 00:44:23 2018 [som] Add messages.AlertTestFailure and set it when appropriate. Bug: 701839 Change-Id: Id31de34e0f817b65f19cdcefc1f06a329663a55e Reviewed-on: https://chromium-review.googlesource.com/854955 Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org> Commit-Queue: Sean McCullough <seanmccullough@chromium.org> [modify] https://crrev.com/f8ee7621db022e08467e057b274713b037340059/go/src/infra/appengine/sheriff-o-matic/som/handler/analyze.go [modify] https://crrev.com/f8ee7621db022e08467e057b274713b037340059/go/src/infra/appengine/sheriff-o-matic/som/model/gen/events.proto [modify] https://crrev.com/f8ee7621db022e08467e057b274713b037340059/go/src/infra/appengine/sheriff-o-matic/som/model/gen/events.pb.go [modify] https://crrev.com/f8ee7621db022e08467e057b274713b037340059/go/src/infra/appengine/sheriff-o-matic/som/analyzer/analyzer.go [modify] https://crrev.com/f8ee7621db022e08467e057b274713b037340059/go/src/infra/monitoring/messages/alerts.go |
||
►
Sign in to add a comment |
||
Comment 1 by seanmccullough@chromium.org
, Aug 8 2017