New issue
Advanced search Search tips

Issue 701837 link

Starred by 2 users
Status: Fixed
Owner:
l...@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: icon in debugger paused message should be red for exception

Project Member Reported by l...@chromium.org, Mar 15 2017 
Repro:
- Turn on 'Pause on caught exceptions' in Sources
- Pause on exceptions (e.g. run a snippet with an error)

In the screenshot, the paused message has a blue 'i' icon when it should be the red 'x'.  Also, 'Pause on caught exceptions' should not wrap.
sources_style.png
41.4 KB View Download

Comment 2 by l...@chromium.org, Mar 15 2017 

In the proposed change, see screenshot, the 'x' is shown.  Also, the error message under 'Paused on exception' can truncate, so we should set the tooltip to the text in case it is not fully visible.
sources_style_new.png
27.1 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/709c250de897822863b34fc73e0f15d462507bcf

commit 709c250de897822863b34fc73e0f15d462507bcf
Author: luoe <luoe@chromium.org>
Date: Wed Mar 15 20:58:01 2017

DevTools: update debugger sidepane style for paused on exception

- Fixes 'i' icon with red 'x'
- No more wrapping of 'Paused on exception' or 'Not paused' messages
- Tooltip shown when possible on the message text

BUG= 701837 

Review-Url: https://codereview.chromium.org/2750103002
Cr-Commit-Position: refs/heads/master@{#457204}

[modify] https://crrev.com/709c250de897822863b34fc73e0f15d462507bcf/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js
[modify] https://crrev.com/709c250de897822863b34fc73e0f15d462507bcf/third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css
[modify] https://crrev.com/709c250de897822863b34fc73e0f15d462507bcf/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css

Comment 4 by l...@chromium.org, Apr 20 2017

Status: Fixed (was: Started)
►

Sign in to add a comment