New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701835 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug

Blocking:
issue 701833
issue 711343



Sign in to add a comment

Create a DevTools component

Project Member Reported by thanhph@chromium.org, Mar 15 2017

Issue description

For Chrome to use DevTools in Window and Linux, as the 3rd step, we need to move DevTools out of ash. More specifically, we need to move //ash/devtools into //components/ui_devtools. Ash will still be able to call DevTools as a component.
 
Description: Show this description
Blocking: 701833
Blocking: -701833
Cc: varkha@chromium.org sadrul@chromium.org
Blocking: 701833
Blocking: 701840
Description: Show this description
Description: Show this description
Blockedon: 711341
Blocking: -701840
Blocking: 711343
Blockedon: -711341
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f39685180b85f09614e287f1150dabfc9fa9d05

commit 3f39685180b85f09614e287f1150dabfc9fa9d05
Author: thanhph <thanhph@chromium.org>
Date: Wed Jun 21 00:37:23 2017

Move DevTools out of ash and turn it to a component. AshTestbase
dependency will be removed and replaced by ViewTestBase. Appropriate
UIElement trees are also created to test DevTools.

BUG= 701835 

Review-Url: https://codereview.chromium.org/2899783002
Cr-Commit-Position: refs/heads/master@{#481047}

[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/ash/BUILD.gn
[delete] https://crrev.com/3db9563bba1d755372c662cebb6402a4cc43e0e5/ash/devtools/ash_devtools_css_agent.h
[delete] https://crrev.com/3db9563bba1d755372c662cebb6402a4cc43e0e5/ash/devtools/ash_devtools_dom_agent.h
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/ash/shell.cc
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/ash/shell.h
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/chrome/browser/about_flags.cc
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/chrome/browser/ui/webui/inspect_ui.cc
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/BUILD.gn
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/BUILD.gn
[add] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/README.md
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/devtools_base_agent.h
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/devtools_client.cc
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/devtools_client.h
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/devtools_server.cc
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/devtools_server.h
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/inspector_protocol_config.json
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/string_util.cc
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/string_util.h
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/switches.cc
[modify] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/switches.h
[add] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/BUILD.gn
[add] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/DEPS
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/OWNERS
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/ui_devtools_css_agent.cc
[add] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/ui_devtools_css_agent.h
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/ui_devtools_dom_agent.cc
[add] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/ui_devtools_dom_agent.h
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/ui_devtools_unittest.cc
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/ui_element.cc
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/ui_element.h
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/ui_element_delegate.h
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/view_element.cc
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/view_element.h
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/widget_element.cc
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/widget_element.h
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/window_element.cc
[rename] https://crrev.com/3f39685180b85f09614e287f1150dabfc9fa9d05/components/ui_devtools/views/window_element.h

Status: Fixed (was: Available)
Labels: Hotlist-UI-DevTools

Sign in to add a comment