New issue
Advanced search Search tips

Issue 701801 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 890390



Sign in to add a comment

WebContentsViewAuraTest.ReplaceStateReloadPushState has commented out code

Project Member Reported by eugene...@chromium.org, Mar 15 2017

Issue description

These expectations are commented out.
//EXPECT_FALSE(screenshot_manager()->screenshot_taken_for());
//EXPECT_FALSE(screenshot_manager()->screenshot_taken_for());
 
Blockedon: 890390
Owner: moh...@chromium.org
Status: Assigned (was: Untriaged)
The test will be removed now that the new gesture-nav UI is the default and screenshot-based UI is deprecated.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac3bb2923c432a36c23bee282c551192db29be33

commit ac3bb2923c432a36c23bee282c551192db29be33
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Sat Dec 22 00:48:07 2018

Removed parallax overscroll code

The parallax overscroll mode is deprecated and the flag to enable it is
already removed in M72. This CL removes unused code for this mode.

BUG= 890390 , 357311 , 399676 , 405945 , 705599 , 701801 , 727718 

Change-Id: I8ab710635e0291dacd8aacdd76c45ffeaf2fac7b
Reviewed-on: https://chromium-review.googlesource.com/c/1273609
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618693}
[modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/BUILD.gn
[modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_navigation_overlay.cc
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_navigation_overlay.h
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_animation.cc
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_animation.h
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_animation_unittest.cc
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_delegate.cc
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_delegate.h
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/shadow_layer_delegate.cc
[delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/shadow_layer_delegate.h
[modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/web_contents/web_contents_view_aura_browsertest.cc
[modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/web_contents/web_contents_view_aura_unittest.cc
[modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/test/BUILD.gn

Status: WontFix (was: Assigned)
Test does not exist anymore as of r618693.

Sign in to add a comment