New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701781 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.2% regression in memory.top_10_mobile at 456679:456713

Project Member Reported by nzolghadr@chromium.org, Mar 15 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=701781

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9IrTowsM


Bot(s) for this bug's original alert(s):

android-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 16 2017

Cc: eholk@chromium.org
Owner: eholk@chromium.org

=== Auto-CCing suspected CL author eholk@chromium.org ===

Hi eholk@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : eholk
  Commit : 118c376fcbe483b155eec26f8d9192f8cb4b4721
  Date   : Mon Mar 13 22:12:23 2017
  Subject: [wasm] Initial signal handler

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/background/after_http_www_baidu_com_s_word_google
  Change       : 0.82% | 3982156.0 -> 4014853.33333

Revision                           Result                  N
chromium@456678                    3982156 +- 16415.0      6      good
chromium@456687                    3979343 +- 14028.7      6      good
chromium@456690                    3977908 +- 12309.9      6      good
chromium@456690,v8@118c376fcb      4019669 +- 581.712      6      bad       <--
chromium@456690,v8@3800ba6cc7      4019671 +- 635.929      6      bad
chromium@456690,v8@97254b0d23      4028192 +- 21178.2      6      bad
chromium@456690,v8@f20261bfb4      4011679 +- 9120.8       6      bad
chromium@456691                    4017348 +- 7389.56      6      bad
chromium@456692                    4016159 +- 9170.79      6      bad
chromium@456696                    4017368 +- 14050.0      6      bad
chromium@456713                    4014853 +- 9982.42      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8985044085020815408

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6098408873394176


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
These are all less than 100kib, from before we had thresholds on our monitoring.

Sign in to add a comment