New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701774 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: 2019-07-09
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebContentsVideoCaptureDeviceTest tests are flaky

Project Member Reported by dimaa@chromium.org, Mar 15 2017

Issue description

These tests are always failing in Sub-Batches listed below.

Failed tests:
ChildMemoryCoordinatorImplTest.MultipleClients
WebContentsVideoCaptureDeviceTest.RunsThenErrorsOutWhenWebContentsIsDestroyed
WebContentsVideoCaptureDeviceTest.SafelyStartsUpAfterWebContentsHasGone

It seems that PepperToVideoTrackAdapterTest cause a failure of WebContentsVideoCaptureDeviceTest.
And something wrong with ChildMemoryCoordinatorImplTest.

Sub-Batches:
==================
PepperToVideoTrackAdapterTest.Open
WebContentsVideoCaptureDeviceTest.SafelyStartsUpAfterWebContentsHasGone
==================
VideoTrackToPepperAdapterTest.OpenClose
WebContentsVideoCaptureDeviceTest.RunsThenErrorsOutWhenWebContentsIsDestroyed
==================
PepperToVideoTrackAdapterTest.Open
WebContentsVideoCaptureDeviceTest.RunsThenErrorsOutWhenWebContentsIsDestroyed
==================
ChildMemoryCoordinatorImplTest.SingleClient
ChildMemoryCoordinatorImplTest.MultipleClients
==================
VideoTrackToPepperAdapterTest.OpenClose
WebContentsVideoCaptureDeviceTest.SafelyStartsUpAfterWebContentsHasGone
==================
PepperToVideoTrackAdapterTest.PutFrame
WebContentsVideoCaptureDeviceTest.SafelyStartsUpAfterWebContentsHasGone
==================
PepperToVideoTrackAdapterTest.PutFrame
WebContentsVideoCaptureDeviceTest.RunsThenErrorsOutWhenWebContentsIsDestroyed
==================
VideoTrackToPepperAdapterTest.OpenWithoutClose
WebContentsVideoCaptureDeviceTest.RunsThenErrorsOutWhenWebContentsIsDestroyed
==================
VideoTrackToPepperAdapterTest.OpenWithoutClose
WebContentsVideoCaptureDeviceTest.SafelyStartsUpAfterWebContentsHasGone


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04dacb77609289f7db577ecc5bbdd6fecba25c4f

commit 04dacb77609289f7db577ecc5bbdd6fecba25c4f
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Sep 05 18:37:32 2017

Null out MemoryCoordinator on ChildMemoryCoordinatorImpl teardown

Otherwise, when run as
--gtest_filter=ChildMemoryCoordinatorImplTest.SingleClient:ChildMemoryCoordinatorImplTest.MultipleClients
content_unittests DCHECKs reliably.

This showed up on Fuchsia, but is cross-platform (and had been reported
earlier in crbug.com/701774.)

Bug: 701774,  754861 
Change-Id: I93da6d698a6fbe5ab8cd2f399896f21994b4dd98
Reviewed-on: https://chromium-review.googlesource.com/646707
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499687}
[modify] https://crrev.com/04dacb77609289f7db577ecc5bbdd6fecba25c4f/content/child/memory/child_memory_coordinator_impl.cc
[modify] https://crrev.com/04dacb77609289f7db577ecc5bbdd6fecba25c4f/testing/buildbot/filters/fuchsia.content_unittests.filter

Labels: Pri-3
NextAction: 2019-07-09
Downgrading P2s that haven't been modified in more than 6 months, which have no component or owner.

Sign in to add a comment