@tdanderson this seems like a relic of the old UI where we used to replace the info button with a spinner when searching for wifi networks. Since we now use the slick new progress bar, we should keep the tooltip as "Network info" permanently. @stevenjb made the change for the old UI, but maybe someone else familiar with the new UI should take this on?

Marking as P2 for M59 since it's not too awful for a tooltip to sometimes change.

I left this in intentionally when applying the new progress bar UI. I thought it made sense because it clarifies why you're seeing a progress bar and is useful for a11y as well. If the old spinner required an explanation why doesn't the new progress UI require an explanation?

I would consider this to be WAI since this is the only way ChromeVox users are able to know searching for WiFi networks is in progress, and this is in a consistent place as compared to pre-MD. It seems that changing the tooltip as suggested in #0 would be an a11y regression. Further discussion at https://chromiumcodereview.appspot.com/2722373002/ .


Tom, handing this back to you in case you feel differently.

Sorry, this only made sense before because the info icon would actually become a spinner when we were actively searching for wifi networks. Now that that's no longer the case it seems confusing to continue showing the tooltip there.

Is it possible that some other focusable element could explain that we're searching for wifi? Could the progress bar be focusable when it's visible?

I don't believe we want to make the the progress bar keyboard focusable. You can't actually interact with it.

I think the info icon is a great place to get more info about what's going on behind the scenes, but over to sgabriel for design perspective.

It doesn't really makes sense from a design perspective to have a tooltip changing its label based on the status of another layout. 
The "i" icon is always network info so should be its description.

What does ChromeVox say when you focus the toggle? 
There seems to be no tooltip there but it must be saying something for ChromVox users right?

My proposal would be to append such text to say: 

"Off"
"On - Searching for WiFi-networks"
"On"

ChromeVox feedback for the toggle is "Wi-Fi, switch on" or "Wi-Fi, switch off" (the part before the comma matches the visible header so for Mobile Data it should be "Mobile Data, switch on", etc.). There's no tooltip on the toggle or on anything in the header row except the "new wifi" button, which is "Join other...". We could add the tooltip to the entire header row (instead of the info icon).

Why add a tooltip? 
Non-ChromeVox users know that it is looking for WiFi because we display the loader, no need of any other indication. I'm only suggesting we append the feedback text on the toggle with "Searching for WiFi-networks". 

> Non-ChromeVox users know that it is looking for WiFi because we display the loader, no need of any other indication.

Personally, I don't believe it is obvious what the loader is indicating. Most tooltips are "obvious" to certain people, e.g. the reload button says "Reload this page". Whoever added this tooltip originally for the other loading indicator also didn't believe it was obvious.

My guess is that it was implemented more for accessibility reason than anything else which is what we are aiming at fixing here. We should need a tooltip on a loader to tell you it's a loader. 

I agree. However this tooltip does more than tell you that it's a loader.

I still do not see it as a essential part of our visual UI. I trust that the loader will do the job of saying "We're looking for things to add in this subpanel"

If the context of the progress bar is obvious, I don't think we need this string at all, even for a11y, because the loader already indicates that it's a generic loader via ChromeVox.

If that's enough for accessibility. Then I'm all for it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5302a09f65c3e01387ba0397b766c7dda29119b4

commit 5302a09f65c3e01387ba0397b766c7dda29119b4
Author: estade <estade@chromium.org>
Date: Tue Apr 18 21:00:24 2017

Remove "Searching for Wi-Fi networks..." message.

Context is deemed to be enough to determine what the progress bar means.

BUG= 701740 

Review-Url: https://codereview.chromium.org/2820693005
Cr-Commit-Position: refs/heads/master@{#465370}

[modify] https://crrev.com/5302a09f65c3e01387ba0397b766c7dda29119b4/ash/system/network/network_state_list_detailed_view.cc

Chrome OS 9532.0.0, 60.0.3092.0