New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701737 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Dotted border is missing on tabbing when GTK+ theme is High Contrast

Project Member Reported by sc00335...@techmahindra.com, Mar 15 2017

Issue description

Chrome Version: 59.0.3042.0 dev
OS: Ubuntu 14.04

URL: https://apps.ubuntu.com/cat/applications/gnome-tweak-tool/

What steps will reproduce the problem?
(1)Add above tool
(2)Now open that tool and change GTK+ theme to High Contrast
(3)Launch chrome and bookmark any page by clicking star >> In that overlay hit tab and observe focus on buttons (or)

Go to extensions >> Click on Details link and observe tab and observe (or)

Hit Ctrl+Shift+d for bookmark all pages overlay >> tab and observe focus on buttons

Expected: Dotted highlight should be seen on all buttons when tabbed.
Actual: Instead highlight is seen missing.

This is a regression issue broken in M59.

Good Build: 59.0.3032.0 dev
Bad Build: 59.0.3033.0 dev

NOTE: Issue is not applicable to windows.
 
Expected_focus.png
147 KB View Download
Expected_2.png
129 KB View Download
Expected_1.png
143 KB View Download
Actual_1.png
146 KB View Download
Actual_2.png
132 KB View Download
Actual_dotted border.png
226 KB View Download

Comment 1 by ajha@chromium.org, Mar 15 2017

Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on the latest M-59(59.0.3042.0) on Linux Ubuntu 14.04. Worked fine on Windows-10,Mac OS 10.12.3 with High Contrast Extension as the extension doesn't affect Chrome dialogs.

Comment 2 by ajha@chromium.org, Mar 15 2017

Labels: -Needs-Bisect hasbisect-per-revision
Owner: thomasanderson@chromium.org
Status: Assigned (was: Untriaged)
Getting all the good builds while bisecting with hasbisect-per-revision. Manual good and bad looks incorrect.

Regressed in M-59.
==================
Last good build: 59.0.3035.0
First bad build: 59.0.3036.0

Changelog:
==========
https://chromium.googlesource.com/chromium/src/+log/caa6a6165d28c3bb499fc0aec9bf391c6bda1578..072522801041708fba94498a1844cb89f24d4590

thomasanderson@: Could this be WAI?




Status: Started (was: Assigned)
ajha@ Your bisect is correct, and this is a regression
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aa048d906db40cb8067e6e2d9393aca52f582d0

commit 8aa048d906db40cb8067e6e2d9393aca52f582d0
Author: thomasanderson <thomasanderson@google.com>
Date: Tue Mar 21 22:51:21 2017

Gtk3: Fix button outline sizing on different GTK minor versions

BUG= 701737 
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2765883003
Cr-Commit-Position: refs/heads/master@{#458591}

[modify] https://crrev.com/8aa048d906db40cb8067e6e2d9393aca52f582d0/chrome/browser/ui/libgtkui/gtk_ui.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aa048d906db40cb8067e6e2d9393aca52f582d0

commit 8aa048d906db40cb8067e6e2d9393aca52f582d0
Author: thomasanderson <thomasanderson@google.com>
Date: Tue Mar 21 22:51:21 2017

Gtk3: Fix button outline sizing on different GTK minor versions

BUG= 701737 
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2765883003
Cr-Commit-Position: refs/heads/master@{#458591}

[modify] https://crrev.com/8aa048d906db40cb8067e6e2d9393aca52f582d0/chrome/browser/ui/libgtkui/gtk_ui.cc

Status: Fixed (was: Started)
Labels: TE-Verified-59.0.3053.3 TE-Veriifed-M59
Tested the issue on Linux Ubuntu-14.04 using chrome version# 59.0.3053.3 with the steps mentioned in comment#0.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!

701737.mp4
1.2 MB View Download

Sign in to add a comment