New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701724 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-03-21
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue 729957



Sign in to add a comment

Heap-buffer-overflow in v8::internal::Simulator::DecodeType2

Project Member Reported by ClusterFuzz, Mar 15 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4887047853834240

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_v8_arm_dbg
Platform Id: linux

Crash Type: Heap-buffer-overflow WRITE 4
Crash Address: 0xd99ff7fc
Crash State:
  v8::internal::Simulator::DecodeType2
  v8::internal::Simulator::InstructionDecode
  v8::internal::Simulator::CallInternal
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: V8: 40662:40663

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv967IEgHiNdrjgZB_Lbj4Z3BqfCe13XoInG_x85bG1mnrqsx576TjK6qLa0csSz6Eb7mf8N3dgTxi3Fm9XY1a6FdVofgu2GuXO3MfGXagOj6NCemexZXzMBdC_SnzvOwz9_XO0v6h4by1MaWGGoX_3ZDvkTDtTOtiYYh4gLXrubozNKl20GgSP-hEXs4KI2IN94DvzdXMGZhhiHFLKHfNgsSDM9r_4OOxQfTFLGwvjrQP0ovwyj2kDdGVIX6heyv8qPjKIX2fYOLfFSXD3v845hS3fo1_gHtKj-FrupsToJux5X9QtjFpPuNr4ATkuhnjKiTAFq_th8cSb22a5jy24VoftZn7zljbs1NRZ307Hj6mcgAXUw?testcase_id=4887047853834240


Issue manually filed by: rossberg

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: mstarzinger@chromium.org
Owner: u...@chromium.org
Status: Assigned (was: Untriaged)
Another CF issue with the ARM simulator. Ulan, can you please have a look or close as you see fit?

Bisects only to Michi's older ship TF CL.
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 15 2017

Labels: M-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 15 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 15 2017

Labels: Pri-1
Cc: ligim...@chromium.org
 Issue 702137  has been merged into this issue.
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 16 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 17 2017

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
NextAction: 2017-03-21
This issue tagged as RBS. Please try to resolve ASAP preferably before next M58 Beta RC cut scheduled on 03/21 at 5.00 PM PST.

Comment 10 by u...@chromium.org, Mar 20 2017

Cc: u...@chromium.org
Owner: rossberg@chromium.org
Andreas, please assign to TF sheriffs. 
Cc: rossberg@chromium.org
Owner: mvstan...@chromium.org
Is simulator related stuff really a RB and has high impact?
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 29 2017

mvstanton: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Started (was: Assigned)
Hmm, we don't ship the simulator...will have a look though...
NextAction: 2017-04-10
A friendly reminder that M58 Stable launch is coming soon! Your bug is labelled as Stable ReleaseBlock, please make sure to land the fix, verified in trunk and get it merged into the release branch ASAP.
Labels: -Security_Impact-Beta -ReleaseBlock-Stable Security_Impact-None
NextAction: 2017-03-21
Yea, labels don't seem appropriate for sim issue. Fixing.
Blocking: 729957
Labels: -Security_Impact-None ReleaseBlock-Stable Security_Impact-Beta
Simluator just gives us better stack and instrumentation. Why do you think this is simulator specific. Bringing back security labels.
Project Member

Comment 18 by sheriffbot@chromium.org, Jun 10 2017

Labels: -M-58 -Security_Impact-Beta Security_Impact-Stable M-59
Project Member

Comment 19 by sheriffbot@chromium.org, Jun 10 2017

Labels: Deadline-Exceeded
We commit ourselves to a 60 day deadline for fixing for high severity vulnerabilities, and have exceeded it here. If you're unable to look into this soon, could you please find another owner or remove yourself so that this gets back into the security triage queue?

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Security_Impact-Stable -Security_Severity-High -ReleaseBlock-Stable
It's just a simulator issue, I'll remove the blockers.
Labels: -Deadline-Exceeded
Cc: danno@chromium.org
 mvstanton@, did you see c#17, can you explain why is this a simulator only issue  and not manifest in production ?
Labels: Security_Impact-Stable Security_Severity-High
Re-adding security labels since we don't know why this issue won't manifest in production.
Project Member

Comment 24 by sheriffbot@chromium.org, Jul 22 2017

Labels: Deadline-Exceeded
We commit ourselves to a 60 day deadline for fixing for high severity vulnerabilities, and have exceeded it here. If you're unable to look into this soon, could you please find another owner or remove yourself so that this gets back into the security triage queue?

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 25 by sheriffbot@chromium.org, Jul 26 2017

Labels: -M-59 M-60
Project Member

Comment 26 by ClusterFuzz, Aug 11 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 4887047853834240 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 27 by sheriffbot@chromium.org, Aug 11 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 28 by sheriffbot@chromium.org, Aug 13 2017

Labels: Merge-Request-61
Project Member

Comment 29 by sheriffbot@chromium.org, Aug 13 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ for M61 merge review.
Cc: rmcilroy@chromium.org
hi mvstanton@, rmcilroy@ - it looks like this was fixed by https://chromium.googlesource.com/v8/v8/+/961a2c885d82502e7c90915883443435d27762d0 - what are your thoughts on an M61 merge for that?
No we don't want to merge that CL to M61 - that removes the ability to revert back to the full-codegen compiler during m61 using finch in case we find a blocking error on the new asm.js verifier.

I can't see the test case, however if the test case manually disables the new asm.js verifier (which is suggested by the fact that 961a2c fixes it) then that is another reason why this won't happen in production (as well as it being a simulator bug).
As multiple people have pointed out before, the bug being a simulator bug does *not* mean it does not manifest in production.

I can't view the testcase either to check if it disables any thing manually, I get "Invalid testcase" for the link.
Cc: mvstan...@chromium.org
Owner: rmcilroy@chromium.org
rmcilroy@, i have assigned you as owner, now you should able to see the report. Please check it out as we need to use your input to make the reward decision. Thanks!
I'm still getting access denied when visiting https://clusterfuzz.com/testcase?key=4887047853834240 with either my google or chromium account. 
I'm still getting access denied when visiting https://clusterfuzz.com/testcase?key=4887047853834240 with either my google or chromium account. 
Labels: -Hotlist-Merge-Review -M-60 -Merge-Review-61 M-62
Can you try signing in an incognito window with just your chromium account. i think we have seen trouble with multi-sign in before.
I still get "You (email=rmcilroy@chromium.org) are not authorized to access this page!" even from an incognito window.
Labels: -reward-topanel reward-0
The VRP Panel took a look and concluded that this is indeed mostly likely a simulator only bug.

inferno@ - could you another look at the clusterfuzz access problem rmcilroy@ still seems to be having?

mvstanton@, rmcilroy@ et al - when you note that a bug is simulator only, could you also provide a few more details as to why you think that?  Will help us security folk learn to triage them better over time.  Thanks!
Labels: -Security_Impact-Stable Security_Impact-None
Project Member

Comment 42 by sheriffbot@chromium.org, Nov 17 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment