New issue
Advanced search Search tips

Issue 701722 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

content_shell crashes upon invocation

Project Member Reported by neis@chromium.org, Mar 15 2017

Issue description

Since 662c24fc6debb33ee34a927d21dc26154b8973d6, content_shell no longer works for me - it crashes right away.  Chrome itself seems fine.

For instance, I just made a release and a debug build on 2100813cb0c0d18a87434921433fda24d04cda16.


With the release build, running content_shell immediately aborts as follows:

X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  42 (X_SetInputFocus)
  Serial number of failed request:  208
  Current serial number in output stream:  209
[1:1:0100/000000.321057:90377804552:ERROR:broker_posix.cc(41)] Invalid node channel message


With the debug build, a window seems to open but then it crashes as follows:

[20831:20831:0315/115953.973827:90449454205:FATAL:desktop_window_tree_host_x11.cc(836)] Check failed: !is_active || window_mapped_in_server_. 
#0 0x0000036c710b base::debug::StackTrace::StackTrace()
#1 0x0000036c5cec base::debug::StackTrace::StackTrace()
#2 0x00000370fb1f logging::LogMessage::~LogMessage()
#3 0x000009164352 views::DesktopWindowTreeHostX11::IsActive()
#4 0x000009160428 views::DesktopWindowTreeHostX11::AfterActivationStateChanged()
#5 0x0000091641c5 views::DesktopWindowTreeHostX11::Activate()
#6 0x0000091df399 views::DesktopNativeWidgetAura::Activate()
#7 0x00000913316d views::Widget::Activate()
#8 0x0000090e3458 views::FocusManager::SetFocusedViewWithReason()
#9 0x0000090caca2 views::FocusManager::SetFocusedView()
#10 0x00000911b6be views::View::RequestFocus()
#11 0x000009202ab7 views::WebView::OnWebContentsFocused()
#12 0x000003017764 content::WebContentsImpl::NotifyWebContentsFocused()
#13 0x00000304fbbc content::WebContentsViewAura::GotFocus()
#14 0x000002d04cc5 content::RenderViewHostImpl::RenderWidgetGotFocus()
#15 0x000002d185ea content::RenderWidgetHostImpl::GotFocus()
#16 0x000002d4b8e4 content::RenderWidgetHostViewAura::OnWindowFocused()
#17 0x00000aa511a7 wm::FocusController::SetFocusedWindow()
#18 0x00000aa50a35 wm::FocusController::FocusAndActivateWindow()
#19 0x00000aa50681 wm::FocusController::FocusWindow()
#20 0x000005b545ab aura::Window::Focus()
#21 0x000002d46e12 content::RenderWidgetHostViewAura::Focus()
#22 0x00000304e6f0 content::WebContentsViewAura::Focus()
#23 0x00000301e31d content::WebContentsImpl::Focus()
#24 0x000003612596 content::Shell::LoadURLForFrame()
#25 0x0000036124ad content::Shell::LoadURL()
#26 0x000003612426 content::Shell::CreateNewWindow()
#27 0x00000365c38d content::ShellBrowserMainParts::InitializeMessageLoopContext()
#28 0x00000365c684 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#29 0x0000023fefb1 content::BrowserMainLoop::PreMainMessageLoopRun()
#30 0x0000007b3675 _ZN4base8internal13FunctorTraitsIMN7content12LinuxSandboxEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#31 0x0000007b3591 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7content12LinuxSandboxEFvvEJPS5_EEEvOT_DpOT0_
#32 0x00000240a577 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#33 0x00000240a4bc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#34 0x00000078192b base::internal::RunMixin<>::Run()
#35 0x000002f9674b content::StartupTaskRunner::RunAllTasksNow()
#36 0x0000023fcb80 content::BrowserMainLoop::CreateStartupTasks()
#37 0x00000240db57 content::BrowserMainRunnerImpl::Initialize()
#38 0x0000036167f4 ShellBrowserMain()
#39 0x0000035f74b5 content::ShellMainDelegate::RunProcess()
#40 0x0000021721db content::RunNamedProcessTypeMain()
#41 0x000002174adc content::ContentMainRunnerImpl::Run()
#42 0x00000120c9f2 content::ContentMain()
#43 0x0000005571e1 main
#44 0x7fcfc2e30f45 __libc_start_main
#45 0x0000005570b5 <unknown>

Received signal 6
#0 0x0000036c710b base::debug::StackTrace::StackTrace()
#1 0x0000036c5cec base::debug::StackTrace::StackTrace()
#2 0x0000036c6c1f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7fcfc7d32330 <unknown>
#4 0x7fcfc2e45c37 gsignal
#5 0x7fcfc2e49028 abort
#6 0x0000036c5c16 base::debug::(anonymous namespace)::DebugBreak()
#7 0x0000036c5bf8 base::debug::BreakDebugger()
#8 0x00000370feb6 logging::LogMessage::~LogMessage()
#9 0x000009164352 views::DesktopWindowTreeHostX11::IsActive()
#10 0x000009160428 views::DesktopWindowTreeHostX11::AfterActivationStateChanged()
#11 0x0000091641c5 views::DesktopWindowTreeHostX11::Activate()
#12 0x0000091df399 views::DesktopNativeWidgetAura::Activate()
#13 0x00000913316d views::Widget::Activate()
#14 0x0000090e3458 views::FocusManager::SetFocusedViewWithReason()
#15 0x0000090caca2 views::FocusManager::SetFocusedView()
#16 0x00000911b6be views::View::RequestFocus()
#17 0x000009202ab7 views::WebView::OnWebContentsFocused()
#18 0x000003017764 content::WebContentsImpl::NotifyWebContentsFocused()
#19 0x00000304fbbc content::WebContentsViewAura::GotFocus()
#20 0x000002d04cc5 content::RenderViewHostImpl::RenderWidgetGotFocus()
#21 0x000002d185ea content::RenderWidgetHostImpl::GotFocus()
#22 0x000002d4b8e4 content::RenderWidgetHostViewAura::OnWindowFocused()
#23 0x00000aa511a7 wm::FocusController::SetFocusedWindow()
#24 0x00000aa50a35 wm::FocusController::FocusAndActivateWindow()
#25 0x00000aa50681 wm::FocusController::FocusWindow()
#26 0x000005b545ab aura::Window::Focus()
#27 0x000002d46e12 content::RenderWidgetHostViewAura::Focus()
#28 0x00000304e6f0 content::WebContentsViewAura::Focus()
#29 0x00000301e31d content::WebContentsImpl::Focus()
#30 0x000003612596 content::Shell::LoadURLForFrame()
#31 0x0000036124ad content::Shell::LoadURL()
#32 0x000003612426 content::Shell::CreateNewWindow()
#33 0x00000365c38d content::ShellBrowserMainParts::InitializeMessageLoopContext()
#34 0x00000365c684 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#35 0x0000023fefb1 content::BrowserMainLoop::PreMainMessageLoopRun()
#36 0x0000007b3675 _ZN4base8internal13FunctorTraitsIMN7content12LinuxSandboxEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#37 0x0000007b3591 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7content12LinuxSandboxEFvvEJPS5_EEEvOT_DpOT0_
#38 0x00000240a577 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#39 0x00000240a4bc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#40 0x00000078192b base::internal::RunMixin<>::Run()
#41 0x000002f9674b content::StartupTaskRunner::RunAllTasksNow()
#42 0x0000023fcb80 content::BrowserMainLoop::CreateStartupTasks()
#43 0x00000240db57 content::BrowserMainRunnerImpl::Initialize()
#44 0x0000036167f4 ShellBrowserMain()
#45 0x0000035f74b5 content::ShellMainDelegate::RunProcess()
#46 0x0000021721db content::RunNamedProcessTypeMain()
#47 0x000002174adc content::ContentMainRunnerImpl::Run()
#48 0x00000120c9f2 content::ContentMain()
#49 0x0000005571e1 main
#50 0x7fcfc2e30f45 __libc_start_main
#51 0x0000005570b5 <unknown>
  r8: 00007ffe9640e500  r9: 00007fcfc2f5fa00 r10: 0000000000000008 r11: 0000000000000206
 r12: 000000000055708c r13: 00007ffe96411c60 r14: 0000000000000000 r15: 0000000000000000
  di: 000000000000515f  si: 000000000000515f  bp: 00007ffe9640e910  bx: 0000000000000000
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007ffe9640e7d8
  ip: 00007fcfc2e45c37 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.
[1:1:0100/000000.889231:90451370110:ERROR:broker_posix.cc(41)] Invalid node channel message


This is on Goobuntu running the xmonad window manager.
 
Labels: -Pri-3 Pri-2
I've seen this in try jobs today:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_rel_ng%2F409471%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests__with_patch_%2F0%2Flogs%2FContinueWhereILeftOffTest.Post%2F0

[4210:4210:0315/121129.026536:FATAL:desktop_window_tree_host_x11.cc(836)] Check failed: !is_active || window_mapped_in_server_.
#0 0x000002e39df7 base::debug::StackTrace::StackTrace()
#1 0x000002e5281b logging::LogMessage::~LogMessage()
#2 0x000003dc2625 views::DesktopWindowTreeHostX11::IsActive()
#3 0x000003dbf7df views::DesktopWindowTreeHostX11::AfterActivationStateChanged()
#4 0x000003dc24c1 views::DesktopWindowTreeHostX11::Activate()
#5 0x00000316bd91 (anonymous namespace)::SessionRestoreImpl::ProcessSessionWindowsAndNotify()
#6 0x00000316a6de SessionRestore::RestoreSession()
#7 0x00000538ab5a StartupBrowserCreatorImpl::RestoreOrCreateBrowser()
#8 0x000005389874 StartupBrowserCreatorImpl::ProcessLaunchUrlsUsingConsolidatedFlow()
#9 0x000005389131 StartupBrowserCreatorImpl::Launch()
#10 0x000005386a55 StartupBrowserCreator::LaunchBrowser()
#11 0x00000538635f StartupBrowserCreator::ProcessCmdLineImpl()
#12 0x000005385897 StartupBrowserCreator::Start()
#13 0x000003353044 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#14 0x000003351fd1 ChromeBrowserMainParts::PreMainMessageLoopRun()
#15 0x000001aa9b95 content::BrowserMainLoop::PreMainMessageLoopRun()
#16 0x000001e98aa6 content::StartupTaskRunner::RunAllTasksNow()
#17 0x000001aa7a2b content::BrowserMainLoop::CreateStartupTasks()
#18 0x000001aad88e content::BrowserMainRunnerImpl::Initialize()
#19 0x000001aa4ea8 content::BrowserMain()
#20 0x000002e173c3 content::RunNamedProcessTypeMain()
#21 0x000002e180d6 content::ContentMainRunnerImpl::Run()
#22 0x000002e16760 content::ContentMain()
#23 0x00000352b610 content::BrowserTestBase::SetUp()
#24 0x000002f118b1 InProcessBrowserTest::SetUp()
#25 0x000003d023ae testing::Test::Run()

Cc: -thomasanderson@google.com
Owner: thomasanderson@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150

commit 9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150
Author: thomasanderson <thomasanderson@google.com>
Date: Fri Mar 17 19:45:27 2017

X11: Fix test flakes related to window focus

This CL removes code intended to fix "some tests depending on a window
being IsActive() immediately after an Activate()".  After
https://codereview.chromium.org/2630773002, all of these cases should
be using WidgetActivationWaiter, so this is unnecessary.  This was
causing DCHECK(!is_active || window_mapped_in_server_) to fail.

In addition, XSetInputFocus on an unmapped window will fail, so
supress the error in this case.  This is the same thing GTK does
https://github.com/GNOME/gtk/blob/7ade6e3f4668220f0fa1382944a87e63691ad9ad/gdk/x11/gdkwindow-x11.c#L1904

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
BUG= 701722 , 701921 , 701706 , 701485 , 701484 , 700692 , 700683 , 700661 , 701886 
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2756183003
Cr-Commit-Position: refs/heads/master@{#457859}

[modify] https://crrev.com/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Status: Fixed (was: Started)

Sign in to add a comment