New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701700 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Camera icon is seen disappeared on clicking camera icon or any thumbnail image on choose a picture overlay

Project Member Reported by sandeepkumars@chromium.org, Mar 15 2017

Issue description

Chrome Version: 59.0.3040.0/9367.0.0 dev-channel Daisy, Candy, Minnie
OS: Chrome

What steps will reproduce the problem?
(1)Recover OS via USB>> sign in to User>> wait till the choose a picture overlay opens>> click on camera icon or any thumbnail image>> and observe

Expected: On clicking camera icon or any thumbnail image, camera icon should not be disappeared
Actual: Instead camera icon is seen disappeared on clicking camera icon or any thumbnail image

This is a Regression issue as such issue is not seen in M57: 	57.0.2987.93/9202.49.0 dev-channel Daisy

Issue is not applicable to Linux and Windows

 
Actual-choose a picture overlay.MOV
569 KB Download
Owner: tbuck...@chromium.org
Status: Assigned (was: Untriaged)
@tbuckley: Please confirm the behavior
Owner: zalcorn@chromium.org
Yep, this seems like a bug.
Cc: st...@chromium.org tbuck...@chromium.org
Owner: alemate@chromium.org
alemate@ could you take a look?
tbuckley@, should we be moving this to the new MD settings version in M59?
Issue is still seen in 59.0.3049.0/9395.0.0 dev channel Samus, Daisy, Minnie
Cc: tbarzic@chromium.org
Status: Started (was: Assigned)
Cc: -st...@chromium.org r...@chromium.org
I did a lot of debugging and suspect https://codereview.chromium.org/2696703006 to be blamed.

I created a CL with fix: https://codereview.chromium.org/2779463002/
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/206c4eb900a3221d9abaf5904ddcb672453cfd6b

commit 206c4eb900a3221d9abaf5904ddcb672453cfd6b
Author: alemate <alemate@chromium.org>
Date: Thu Mar 30 03:55:44 2017

Chrome OS: Fix taking user pictures to be used as user POD images.

This CL fixes taking camera photos when creating new user.
This has been broken since  https://crbug.com/596786  .

BUG= 701700 

Review-Url: https://codereview.chromium.org/2779463002
Cr-Commit-Position: refs/heads/master@{#460654}

[modify] https://crrev.com/206c4eb900a3221d9abaf5904ddcb672453cfd6b/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/206c4eb900a3221d9abaf5904ddcb672453cfd6b/chrome/browser/media/webrtc/media_permission.cc

Labels: -M-59 Merge-Request-58 M-58
Status: Fixed (was: Started)
Project Member

Comment 10 by sheriffbot@chromium.org, Mar 31 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 31 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba56d360e1968a90eac70c2dd866220618ea665d

commit ba56d360e1968a90eac70c2dd866220618ea665d
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Mar 31 04:15:37 2017

Chrome OS: Fix taking user pictures to be used as user POD images.

This CL fixes taking camera photos when creating new user.
This has been broken since  https://crbug.com/596786  .

BUG= 701700 

Review-Url: https://codereview.chromium.org/2779463002
Cr-Commit-Position: refs/heads/master@{#460654}
(cherry picked from commit 206c4eb900a3221d9abaf5904ddcb672453cfd6b)

Review-Url: https://codereview.chromium.org/2787283002 .
Cr-Commit-Position: refs/branch-heads/3029@{#506}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/ba56d360e1968a90eac70c2dd866220618ea665d/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/ba56d360e1968a90eac70c2dd866220618ea665d/chrome/browser/media/webrtc/media_permission.cc

Status: Verified (was: Fixed)
9334.33.0 / 58.0.3029.51

Sign in to add a comment