Issue metadata
Sign in to add a comment
|
webkit_tests (.../window-synthetic-errorevent.html) failing on chromium.webkit/WebKit Linux Trusty Leak |
||||||||||||||||||||
Issue descriptionwebkit_tests failing on chromium.webkit/WebKit Linux Trusty Leak Builders failed on: - WebKit Linux Trusty Leak: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak external/wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/window-synthetic-errorevent.html is failing. https://chromium.googlesource.com/chromium/src/+/b8a31c8731d21407c7db6a8a5a9bf01ace20ab5f seems to be the culprit CL.
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a8dda52afa9518898222bf0781add1243e2a33e commit 3a8dda52afa9518898222bf0781add1243e2a33e Author: qyearsley <qyearsley@chromium.org> Date: Wed Mar 15 23:14:01 2017 Add leak expectation for external/wpt/.../window-synthetic-errorevent.html. BUG= 701695 Review-Url: https://codereview.chromium.org/2749413002 Cr-Commit-Position: refs/heads/master@{#457256} [modify] https://crrev.com/3a8dda52afa9518898222bf0781add1243e2a33e/third_party/WebKit/LayoutTests/LeakExpectations
,
Mar 16 2017
Expected to be actually fixed when bug 501866 is fixed.
,
Jun 5 2017
Minimized the leaking test:
<!DOCTYPE html>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
setup({ allow_uncaught_exception: true });
promise_test(t => {
const eventWatcher = new EventWatcher(t, window, "error");
const promise = eventWatcher.wait_for("error");
window.dispatchEvent(new ErrorEvent("error", {
error: { the: "error object" }
}));
return promise;
}, "foo");
</script>
,
Jun 8 2017
Further minimized test:
<!DOCTYPE html>
<script>
var r = null;
window.addEventListener("error", (e) => {
r(e);
});
new Promise((resolve) => {
r = resolve;
});
window.dispatchEvent(new ErrorEvent("error", {
error: {}
}));
</script>
,
Jun 8 2017
,
Jun 8 2017
tasak@ is now investigating
,
Jun 8 2017
https://chromium-review.googlesource.com/c/489908/ will fix this problem
,
Jun 8 2017
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f61c09fb2b62a73f36eac10eb873690b00810b9 commit 8f61c09fb2b62a73f36eac10eb873690b00810b9 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Mon Jun 12 03:50:37 2017 Use wrapper tracing in ErrorEvent Having ScriptValue in ErrorEvent creates a cycle reference between blink and v8 and causes memory leak. Fix it by using wrapper tracing. BUG= 701695 ,501866 Change-Id: I3235bc52f95e9fb54ab37e234269ffe5374f10c6 Reviewed-on: https://chromium-review.googlesource.com/527547 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#478546} [modify] https://crrev.com/8f61c09fb2b62a73f36eac10eb873690b00810b9/third_party/WebKit/LayoutTests/LeakExpectations [modify] https://crrev.com/8f61c09fb2b62a73f36eac10eb873690b00810b9/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp [modify] https://crrev.com/8f61c09fb2b62a73f36eac10eb873690b00810b9/third_party/WebKit/Source/core/events/ErrorEvent.cpp [modify] https://crrev.com/8f61c09fb2b62a73f36eac10eb873690b00810b9/third_party/WebKit/Source/core/events/ErrorEvent.h [modify] https://crrev.com/8f61c09fb2b62a73f36eac10eb873690b00810b9/third_party/WebKit/Source/core/events/ErrorEvent.idl
,
Jun 12 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by qyears...@chromium.org
, Mar 15 2017