New issue
Advanced search Search tips

Issue 701675 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: ----
Type: ----



Sign in to add a comment

webkit_tests failing on 2 builders

Project Member Reported by tzik@chromium.org, Mar 15 2017 
webkit_tests failing on 2 builders

Builders failed on: 
- WebKit Mac10.11 (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29
- WebKit Mac10.11 (retina): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29

A layout test is failing due to a GPU process crash:
fast/shapedetection/shapedetection-security-test.html
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/13420
crash log for gpu (pid <unknown>):
STDOUT: #CRASHED - gpu
STDERR: Received signal 11 SEGV_MAPERR 000000000000
STDERR:  [0x000107d5742c]
STDERR:  [0x000107d57321]
STDERR:  [0x7fff96b7452a]
STDERR:  [0x000000000000]
STDERR:  [0x7fff9f7e4d51]
STDERR:  [0x7fff9f6930f9]
STDERR:  [0x7fff9f68e589]

https://codereview.chromium.org/2739163003 looks suspicious to me.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886e0b3390e48ca2dd0a361b9e27b84e73b0acc4

commit 886e0b3390e48ca2dd0a361b9e27b84e73b0acc4
Author: tzik <tzik@chromium.org>
Date: Wed Mar 15 08:40:50 2017

Revert of Shape Detection: move the Mac service to the sandboxed GPU process (patchset #1 id:20001 of https://codereview.chromium.org/2739163003/ )

Reason for revert:
fast/shapedetection/shapedetection-security-test.html seems to get flaky due to this CL on mac bots.

BUG= 701675 

Original issue's description:
> Shape Detection: move the Mac service to the sandboxed GPU process
>
> ShapeDetection in Mac uses privileged and potentially dangerous APIs
> inside CoreImage and perhaps more, transitively.  This CL moves the
> shape detection service to run in the GPU process, which is sandboxed.
>
> The reason for using the GPU process is that CoreImage APIs seem
> to depend strongly and mysteriously on the GPU, as I learned while
> trying to get the unittests to work [1] in our normal mac bots (which
> are virtual machines and have no GPU).  I tried using a sw rendering
> context and a coupe of other circumventions but nothing really worked.
>
> [1] early PSs in https://codereview.chromium.org/2677553003/
>
> BUG= 666143 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2739163003
> Cr-Commit-Position: refs/heads/master@{#456555}
> Committed: https://chromium.googlesource.com/chromium/src/+/95d98937e0fb0baf11d7c3088a99bb20a58e32cf

TBR=rockot@chromium.org,kbr@chromium.org,rsesek@chromium.org,mcasas@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 666143 

Review-Url: https://codereview.chromium.org/2749213002
Cr-Commit-Position: refs/heads/master@{#457035}

[modify] https://crrev.com/886e0b3390e48ca2dd0a361b9e27b84e73b0acc4/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/886e0b3390e48ca2dd0a361b9e27b84e73b0acc4/content/gpu/BUILD.gn
[modify] https://crrev.com/886e0b3390e48ca2dd0a361b9e27b84e73b0acc4/content/gpu/DEPS
[modify] https://crrev.com/886e0b3390e48ca2dd0a361b9e27b84e73b0acc4/content/gpu/gpu_service_factory.cc

Comment 2 by mcasas@chromium.org, Mar 16 2017

Status: Fixed (was: Available)
►

Sign in to add a comment