Issue 700437  has been merged into this issue.

 Issue 700968  has been merged into this issue.

Issue 693773 has been merged into this issue.

Please copy the evtest output here so folks can see that the problem is at kernel level or below.

Any idea Dmitry?  This is on kernel 3.8.  No recent EC changes, apparently.

Any changes in firmware? 3.8 x86 device would use i8042 + AT keyboard, pretty standard setup.

I just tried Peppy (same generation x86) and search key generates KEY_LEFTMETA, as it should. I also see the search bar/app list being shown when I press it. What keycode do you see on Falco?

IIRC we were seeing KEY_SEARCH but I am not sure.

I have a Falco that i didn't update since 53. It reports KEY_LEFTMETA.

https://feedback.corp.google.com/#/Report/55165577752

Will run the update now, probably to 56. Let's see if it changes...

#9 — weidongg@ saw 0xD9 KEY_SEARCH on the userspace read from evdev, which is consistent with the reported behaviour. It should be KEY_LEFTMETA (for which Chrome brings up the search box on release only if it hasn't been used as a modifier). KEY_SEARCH certainly has the appearance of being a deliberate choice due to a misunderstanding or miscommunication somewhere.

@bleung I traced back to the first version of chromeos that goes wrong, which is 9182.0.0 following three broken versions. I guess something went wrong in these three broke versions. 

#14 wonderful.  I started looking at changes between 9178 and 9182 but nothing stands out.  Can you confirm that the problem didn't exist in 9178?

Heh, it comes from updated udev. The upstream linux wants this key to be KEY_SEARCH, so it is overridden via /lib/udev/hwdb.d/60-keyboard.hwdb, along with bunch other keys:

evdev:atkbd:dmi:bvn*:bvr*:bd*:svnHewlett-Packard*:pnFalco:pvr*
 KEYBOARD_KEY_3b=back
 KEYBOARD_KEY_3c=forward
 KEYBOARD_KEY_3d=refresh
 KEYBOARD_KEY_3f=switchvideomode
 KEYBOARD_KEY_40=brightnessdown
 KEYBOARD_KEY_41=brightnessup
 KEYBOARD_KEY_42=mute
 KEYBOARD_KEY_43=volumedown
 KEYBOARD_KEY_44=volumeup
 KEYBOARD_KEY_db=search # Same position as caps lock key on most keyboards
 # KEYBOARD_KEY_3e=fullscreen, no defined key sym

We should probably inspect it, and other rules we import, for other unwanted changes.

@weidongg:

I think for keyboard fix you'll need to adjust src/third_party/chromiumos-overlay/sys-apps/hwids/hwids-20150717.ebuild::src_prepare() and have an awk(?) script parse udev/60-keyboard.hwdb and drop all entries for "evdev:atkbd:" as we will never want to adjust behavior of internal keyboards (but we do not want to drop 60-keyboard.hwdb completely as it has some useful entries for external USB keyboards).

#15, @semenzato Yes, I did evtest on 9178, the key reports KEY_LEFTMETA.

Something like:

awk '
BEGIN { atkbd = 0 }
(/^evdev:atkbd/) { atkbd = 1; print "#" $0; next }
(!/^ /) { atkbd = 0 }
{ if (atkbd) printf "# "; print $0 }'
udev/60-keyboard.hwdb > udev/60-keyboard-clean.hwdb

if you want to simply comment out entries; or

awk '
BEGIN { atkbd = 0 }
(/^evdev:atkbd/) { atkbd = 1; next }
(!/^ /) { atkbd = 0 }
{ if (!atkbd) print }'
udev/60-keyboard.hwdb > udev/60-keyboard-clean.hwdb

if you want to remove them from the file.

At this point, I don't think that weidongg is the right owner of this bug. bleung@ Can you please help us triage this bug?

I think Ben was looking at udev. Ben, should you take this?

 Issue 697387  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/243bdce86f98a97de804b7e5636d89629f04794c

commit 243bdce86f98a97de804b7e5636d89629f04794c
Author: Ben Chan <benchan@chromium.org>
Date: Sat Mar 25 04:28:42 2017

sys-apps/hwids: filter out key mappings for Falco internal keyboard

This CL patches udev/60-keyboard.hwdb to filter out key mappings for the
AT keyboards in order to avoid potential conflicts with the key mappings
expected by Chrome OS for the internal keyboard of a Chromebook.

BUG= chromium:701643 
TEST=Manually test search-based keyboard shortcuts on Falco.

Change-Id: If2cf9aeeded95dbc2219e042fd8076c8a96ff983
Reviewed-on: https://chromium-review.googlesource.com/457146
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/243bdce86f98a97de804b7e5636d89629f04794c/sys-apps/hwids/hwids-20150717.ebuild
[rename] https://crrev.com/243bdce86f98a97de804b7e5636d89629f04794c/sys-apps/hwids/hwids-20150717-r2.ebuild

 Issue 690293  has been merged into this issue.

 Issue 706822  has been merged into this issue.

Can we merge this to M58?

Merge request for 58.

 Issue 705258  has been merged into this issue.

 Issue 705034  has been merged into this issue.

There are reports of this on 57 now as well. 

I know it's late in the game for 57, but this is pretty bad.

Chatted with Albert. Rolling back existing deployment of stable for Falco. Approving merge to M57. We will create a new build with the fix and deploy to Falco users.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2e12583385d623379bd63d05d5104dbad40e9f07

commit 2e12583385d623379bd63d05d5104dbad40e9f07
Author: Ben Chan <benchan@chromium.org>
Date: Thu Apr 06 06:00:08 2017

sys-apps/hwids: filter out key mappings for Falco internal keyboard

This CL patches udev/60-keyboard.hwdb to filter out key mappings for the
AT keyboards in order to avoid potential conflicts with the key mappings
expected by Chrome OS for the internal keyboard of a Chromebook.

BUG= chromium:701643 
TEST=Manually test search-based keyboard shortcuts on Falco.

Change-Id: If2cf9aeeded95dbc2219e042fd8076c8a96ff983
Reviewed-on: https://chromium-review.googlesource.com/457146
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 243bdce86f98a97de804b7e5636d89629f04794c)
Reviewed-on: https://chromium-review.googlesource.com/469074
Trybot-Ready: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/2e12583385d623379bd63d05d5104dbad40e9f07/sys-apps/hwids/hwids-20150717.ebuild
[rename] https://crrev.com/2e12583385d623379bd63d05d5104dbad40e9f07/sys-apps/hwids/hwids-20150717-r2.ebuild

 Issue 709255  has been merged into this issue.

Verified on M57 build 9202.66.0

Verified  Issue 709255  that's been merged here on M57 build 9202.66.0

the bug is still there with 58.0.3029.51 beta version

Re: #41: The fix was committed to Chrome 58.0.3029.55 / Chrome OS 9334.36.0, so 58.0.3029.51 is still affected.

 Issue 709861  has been merged into this issue.

 Issue 709548  has been merged into this issue.

 Issue 711620  has been merged into this issue.

I saw some report cannot take screen shot by "CTRL+SWITCH".
The affected versions are:
1. Submitted on: 2017-04-18 10:27 UTC
CHROME VERSION	57.0.2987.146
CHROMEOS_RELEASE_BOARD	falco_li-signed-mp-v3keys
CHROMEOS_RELEASE_DESCRIPTION	9202.64.0 (Official Build) stable-channel falco_li

2. Submitted on: 2017-04-17 18:42 UTC
CHROME VERSION	57.0.2987.137
CHROMEOS_RELEASE_BOARD	falco-signed-mp-v3keys
CHROMEOS_RELEASE_DESCRIPTION	9202.60.0 (Official Build) stable-channel falco

3. Submitted on: 2017-04-06 21:57 UTC
CHROME VERSION	57.0.2987.123
CHROMEOS_RELEASE_BOARD	falco-signed-mp-v3keys
CHROMEOS_RELEASE_DESCRIPTION	9202.56.1 (Official Build) stable-channel falco

 Issue 712709  has been merged into this issue.

 Issue 710978  has been merged into this issue.