New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701637 link

Starred by 22 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

[Feedback M57] - Middle-Clicking a hover dropdown menu hides it

Project Member Reported by jainabhi...@chromium.org, Mar 15 2017

Issue description

Chrome Version: 57.0.2987.98
OS: Linux: 4.9.13-201.fc25.x86_64

What steps will reproduce the problem?
(1) Visit ubuntu.com
(2) Hover on Download menu
(3) click on Desktop menu item

What is the expected result?
opens desktop page

What happens instead?
closes the menu and does nothing

Another report
When I middle-click a link in a hover dropdown menu chrome should open link in a new tab.
Example URL : https://www.w3schools.com/howto/howto_css_dropdown.asp

It worked fine on previous versions, but now it just hides the dropdown menu.
Issue happens on all sites with on-hover menus.

Forum : https://productforums.google.com/forum/#!topic/chrome/i75GCmFU94o
 

Comment 1 by gov...@chromium.org, Mar 15 2017

Cc: ranjitkan@chromium.org pbomm...@chromium.org

Comment 2 by tkent@chromium.org, Mar 15 2017

Components: -Blink>DOM>Events Blink>DOM
Remove Blink>DOM>Events

Comment 3 by kochi@chromium.org, Mar 15 2017

I'm not able to reproduce this on Linux, 57.0.2987.98 stable or latest
developer build (59.0.3042.0).  Middle-clicking on hover menu opens
the link in a new tab.

Can you reproduce the case in 57.0.2987.98 (the reported version in the original
report)?  Is Firefox (if available) working properly against middle-click?
Cc: gov...@chromium.org
Labels: ReleaseBlock-Stable M-57
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on Ubuntu 14.04 and is broken in M57, below is the bisect details obtained using per revision bisect

Bisect Change:
==============
https://chromium.googlesource.com/chromium/src/+log/7223079dda8d234c24aed43d249bf27ece1e30ba..3963e231e4c43187a05f3c6420f5df997d734ea0

Change Log:
===========
https://chromium.googlesource.com/chromium/src/+/3963e231e4c43187a05f3c6420f5df997d734ea0

@dtapuska: Request you to please take a look into it. Please help us to find an owner if not with respect to your change. 

Note: Issue is not observed on Windows and MAC OS.

Thanks.!
Labels: -ReleaseBlock-Stable
I don't think this is a serious issue. I have a fix I'm working on we should be able to get it into M58 I think.

Comment 7 by tkent@chromium.org, Mar 16 2017

Components: -Blink>DOM Blink>Input
Labels: -M-57 M-59
Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/955f4364ffa5c275f04cb3c2d19f7ac63f7d8320

commit 955f4364ffa5c275f04cb3c2d19f7ac63f7d8320
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Mar 16 13:05:54 2017

Treat NotifyVirtual events as mouse move events for blink.

This restores the old logic we had for blink to deal with these as mouse
move events but keeping the mouseleave events when we leave the window.

NotifyInferior messages are already dropped at the X11 desktop tree
host but I didn't want to risk breaking any views with addressing this
release block stable issue.

BUG= 701637 , 450631 , 240300 , 352106 , 386896 , 569998 , 575208 

Review-Url: https://codereview.chromium.org/2751833006
Cr-Commit-Position: refs/heads/master@{#457411}

[modify] https://crrev.com/955f4364ffa5c275f04cb3c2d19f7ac63f7d8320/ui/events/blink/web_input_event.cc

 Issue 702250  has been merged into this issue.
Labels: -M-59 M-58
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Tested this issue on Linux Ubuntu-14.04 using chrome dev version-59.0.3044.0 & observed below:
1. After executing steps (1,2,3) -desktop page opened in a new tab.

2.As per the below statements:
" Another report:
When I middle-click a link in a hover dropdown menu chrome should open link in a new tab.
Example URL : https://www.w3schools.com/howto/howto_css_dropdown.asp "

Observation:
Link is not opening in a new tab when we middle click on a link1,link2 & link3 in a hover dropdown menu chrome

Please find the attached screencast for reference & confirm the fix on above Observation (step :2).
Thank you!!

701637-Linux.mp4
3.3 MB View Download
Labels: Merge-Request-58
jmukthavaram@ the second link has href's that doesn't do anything. It is a poor example you need to use the "Try it Yourself" link from that page which leads to: https://www.w3schools.com/howto/tryit.asp?filename=tryhow_css_js_dropdown_hover

And you can see the drop down links work correctly with middle click.
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 17 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 17 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/111a01efebf7e49dbe8bbd3c2b4b7c187aefd7b1

commit 111a01efebf7e49dbe8bbd3c2b4b7c187aefd7b1
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Mar 17 13:20:23 2017

Treat NotifyVirtual events as mouse move events for blink.

This restores the old logic we had for blink to deal with these as mouse
move events but keeping the mouseleave events when we leave the window.

NotifyInferior messages are already dropped at the X11 desktop tree
host but I didn't want to risk breaking any views with addressing this
release block stable issue.

BUG= 701637 , 450631 , 240300 , 352106 , 386896 , 569998 , 575208 

Review-Url: https://codereview.chromium.org/2751833006
Cr-Commit-Position: refs/heads/master@{#457411}
(cherry picked from commit 955f4364ffa5c275f04cb3c2d19f7ac63f7d8320)

Review-Url: https://codereview.chromium.org/2758443004 .
Cr-Commit-Position: refs/branch-heads/3029@{#261}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/111a01efebf7e49dbe8bbd3c2b4b7c187aefd7b1/ui/events/blink/web_input_event.cc

Cc: nzolghadr@chromium.org dtapu...@chromium.org
 Issue 702255  has been merged into this issue.

Comment 17 by chare...@gmail.com, Mar 17 2017

Just a heads up,  issue 702591  may be another duplicate of this, and chromium 59.0.3045.0 was confirmed to correct the issue in that report.
 Issue 702591  has been merged into this issue.
Labels: TE-Verified-M58 TE-Verified-58.0.3029.33
Verified the issue on Ubuntu 14.04 using chrome beta version #58.0.3029.33 as per the comment #0 and #13.
Observed that middle clicking the hover drop down menu opened in a new tab as expected.
Hence, fix is working as expected.

Attaching screencast for reference

Hence, adding the verified labels.
701637.ogv
18.8 MB Download
Cc: kochi@chromium.org
 Issue 704449  has been merged into this issue.
Cc: sureshkumari@chromium.org hdodda@chromium.org
 Issue 708473  has been merged into this issue.
 Issue 711103  has been merged into this issue.
This has started happening again on linux Version 58.0.3029.96 (64-bit)
agamble@ does it work fine in cinnamon? If so this is likely a dup of 713746
I tested cinnamon through Chrome Remote Desktop and it works. Using the command line flag "--disable-features=SendMouseLeaveEvents" also makes it work in wmii (the window manager I use).
I had reported #713746. It is working for me too in Cinnamon and Gnome-classic. With the command line flag given it also works now for me now in Fluxbox. Thanks!

I can now confirm these versions working in Fluxbox with the flag applied:
Google Chrome Version 58.0.3029.96 (64-bit)
Google Chrome Version 59.0.3071.36 (Offizieller Build) beta (64-Bit)
Google Chrome Version 60.0.3080.5 (Offizieller Build) dev (64-Bit)
I'm seeing this issue in Chrome 68.0.3440.84 on Ubuntu 16.04.5 using Fluxbox via Docker selenium/node-chrome-debug connected over VNC from my Mac running OSX 10.13.6 (17G65).

Sign in to add a comment