Consider refactoring media::VideoEncodeAccelerator to avoid using naked ptrs |
||
Issue descriptionCurrently, we pass a naked ptr to the client and try keeping it valid until Destroy() is called. This makes ownership very ambiguous and leads to unnecessary sychronization. https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?rcl=304bef4f5c6502b7a863bb7be2c956ff1fd1420f&l=119
,
Feb 6 2018
c.padhi@ still wanna work on it?
,
Feb 7 2018
Yeah sure. I can take up this one. We need to make Initialize asynchronous with the use of callbacks instead of naked ptr as client? This as I see, may be a major refactoring. Alternatively, can we pass weak ptr to client instead of its naked ptr? Your input, please.
,
Feb 7 2018
WeakPtrs sounds good (without having dwelt again in depth), as long as those are used and destroyed on the same thread... |
||
►
Sign in to add a comment |
||
Comment 1 by c.pa...@samsung.com
, Apr 17 2017