New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 701615 link

Starred by 1 user
Status: Fixed
Owner:
isherman@chromium.org
Closed: Mar 2017
Cc:
█ gsennton@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Android devices fail to clean up most successful crash report uploads

Project Member Reported by isherman@chromium.org, Mar 15 2017 
The Android crash reporting system periodically attempts to clean up any obsolete crash report files that might be hanging around on the user's system -- most notably, including any successfully uploaded files.  However, there is an error with the regex -- a typical uploaded file ends with ".upNNNN.tryN", whereas the code is expecting to see ".upNNNN" with no additional trailing text.

This is especially problematic for the Android Webview crash reports, as we cap the maximum number of reports we're willing to store on local disk.  It's not intended for already-uploaded reports to effectively reduce that cap -- in theory, we could end up blind to Webview crash reports after a while!

Comment 2 by isherman@chromium.org, Mar 15 2017

Labels: Merge-Request-58
Requesting merge to M58.  This is a small and high-priority fix for the Android Webview code.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 15 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 15 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49847a3deae80d50b37c471d69ba5db3b3332051

commit 49847a3deae80d50b37c471d69ba5db3b3332051
Author: Ilya Sherman <isherman@chromium.org>
Date: Wed Mar 15 19:49:48 2017

[Merge to M58] [Android Crash Reporting] Correct the regex for uploaded minidump filenames.

BUG= 701615 
TEST=CrashFileManagerTest
R=gsennton@chromium.org, mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2751903002
Cr-Commit-Position: refs/heads/master@{#457105}
(cherry picked from commit 3e31d9cc1a969da3159fc3ac132c4353a32c281d)

Review-Url: https://codereview.chromium.org/2751193002 .
Cr-Commit-Position: refs/branch-heads/3029@{#213}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/49847a3deae80d50b37c471d69ba5db3b3332051/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
[modify] https://crrev.com/49847a3deae80d50b37c471d69ba5db3b3332051/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java

Comment 5 by isherman@chromium.org, Mar 15 2017

Status: Fixed (was: Started)
►

Sign in to add a comment