New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701614 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Move overlay make.conf contents to profiles/base/make.defaults

Project Member Reported by bhthompson@google.com, Mar 15 2017

Issue description

The profiles/base/make.defaults file is a more appropriate place for USE flags, so we should move USE flags we set in make.conf to profiles/base/make.defaults.


 
Showing comments 134 - 233 of 233 Older
Project Member

Comment 134 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 137 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 138 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 140 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 141 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 142 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-fizz-private/+/9856c97d74ce49a5f27dfbd2007be8898fef83b0

commit 9856c97d74ce49a5f27dfbd2007be8898fef83b0
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:18:47 2018

Project Member

Comment 143 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-cave-private/+/680d0076e7e38f65d3fcae33b18936cfe73d6327

commit 680d0076e7e38f65d3fcae33b18936cfe73d6327
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:18:39 2018

Project Member

Comment 145 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 146 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-leon-private/+/df21e1d0e3188e887693d040978084512e26acb6

commit df21e1d0e3188e887693d040978084512e26acb6
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:18:51 2018

Project Member

Comment 147 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 148 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 149 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 150 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 151 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 152 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 153 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 155 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 156 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-zako-private/+/b93fe934d1626cf781968f2bc77202a1017e8bb3

commit b93fe934d1626cf781968f2bc77202a1017e8bb3
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:18:07 2018

Project Member

Comment 157 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 158 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 159 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 160 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 161 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/97410bc5d8078f9b119c9fde1ab2be090da48a20

commit 97410bc5d8078f9b119c9fde1ab2be090da48a20
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:18:00 2018

Project Member

Comment 162 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 163 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reks-private/+/a083815effce6ffec49272f8577145d4a724d34d

commit a083815effce6ffec49272f8577145d4a724d34d
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:18:05 2018

Project Member

Comment 164 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 165 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 166 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-gru-private/+/e233ac4a4f189fc4d69fc7972369f4b69eb76cdb

commit e233ac4a4f189fc4d69fc7972369f4b69eb76cdb
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:17:47 2018

Project Member

Comment 167 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 169 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 172 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 173 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 174 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 176 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 177 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 178 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 179 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 180 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 181 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 182 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 183 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 184 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chipset-bdw-private/+/06ae4d85d0eea56a4dc00521e7f61e077504e896

commit 06ae4d85d0eea56a4dc00521e7f61e077504e896
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:17:59 2018

Project Member

Comment 186 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 187 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-relm-private/+/d1ee7b324d1b617fdd289af829faccfd0453a88f

commit d1ee7b324d1b617fdd289af829faccfd0453a88f
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:18:20 2018

Project Member

Comment 188 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 189 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chipset-skl-private/+/59506c129156725b0bde2069c6aa388a9a5b7063

commit 59506c129156725b0bde2069c6aa388a9a5b7063
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:17:47 2018

Project Member

Comment 190 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 191 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 192 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 194 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 195 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-bob-private/+/9f11c97ede97fc18104ad79b88a306bbcf9a4871

commit 9f11c97ede97fc18104ad79b88a306bbcf9a4871
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:18:27 2018

Project Member

Comment 196 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 198 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-cyan-private/+/a0070a214d0385e165e0c4eca5d070cf560d9eac

commit a0070a214d0385e165e0c4eca5d070cf560d9eac
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 20:17:58 2018

Project Member

Comment 199 by bugdroid1@chromium.org, Sep 17

Project Member

Comment 200 by bugdroid1@chromium.org, Sep 17

Labels: merge-merged-firmware-grunt-11031.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-grunt-private/+/a0e5016820dbc8e6e375ce2e127d9708236d1e19

commit a0e5016820dbc8e6e375ce2e127d9708236d1e19
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 17 22:38:24 2018

Project Member

Comment 201 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/0dd7d6d87b32495700f6f2dec686c36540093838

commit 0dd7d6d87b32495700f6f2dec686c36540093838
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Sep 18 09:25:14 2018

chipset-*: move compiler settings to the profile

This lets us drop the now-empty make.conf.

BUG=chromium:701614
TEST=`portageq-$BOARD envvar CFLAGS CXXFLAGS LDFLAGS` is the same for all boards

Change-Id: I1e9f47a9f22ed2f73082d0fcfbc835612fde867f
Reviewed-on: https://chromium-review.googlesource.com/1228533
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-apl/make.conf
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-bsw/profiles/base/make.defaults
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-mt8173/profiles/base/make.defaults
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-mt8173/make.conf
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-stnyridge/profiles/base/make.defaults
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-rk3399/profiles/base/make.defaults
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-hsw/make.conf
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-bdw/make.conf
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-hsw/profiles/base/make.defaults
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-mt8183/make.conf
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-qc845/profiles/base/make.defaults
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-apl/profiles/base/make.defaults
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-cnl/make.conf
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-icl/profiles/base/make.defaults
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-skl/profiles/base/make.defaults
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-bsw/make.conf
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-icl/make.conf
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-mt8183/profiles/base/make.defaults
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-kbl/make.conf
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-rk3399/make.conf
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-stnyridge/make.conf
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-cnl/profiles/base/make.defaults
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-skl/make.conf
[delete] https://crrev.com/554b4c5cd0060f3bf9f0f9b346401cbf4a738e83/chipset-qc845/make.conf
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-kbl/profiles/base/make.defaults
[modify] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/chipset-bdw/profiles/base/make.defaults

Project Member

Comment 203 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/90b40ef9c47fd2879601911422dc3ef542b01ed0

commit 90b40ef9c47fd2879601911422dc3ef542b01ed0
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Sep 18 09:25:27 2018

move compiler settings to the profile for in-progress generic boards

These boards don't build normally, so add a CL to update them alone
to get pass the PreCQ/CQ.

Along those lines, we drop prebuilt.conf from mipsel-o32-generic &
x86-generic as they haven't been updated in a while and we have no
plans to restore them.

BUG=chromium:701614
TEST=`portageq-$BOARD envvar CFLAGS CXXFLAGS LDFLAGS` is the same for all boards

Change-Id: Id41cf2500472b87c26bfae585d8af41d299c3f5b
Reviewed-on: https://chromium-review.googlesource.com/1229243
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-ppcle-32-generic/make.conf
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-mipsel-n32-generic/profiles/base/make.defaults
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-x32-generic/profiles/base/make.defaults
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-ppcbe-32-generic/make.conf
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-ppcbe-64-generic/make.conf
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-ppcbe-64-generic/profiles/base/make.defaults
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-mipseb-n64-generic/profiles/base/make.defaults
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-mipseb-o32-generic/profiles/base/make.defaults
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-mipseb-o32-generic/make.conf
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-mipsel-o32-generic/prebuilt.conf
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-ppcle-32-generic/profiles/base/make.defaults
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-mipsel-o32-generic/profiles/base/make.defaults
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-x86-generic/make.conf
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-mipseb-n32-generic/profiles/base/make.defaults
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-mipsel-n32-generic/make.conf
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-ppcbe-32-generic/profiles/base/make.defaults
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-mipseb-n32-generic/make.conf
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-x86-generic/prebuilt.conf
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-ppcle-64-generic/profiles/base/make.defaults
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-mipseb-n64-generic/make.conf
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-x32-generic/make.conf
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-mipsel-n64-generic/make.conf
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-arm64-generic/profiles/base/make.defaults
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-x86-generic/profiles/base/make.defaults
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-arm64-generic/make.conf
[modify] https://crrev.com/90b40ef9c47fd2879601911422dc3ef542b01ed0/overlay-mipsel-n64-generic/profiles/base/make.defaults
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-mipsel-o32-generic/make.conf
[delete] https://crrev.com/701cd943f5b2eabd61abac33cb20da154c7970c8/overlay-ppcle-64-generic/make.conf

Project Member

Comment 204 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 205 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/735950e449430b7f782918071d15e6d3c914e6d5

commit 735950e449430b7f782918071d15e6d3c914e6d5
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Sep 18 09:25:17 2018

move compiler settings to the profile for EOL boards

This lets us drop the now-empty make.conf.

BUG=chromium:701614
TEST=`portageq-$BOARD envvar CFLAGS CXXFLAGS LDFLAGS` is the same for all boards

Change-Id: Id3fefda380579886f851d872621693f8c349484e
Reviewed-on: https://chromium-review.googlesource.com/1229244
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[delete] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/overlay-lumpy/make.conf
[delete] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/overlay-stumpy/make.conf
[delete] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/overlay-stout/make.conf
[delete] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/overlay-x86-zgb/make.conf
[modify] https://crrev.com/735950e449430b7f782918071d15e6d3c914e6d5/overlay-x86-zgb/profiles/base/make.defaults
[delete] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/overlay-parrot/make.conf
[modify] https://crrev.com/735950e449430b7f782918071d15e6d3c914e6d5/overlay-x86-mario/profiles/base/make.defaults
[modify] https://crrev.com/735950e449430b7f782918071d15e6d3c914e6d5/overlay-stumpy/profiles/base/make.defaults
[delete] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/overlay-x86-alex/make.conf
[delete] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/overlay-x86-mario/make.conf
[modify] https://crrev.com/735950e449430b7f782918071d15e6d3c914e6d5/overlay-stout/profiles/base/make.defaults
[modify] https://crrev.com/735950e449430b7f782918071d15e6d3c914e6d5/overlay-x86-alex/profiles/base/make.defaults
[modify] https://crrev.com/735950e449430b7f782918071d15e6d3c914e6d5/overlay-parrot/profiles/base/make.defaults
[modify] https://crrev.com/735950e449430b7f782918071d15e6d3c914e6d5/overlay-lumpy/profiles/base/make.defaults
[modify] https://crrev.com/735950e449430b7f782918071d15e6d3c914e6d5/overlay-butterfly/profiles/base/make.defaults
[delete] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/overlay-link/make.conf
[modify] https://crrev.com/735950e449430b7f782918071d15e6d3c914e6d5/overlay-link/profiles/base/make.defaults
[delete] https://crrev.com/0dd7d6d87b32495700f6f2dec686c36540093838/overlay-butterfly/make.conf

Project Member

Comment 206 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-orco-private/+/b33042cb437020634afefae5dc615c7efdee089c

commit b33042cb437020634afefae5dc615c7efdee089c
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Sep 18 09:25:15 2018

Project Member

Comment 207 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-sumo-private/+/2be5d1c3d7c0c19bf5b07c9bcbaeb217d0786b5a

commit 2be5d1c3d7c0c19bf5b07c9bcbaeb217d0786b5a
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Sep 18 09:25:21 2018

Project Member

Comment 208 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 209 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 210 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 212 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-kip-private/+/bf7bf204d0d88886d70ef77b3d6ca9a764589af7

commit bf7bf204d0d88886d70ef77b3d6ca9a764589af7
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Sep 18 09:25:27 2018

Project Member

Comment 213 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 214 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 215 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 216 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 217 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 218 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 219 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 220 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-heli-private/+/dc97c286794ebc0f7d307abc9b95d0bb32d5bb12

commit dc97c286794ebc0f7d307abc9b95d0bb32d5bb12
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Sep 18 09:25:29 2018

Project Member

Comment 221 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 222 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 223 by bugdroid1@chromium.org, Sep 18

Project Member

Comment 224 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/6cd2fc02edebef20f546e8acea952af539b6a867

commit 6cd2fc02edebef20f546e8acea952af539b6a867
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Sep 18 21:04:16 2018

{arm,amd64}-generic: move compiler settings to the profile

This lets us drop the now-empty make.conf.

BUG=chromium:701614
TEST=`portageq-$BOARD envvar CFLAGS CXXFLAGS LDFLAGS` is the same for all boards

Change-Id: I6507046301ea868df8c0007ae2625d0969c1aa40
Reviewed-on: https://chromium-review.googlesource.com/1229242
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/6cd2fc02edebef20f546e8acea952af539b6a867/overlay-amd64-generic/profiles/base/make.defaults
[modify] https://crrev.com/6cd2fc02edebef20f546e8acea952af539b6a867/overlay-arm-generic/make.conf
[modify] https://crrev.com/6cd2fc02edebef20f546e8acea952af539b6a867/overlay-arm-generic/profiles/base/make.defaults
[modify] https://crrev.com/6cd2fc02edebef20f546e8acea952af539b6a867/overlay-amd64-generic/make.conf

Project Member

Comment 225 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/ce420fea0340fb82450242aff453c5488709d7f4

commit ce420fea0340fb82450242aff453c5488709d7f4
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 24 19:10:45 2018

migrate compiler settings for a few leaf boards

These don't have chipset/baseboard overlays to build off of.

BUG=chromium:701614
TEST=`portageq-$BOARD envvar CFLAGS CXXFLAGS LDFLAGS` is the same for all boards

Change-Id: Ic825b2f7683cd8c1da6f80c2ee601f98d8b07eda
Reviewed-on: https://chromium-review.googlesource.com/1233034
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/ce420fea0340fb82450242aff453c5488709d7f4/overlay-peach/profiles/base/make.defaults
[modify] https://crrev.com/ce420fea0340fb82450242aff453c5488709d7f4/overlay-jadeite/profiles/base/make.defaults
[modify] https://crrev.com/ce420fea0340fb82450242aff453c5488709d7f4/overlay-tael/profiles/base/make.defaults
[delete] https://crrev.com/7dda3d3d6a56fc1c2edddb20a070659853551db5/overlay-tael/make.conf
[delete] https://crrev.com/7dda3d3d6a56fc1c2edddb20a070659853551db5/overlay-jadeite/make.conf
[delete] https://crrev.com/7dda3d3d6a56fc1c2edddb20a070659853551db5/overlay-kidd/make.conf
[delete] https://crrev.com/7dda3d3d6a56fc1c2edddb20a070659853551db5/overlay-veyron/make.conf
[delete] https://crrev.com/7dda3d3d6a56fc1c2edddb20a070659853551db5/overlay-peach/make.conf
[modify] https://crrev.com/ce420fea0340fb82450242aff453c5488709d7f4/overlay-kidd/profiles/base/make.defaults
[modify] https://crrev.com/ce420fea0340fb82450242aff453c5488709d7f4/overlay-veyron/profiles/base/make.defaults

Project Member

Comment 226 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/f262aae1f9fa1fd7a542b0afb5f850fcc6e9b4a4

commit f262aae1f9fa1fd7a542b0afb5f850fcc6e9b4a4
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Oct 03 20:59:23 2018

chipset-byt: move common compiler settings here

All boards that inherit chipset-byt have set their compiler flags to
the same value.  So move that to the chipset dir so we can delete a
bunch of (now empty) make.conf files.

BUG=chromium:701614
TEST=`portageq-$BOARD envvar CFLAGS CXXFLAGS LDFLAGS` is the same for all boards

Change-Id: Ib5c65f43769a6606338ebe8336c494cfad1f55d5
Reviewed-on: https://chromium-review.googlesource.com/1233033
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[delete] https://crrev.com/27518b9ce9a91a138405a7c33ccab59098eb9faa/overlay-glimmer/make.conf
[modify] https://crrev.com/f262aae1f9fa1fd7a542b0afb5f850fcc6e9b4a4/overlay-banjo/make.conf
[delete] https://crrev.com/27518b9ce9a91a138405a7c33ccab59098eb9faa/overlay-expresso/make.conf
[modify] https://crrev.com/f262aae1f9fa1fd7a542b0afb5f850fcc6e9b4a4/overlay-candy/make.conf
[delete] https://crrev.com/27518b9ce9a91a138405a7c33ccab59098eb9faa/overlay-kip/make.conf
[modify] https://crrev.com/f262aae1f9fa1fd7a542b0afb5f850fcc6e9b4a4/overlay-orco/make.conf
[delete] https://crrev.com/27518b9ce9a91a138405a7c33ccab59098eb9faa/overlay-squawks/make.conf
[delete] https://crrev.com/27518b9ce9a91a138405a7c33ccab59098eb9faa/overlay-swanky/make.conf
[delete] https://crrev.com/27518b9ce9a91a138405a7c33ccab59098eb9faa/overlay-quawks/make.conf
[modify] https://crrev.com/f262aae1f9fa1fd7a542b0afb5f850fcc6e9b4a4/overlay-sumo/make.conf
[modify] https://crrev.com/f262aae1f9fa1fd7a542b0afb5f850fcc6e9b4a4/overlay-heli/make.conf
[modify] https://crrev.com/f262aae1f9fa1fd7a542b0afb5f850fcc6e9b4a4/overlay-ninja/make.conf
[delete] https://crrev.com/27518b9ce9a91a138405a7c33ccab59098eb9faa/overlay-enguarde/make.conf
[delete] https://crrev.com/27518b9ce9a91a138405a7c33ccab59098eb9faa/overlay-clapper/make.conf
[modify] https://crrev.com/f262aae1f9fa1fd7a542b0afb5f850fcc6e9b4a4/chipset-byt/profiles/base/make.defaults
[delete] https://crrev.com/27518b9ce9a91a138405a7c33ccab59098eb9faa/overlay-gnawty/make.conf
[delete] https://crrev.com/27518b9ce9a91a138405a7c33ccab59098eb9faa/overlay-winky/make.conf
[modify] https://crrev.com/f262aae1f9fa1fd7a542b0afb5f850fcc6e9b4a4/overlay-rambi/make.conf

Project Member

Comment 227 by bugdroid1@chromium.org, Oct 11

Project Member

Comment 228 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/db56499acea62bdb1ad53abf85e47d9c914c0015

commit db56499acea62bdb1ad53abf85e47d9c914c0015
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Oct 17 19:20:23 2018

chipset-*: move compiler settings to the profile

This lets us drop the now-empty make.conf.

BUG=chromium:701614
TEST=`portageq-$BOARD envvar CFLAGS CXXFLAGS LDFLAGS` is the same for all boards

Change-Id: I1e9f47a9f22ed2f73082d0fcfbc835612fde867f
Reviewed-on: https://chromium-review.googlesource.com/1228533
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1286060
Reviewed-by: Martin Roth <martinroth@chromium.org>
Tested-by: Martin Roth <martinroth@chromium.org>

[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-apl/make.conf
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-bsw/profiles/base/make.defaults
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-mt8173/profiles/base/make.defaults
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-mt8173/make.conf
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-stnyridge/profiles/base/make.defaults
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-rk3399/profiles/base/make.defaults
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-hsw/make.conf
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-bdw/make.conf
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-hsw/profiles/base/make.defaults
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-mt8183/make.conf
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-qc845/profiles/base/make.defaults
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-apl/profiles/base/make.defaults
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-cnl/make.conf
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-icl/profiles/base/make.defaults
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-skl/profiles/base/make.defaults
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-bsw/make.conf
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-icl/make.conf
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-mt8183/profiles/base/make.defaults
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-kbl/make.conf
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-rk3399/make.conf
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-stnyridge/make.conf
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-cnl/profiles/base/make.defaults
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-skl/make.conf
[delete] https://crrev.com/f48907ca093e8a5c642afc70255bd07bb2d11826/chipset-qc845/make.conf
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-kbl/profiles/base/make.defaults
[modify] https://crrev.com/db56499acea62bdb1ad53abf85e47d9c914c0015/chipset-bdw/profiles/base/make.defaults

Project Member

Comment 229 by bugdroid1@chromium.org, Oct 25

Project Member

Comment 230 by bugdroid1@chromium.org, Oct 27

Project Member

Comment 232 by bugdroid1@chromium.org, Nov 1

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-guado-accelerator-private/+/11c65dd07119f14801eb9b3753e71b19362ca5c9

commit 11c65dd07119f14801eb9b3753e71b19362ca5c9
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Oct 31 23:14:01 2018

Project Member

Comment 233 by bugdroid1@chromium.org, Nov 23

Showing comments 134 - 233 of 233 Older

Sign in to add a comment