event_type DISABLED_BY_PREF incorrectly logged |
|||||
Issue descriptionDISABLED_BY_PREF is being logged alongside INITIATION_STATUS_LANGUAGE_IN_ULP. This is not the correct place. https://cs.chromium.org/chromium/src/components/translate/core/browser/translate_manager.cc?l=301 It should probably be logged alongside INITIATION_STATUS_DISABLED_BY_PREFS here: https://cs.chromium.org/chromium/src/components/translate/core/browser/translate_manager.cc?l=183
,
Mar 15 2017
+ rogerm - Rachel suggested that I ask you about this. Should I just move this logging up to near line 183?
,
Mar 15 2017
FRom what I can see, I suggest we add an enum for the ULP case in TEP event_types, replace the DISABLED_BY_PREFS there with this new case, and add the DISABLED_BY_PREFS at line 183.
,
Mar 17 2017
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a12e52d81346dd23d8284763d44c4ee657f11cea commit a12e52d81346dd23d8284763d44c4ee657f11cea Author: pdyson <pdyson@chromium.org> Date: Mon Mar 27 01:27:37 2017 Fix counting of ULP and DISABLED_BY_PREF. * Move counting of DISABLED_BY_PREF to the correct place. * Count when translate is not used due to ULP using a new enum: LANGUAGE_IN_ULP. BUG= 701608 Review-Url: https://codereview.chromium.org/2757173002 Cr-Commit-Position: refs/heads/master@{#459687} [modify] https://crrev.com/a12e52d81346dd23d8284763d44c4ee657f11cea/components/metrics/proto/translate_event.proto [modify] https://crrev.com/a12e52d81346dd23d8284763d44c4ee657f11cea/components/translate/core/browser/translate_manager.cc
,
Mar 27 2017
,
Apr 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by yyushkina@chromium.org
, Mar 15 2017