New issue
Advanced search Search tips

Issue 701604 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Remove amd64-generic-tot-chromium-pfq-informational-gn

Project Member Reported by steve...@chromium.org, Mar 15 2017

Issue description

I think we renamed this when it was an initial guinea pig for gn, we should rename it and do any related cleanup while we are at it.

 
Labels: -Pri-2 Pri-1
Status: Assigned (was: Available)
Summary: Remove amd64-generic-tot-chromium-pfq-informational-gn (was: Rename amd64-generic-tot-chromium-pfq-informational-gn)
I just realized this is a duplicate, we still have amd64-generic-tot-chromium-pfq-informational, we need to remove this one.

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b03399812be54ad742e8cc396c0b07e681d79ef5

commit b03399812be54ad742e8cc396c0b07e681d79ef5
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Mar 22 16:24:18 2017

chromeos_config.py: Eliminate deprecated -gn builders

BUG= chromium:701604 
TEST=cbuildbot/chromeos_config_unittest

Change-Id: Iec3c0d45727e335de671d4d2aa569ac239827f6b
Reviewed-on: https://chromium-review.googlesource.com/457638
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Trybot-Ready: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b03399812be54ad742e8cc396c0b07e681d79ef5/cbuildbot/config_dump.json
[modify] https://crrev.com/b03399812be54ad742e8cc396c0b07e681d79ef5/lib/config_lib.py
[modify] https://crrev.com/b03399812be54ad742e8cc396c0b07e681d79ef5/cbuildbot/chromeos_config.py

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d76e2fe4e437ac3208d1fa7be859c871d75efa83

commit d76e2fe4e437ac3208d1fa7be859c871d75efa83
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Mar 22 16:31:54 2017

Revert "CrOS: New Builder for chromiumos.chromium."

This reverts the CL that added
amd64-generic-tot-chromium-pfq-informational-gn

The -gn builders are now redundant since we only support GN
for chrome now..

This reverts commit 3a6cf2da51024774e3c79f17b0790039ec55d3e9.

BUG= 701604 

Change-Id: If5f027db4c88feb3e2412cc5cf7e0760e149a897
Reviewed-on: https://chromium-review.googlesource.com/457451
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/d76e2fe4e437ac3208d1fa7be859c871d75efa83/masters/master.chromiumos.chromium/slaves.cfg
[modify] https://crrev.com/d76e2fe4e437ac3208d1fa7be859c871d75efa83/masters/master.chromiumos.chromium/master_chromium_cfg.py
[modify] https://crrev.com/d76e2fe4e437ac3208d1fa7be859c871d75efa83/masters/master.chromiumos/slave_pool.json

Status: Fixed (was: Started)

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment