New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701579 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 709516



Sign in to add a comment

Report Page ID to Flywheel on main frame request and pingback

Project Member Reported by bengr@chromium.org, Mar 14 2017

Issue description

For server-side analysis, e.g., for previews, we should emit a page id on the main frame request and echo back that id in the pingback. In the main frame request, the id could be carried as a directive in the chrome-proxy header.
 
I plan to use GlobalRequestID (https://cs.chromium.org/chromium/src/content/public/browser/global_request_id.h?q=GlobalRequest+package:%5Echromium$&l=13), which is a pair of ints. This will also be the same ID for any redirects in the redirect chain.

I'd suggest we add a GlobalRequestID object to the proto that is a pair of int32s and the directive would look like PageID=x-y or similar.

Comment 2 by bengr@chromium.org, Mar 15 2017

sgtm.
Components: Privacy
I've decided to generate ID's in DataReductionProxyNetworkDelegate instead. GlobalRequestID is somewhat confusing (plzNavigate vs non-plzNavigate) and there is a possible privacy issue with reporting any information not related to data saver.
Blocking: 709516
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dba8a17e64a4d6bc35e941b2b2a46003c25c5505

commit dba8a17e64a4d6bc35e941b2b2a46003c25c5505
Author: ryansturm <ryansturm@chromium.org>
Date: Tue Apr 11 00:43:58 2017

Adding a data saver page id to requests and reports

This adds a page id determined from GlobalRequestID to main frame data
saver requests as well as PageLoad Metrics pingback reports.

BUG= 701579 

Review-Url: https://codereview.chromium.org/2803813003
Cr-Commit-Position: refs/heads/master@{#463470}

[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/core/browser/data_reduction_proxy_data.cc
[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/core/browser/data_reduction_proxy_data.h
[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc
[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client_unittest.cc
[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc
[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h
[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
[modify] https://crrev.com/dba8a17e64a4d6bc35e941b2b2a46003c25c5505/components/data_reduction_proxy/proto/pageload_metrics.proto

Status: Fixed (was: Assigned)
Cc: hkrishna@chromium.org ryansturm@chromium.org
 Issue 701512  has been merged into this issue.

Comment 9 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 10 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment