New issue
Advanced search Search tips

Issue 701567 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 673698



Sign in to add a comment

NodeFilter#acceptNode argument node should not be optional

Project Member Reported by lunalu@chromium.org, Mar 14 2017

Issue description

It should not be optional, to match the spec.
 

Comment 1 by tkent@chromium.org, Mar 17 2017

Labels: Hotlist-Interop Hotlist-GoodFirstBug
Status: Available (was: Untriaged)

Comment 2 by zend.j...@gmail.com, Mar 17 2017

I will take this,but I am new to chromium so need guidance on what should be tested and if other locations also require changes(what would break because of this)

I have found this file
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/NodeFilter.idl

Will start with above file and create a commit

Comment 3 Deleted

Hi,

Please review the below code.

https://codereview.chromium.org/2884263002
Project Member

Comment 5 by bugdroid1@chromium.org, May 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2785c18771b5327f278df28152d1b9ae5b9ce98

commit b2785c18771b5327f278df28152d1b9ae5b9ce98
Author: tripta.g <tripta.g@samsung.com>
Date: Sun May 21 22:53:26 2017

NodeFilter#acceptNode argument node should not be optional

BUG= 701567 

Review-Url: https://codereview.chromium.org/2884263002
Cr-Commit-Position: refs/heads/master@{#473486}

[modify] https://crrev.com/b2785c18771b5327f278df28152d1b9ae5b9ce98/AUTHORS
[modify] https://crrev.com/b2785c18771b5327f278df28152d1b9ae5b9ce98/third_party/WebKit/Source/core/dom/NodeFilter.idl

Comment 6 by tkent@chromium.org, May 21 2017

Labels: -Hotlist-Interop
Status: Fixed (was: Available)

Sign in to add a comment